Completed
Pull Request — master (#26805)
by Philipp
17:48
created
lib/private/DB/QueryBuilder/ExpressionBuilder/ExpressionBuilder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -360,7 +360,7 @@
 block discarded – undo
360 360
 	 *
361 361
 	 * @param string $column
362 362
 	 * @param mixed $type One of IQueryBuilder::PARAM_*
363
-	 * @return string
363
+	 * @return QueryFunction
364 364
 	 */
365 365
 	public function castColumn($column, $type) {
366 366
 		return new QueryFunction(
Please login to merge, or discard this patch.
lib/private/AppFramework/Http/Request.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -448,7 +448,7 @@
 block discarded – undo
448 448
 
449 449
 	/**
450 450
 	 * Checks if the CSRF check was correct
451
-	 * @return bool true if CSRF check passed
451
+	 * @return null|boolean true if CSRF check passed
452 452
 	 */
453 453
 	public function passesCSRFCheck() {
454 454
 		if($this->csrfTokenManager === null) {
Please login to merge, or discard this patch.
core/Controller/OccController.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -131,8 +131,8 @@
 block discarded – undo
131 131
 
132 132
 	/**
133 133
 	 * Check if command is allowed and has a valid security token
134
-	 * @param $command
135
-	 * @param $token
134
+	 * @param string $command
135
+	 * @param string $token
136 136
 	 */
137 137
 	protected function validateRequest($command, $token){
138 138
 		$allowedHosts = ['::1', '127.0.0.1', 'localhost'];
Please login to merge, or discard this patch.
lib/private/Files/External/Service/StoragesService.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,6 @@
 block discarded – undo
27 27
 use OCP\IUser;
28 28
 use OCP\ILogger;
29 29
 use OCP\Files\Folder;
30
-
31 30
 use OC\Share20\Exception\ShareNotFound;
32 31
 
33 32
 /**
Please login to merge, or discard this patch.
core/Application.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,6 @@
 block discarded – undo
32 32
 use OC\Core\Controller\AvatarController;
33 33
 use OC\Core\Controller\LoginController;
34 34
 use OC\Core\Controller\LostController;
35
-use OC\Core\Controller\OccController;
36 35
 use OC\Core\Controller\TokenController;
37 36
 use OC\Core\Controller\TwoFactorChallengeController;
38 37
 use OC\Core\Controller\UserController;
Please login to merge, or discard this patch.
lib/private/User/Manager.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -379,7 +379,6 @@
 block discarded – undo
379 379
 
380 380
 	/**
381 381
 	 * @param \Closure $callback
382
-	 * @param string $search
383 382
 	 * @since 9.0.0
384 383
 	 */
385 384
 	public function callForSeenUsers (\Closure $callback) {
Please login to merge, or discard this patch.
lib/public/IUserManager.php 1 patch
Doc Comments   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -45,6 +45,7 @@  discard block
 block discarded – undo
45 45
 	 *
46 46
 	 * @param \OCP\UserInterface $backend
47 47
 	 * @since 8.0.0
48
+	 * @return void
48 49
 	 */
49 50
 	public function registerBackend($backend);
50 51
 
@@ -60,12 +61,14 @@  discard block
 block discarded – undo
60 61
 	 *
61 62
 	 * @param \OCP\UserInterface $backend
62 63
 	 * @since 8.0.0
64
+	 * @return void
63 65
 	 */
64 66
 	public function removeBackend($backend);
65 67
 
66 68
 	/**
67 69
 	 * remove all user backends
68 70
 	 * @since 8.0.0
71
+	 * @return void
69 72
 	 */
70 73
 	public function clearBackends() ;
71 74
 
@@ -131,7 +134,7 @@  discard block
 block discarded – undo
131 134
 	/**
132 135
 	 * returns how many users per backend exist (if supported by backend)
133 136
 	 *
134
-	 * @return array an array of backend class as key and count number as value
137
+	 * @return integer an array of backend class as key and count number as value
135 138
 	 * @since 8.0.0
136 139
 	 */
137 140
 	public function countUsers();
@@ -140,6 +143,7 @@  discard block
 block discarded – undo
140 143
 	 * @param \Closure $callback
141 144
 	 * @param string $search
142 145
 	 * @since 9.0.0
146
+	 * @return void
143 147
 	 */
144 148
 	public function callForAllUsers (\Closure $callback, $search = '');
145 149
 
@@ -153,8 +157,8 @@  discard block
 block discarded – undo
153 157
 
154 158
 	/**
155 159
 	 * @param \Closure $callback
156
-	 * @param string $search
157 160
 	 * @since 9.2.0
161
+	 * @return void
158 162
 	 */
159 163
 	public function callForSeenUsers (\Closure $callback);
160 164
 
Please login to merge, or discard this patch.
lib/private/AvatarManager.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -99,6 +99,9 @@
 block discarded – undo
99 99
 		}
100 100
 	}
101 101
 
102
+	/**
103
+	 * @param string $userId
104
+	 */
102 105
 	private function buildAvatarPath($userId) {
103 106
 		$avatar = substr_replace(substr_replace(md5($userId), '/', 4, 0), '/', 2, 0);
104 107
 		return explode('/', $avatar);
Please login to merge, or discard this patch.
lib/private/legacy/app.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
 
165 165
 	/**
166 166
 	 * Enables the app as a theme if it has the type "theme"
167
-	 * @param $app
167
+	 * @param string $app
168 168
 	 */
169 169
 	private static function enableTheme($app) {
170 170
 		if (self::isType($app, 'theme')) {
@@ -1365,8 +1365,8 @@  discard block
 block discarded – undo
1365 1365
 	}
1366 1366
 
1367 1367
 	/**
1368
-	 * @param $config
1369
-	 * @param $l
1368
+	 * @param OCP\IConfig $config
1369
+	 * @param OCP\IL10N $l
1370 1370
 	 * @param $info
1371 1371
 	 * @throws Exception
1372 1372
 	 */
Please login to merge, or discard this patch.