Completed
Pull Request — master (#32373)
by Piotr
09:13
created
apps/dav/lib/CalDAV/CalDavBackend.php 2 patches
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -268,6 +268,9 @@  discard block
 block discarded – undo
268 268
 		return \array_values($calendars);
269 269
 	}
270 270
 
271
+	/**
272
+	 * @param string $principalUri
273
+	 */
271 274
 	public function getUsersOwnCalendars($principalUri) {
272 275
 		$principalUri = $this->convertPrincipal($principalUri, true);
273 276
 		$fields = \array_values($this->propertyMap);
@@ -1278,7 +1281,7 @@  discard block
 block discarded – undo
1278 1281
 	 * @param string $principalUri
1279 1282
 	 * @param string $uri
1280 1283
 	 * @param array $properties
1281
-	 * @return mixed
1284
+	 * @return integer
1282 1285
 	 * @throws Forbidden
1283 1286
 	 */
1284 1287
 	public function createSubscription($principalUri, $uri, array $properties) {
@@ -1685,6 +1688,9 @@  discard block
 block discarded – undo
1685 1688
 		return $this->sharingBackend->applyShareAcl($resourceId, $acl);
1686 1689
 	}
1687 1690
 
1691
+	/**
1692
+	 * @param boolean $toV2
1693
+	 */
1688 1694
 	private function convertPrincipal($principalUri, $toV2 = null) {
1689 1695
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
1690 1696
 			list(, $name) = URLUtil::splitPath($principalUri);
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@
 block discarded – undo
30 30
 use OCA\DAV\DAV\Sharing\Backend;
31 31
 use OCA\DAV\DAV\Sharing\IShareable;
32 32
 use OCP\DB\QueryBuilder\IQueryBuilder;
33
-use OCP\IConfig;
34 33
 use OCP\IDBConnection;
35 34
 use OCP\Security\ISecureRandom;
36 35
 use Sabre\CalDAV\Backend\AbstractBackend;
Please login to merge, or discard this patch.
apps/comments/lib/Dav/EntityCollection.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -116,7 +116,7 @@
 block discarded – undo
116 116
 	/**
117 117
 	 * Returns an array with all the child nodes
118 118
 	 *
119
-	 * @return \Sabre\DAV\INode[]
119
+	 * @return CommentNode[]
120 120
 	 */
121 121
 	public function getChildren() {
122 122
 		return $this->findChildren();
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/ShareTypeList.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@
 block discarded – undo
60 60
 	 * The deserialize method is called during xml parsing.
61 61
 	 *
62 62
 	 * @param Reader $reader
63
-	 * @return mixed
63
+	 * @return null|ShareTypeList
64 64
 	 */
65 65
 	public static function xmlDeserialize(Reader $reader) {
66 66
 		$shareTypes = [];
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/TagList.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@
 block discarded – undo
77 77
 	 * the next element.
78 78
 	 *
79 79
 	 * @param Reader $reader
80
-	 * @return mixed
80
+	 * @return null|TagList
81 81
 	 */
82 82
 	public static function xmlDeserialize(Reader $reader) {
83 83
 		$tags = [];
Please login to merge, or discard this patch.
apps/dav/lib/DAV/FileCustomPropertiesBackend.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -223,7 +223,7 @@
 block discarded – undo
223 223
 
224 224
 	/**
225 225
 	 * @param string $path
226
-	 * @return INode|null
226
+	 * @return null|Node
227 227
 	 */
228 228
 	protected function getNodeForPath($path) {
229 229
 		$node = parent::getNodeForPath($path);
Please login to merge, or discard this patch.
apps/dav/lib/DAV/SystemPrincipalBackend.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@
 block discarded – undo
143 143
 	 * Returns the list of members for a group-principal
144 144
 	 *
145 145
 	 * @param string $principal
146
-	 * @return array
146
+	 * @return string[]
147 147
 	 */
148 148
 	public function getGroupMemberSet($principal) {
149 149
 		// TODO: for now the group principal has only one member, the user itself
Please login to merge, or discard this patch.
apps/dav/lib/Upload/AssemblyStreamZsync.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
 	/**
184 184
 	 * @param IFile[] $nodes
185 185
 	 * @param IFile $backingFile
186
-	 * @param $fileLength
186
+	 * @param string $fileLength
187 187
 	 * @return resource
188 188
 	 *
189 189
 	 * @throws \BadMethodCallException
@@ -207,6 +207,9 @@  discard block
 block discarded – undo
207 207
 		return $wrapped;
208 208
 	}
209 209
 
210
+	/**
211
+	 * @param integer $current
212
+	 */
210 213
 	protected function getNextNodeStart($current) {
211 214
 		foreach ($this->sortedNodes as $node) {
212 215
 			if ($current >= $node['start'] && $current < $node['end']) {
@@ -220,7 +223,7 @@  discard block
 block discarded – undo
220 223
 	}
221 224
 
222 225
 	/**
223
-	 * @param $pos
226
+	 * @param integer $pos
224 227
 	 */
225 228
 	protected function getNodeForPosition($pos) {
226 229
 		foreach ($this->sortedNodes as $node) {
Please login to merge, or discard this patch.
apps/dav/lib/Upload/ChunkingPluginZsync.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -107,6 +107,7 @@
 block discarded – undo
107 107
 	 *
108 108
 	 * @param string &$zsyncMetadata actual metadata
109 109
 	 * @param string $destination destination path
110
+	 * @param string|null $zsyncMetadata
110 111
 	 */
111 112
 	private function postMoveZsync(&$zsyncMetadata, $destination) {
112 113
 		if (!$zsyncMetadata) {
Please login to merge, or discard this patch.
apps/files_sharing/lib/External/Manager.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -308,6 +308,9 @@
 block discarded – undo
308 308
 		return $result;
309 309
 	}
310 310
 
311
+	/**
312
+	 * @param string $mountPoint
313
+	 */
311 314
 	public function removeShare($mountPoint) {
312 315
 		$mountPointObj = $this->mountManager->find($mountPoint);
313 316
 		$id = $mountPointObj->getStorage()->getCache()->getId('');
Please login to merge, or discard this patch.