owncloud / core

apps/dav/lib/Upload/FutureFileZsync.php

Unused Use Statements -2 removed lines

@@ -20,8 +20,6 @@
  */
 namespace OCA\DAV\Upload;
 
-use OCA\DAV\Connector\Sabre\Directory;
-use Sabre\DAV\Exception\Forbidden;
 use Sabre\DAV\IFile;
 
 /**

apps/dav/lib/Files/ZsyncPlugin.php

Unused Use Statements -2 removed lines

@@ -21,8 +21,6 @@
 namespace OCA\DAV\Files;
 
 use OC\AppFramework\Http;
-use OCP\Files\NotFoundException;
-use OCP\Files\NotPermittedException;
 use Sabre\DAV\Server;
 use Sabre\DAV\ServerPlugin;
 use Sabre\DAV\PropFind;

apps/files_versions/lib/Storage.php

Doc Comments +3 added lines

@@ -310,6 +310,9 @@
 	}
 
 
+	/**
+	 * @param string $revision
+	 */
 	public static function restoreVersion($uid, $filename, $fileToRestore, $revision) {
 		if(\OCP\Config::getSystemValue('files_versions', Storage::DEFAULTENABLED) !== true) {
 			return false;

apps/dav/lib/Upload/ChunkingPluginZsync.php

Doc Comments +1 added lines

@@ -110,6 +110,7 @@
 	 *
 	 * @param string &$zsyncMetadata actual metadata
 	 * @param string $destination destination path
+	 * @param string|null $zsyncMetadata
 	 */
 	private function postMoveZsync(&$zsyncMetadata, $destination) {
 		if (!$zsyncMetadata)

lib/private/User/Manager.php

Doc Comments +3 added lines

@@ -432,6 +432,9 @@
 		}, $accounts);
 	}
 
+	/**
+	 * @param string $backendClass
+	 */
 	public function getBackend($backendClass) {
 		if (isset($this->backends[$backendClass])) {
 			return $this->backends[$backendClass];

Unused Use Statements -3 removed lines

@@ -41,9 +41,6 @@
 use OCP\IUser;
 use OCP\IUserManager;
 use OCP\IConfig;
-use OCP\User\IProvidesExtendedSearchBackend;
-use OCP\User\IProvidesEMailBackend;
-use OCP\User\IProvidesQuotaBackend;
 use OCP\UserInterface;
 use OCP\Util\UserSearch;
 use Symfony\Component\EventDispatcher\GenericEvent;

lib/private/Mail/Message.php

Doc Comments +1 added lines, -1 removed lines

@@ -109,7 +109,7 @@
 	/**
 	 * Returns the Reply-To address of this message
 	 *
-	 * @return array
+	 * @return string
 	 */
 	public function getReplyTo() {
 		return $this->swiftMessage->getReplyTo();

lib/private/Repair/RepairMismatchFileCachePath.php

Doc Comments +14 added lines, -1 removed lines

@@ -95,7 +95,7 @@ 
 	 * @param string $wrongPath wrong path of the entry to fix
 	 * @param int $correctStorageNumericId numeric idea of the correct storage
 	 * @param string $correctPath value to which to set the path of the entry 
-	 * @return bool true for success
+	 * @return boolean|null true for success
 	 */
 	private function fixEntryPath(IOutput $out, $fileId, $wrongPath, $correctStorageNumericId, $correctPath) {
 		// delete target if exists
@@ -125,6 +125,9 @@ 
 		$out->advance(1, $text);
 	}
 
+	/**
+	 * @param \OCP\DB\QueryBuilder\IQueryBuilder $qb
+	 */
 	private function addQueryConditionsParentIdWrongPath($qb) {
 		// thanks, VicDeo!
 		if ($this->connection->getDatabasePlatform() instanceof MySqlPlatform) {
@@ -164,6 +167,9 @@ 
 		}
 	}
 
+	/**
+	 * @param \OCP\DB\QueryBuilder\IQueryBuilder $qb
+	 */
 	private function addQueryConditionsNonExistingParentIdEntry($qb, $storageNumericId = null) {
 		// Subquery for parent existence
 		$qbe = $this->connection->getQueryBuilder();
@@ -193,6 +199,9 @@ 
 		}
 	}
 
+	/**
+	 * @param integer $storageNumericId
+	 */
 	private function countResultsToProcessParentIdWrongPath($storageNumericId = null) {
 		$qb = $this->connection->getQueryBuilder();
 		$qb->select($qb->createFunction('COUNT(*)'));
@@ -203,6 +212,9 @@ 
 		return $count;
 	}
 
+	/**
+	 * @param integer $storageNumericId
+	 */
 	private function countResultsToProcessNonExistingParentIdEntry($storageNumericId = null) {
 		$qb = $this->connection->getQueryBuilder();
 		$qb->select($qb->createFunction('COUNT(*)'));
@@ -353,6 +365,7 @@ 
 	 *
 	 * @param int $storageId storage id
 	 * @param string $path path for which to create the parent entry
+	 * @param integer $reuseFileId
 	 * @return int file id of the newly created parent
 	 */
 	private function getOrCreateEntry($storageId, $path, $reuseFileId = null) {

apps/dav/lib/CardDAV/CardDavBackend.php

Doc Comments +7 added lines, -2 removed lines

@@ -219,7 +219,8 @@ 
 	}
 
 	/**
-	 * @param $addressBookUri
+	 * @param string $addressBookUri
+	 * @param string $principal
 	 * @return array|null
 	 */
 	public function getAddressBooksByUri($principal, $addressBookUri) {
@@ -909,6 +910,7 @@ 
 	 *   * readOnly - boolean
 	 *   * summary - Optional, a description for the share
 	 *
+	 * @param integer $addressBookId
 	 * @return array
 	 */
 	public function getShares($addressBookId) {
@@ -1013,7 +1015,7 @@ 
 
 	/**
 	 * For shared address books the sharee is set in the ACL of the address book
-	 * @param $addressBookId
+	 * @param integer $addressBookId
 	 * @param $acl
 	 * @return array
 	 */
@@ -1021,6 +1023,9 @@ 
 		return $this->sharingBackend->applyShareAcl($addressBookId, $acl);
 	}
 
+	/**
+	 * @param boolean $toV2
+	 */
 	private function convertPrincipal($principalUri, $toV2 = null) {
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
 			list(, $name) = URLUtil::splitPath($principalUri);

apps/dav/lib/Server.php

Doc Comments +1 added lines, -1 removed lines

@@ -278,7 +278,7 @@
 	}
 
 	/**
-	 * @param string[] $subTree
+	 * @param string[] $subTrees
 	 * @return bool
 	 */
 	private function isRequestForSubtree(array $subTrees) {