owncloud / core

lib/private/Files/Type/Loader.php

Unused Use Statements -1 removed lines

@@ -24,7 +24,6 @@
 use OC\Files\Cache\Cache;
 use OCP\Files\IMimeTypeLoader;
 use OCP\IDBConnection;
-
 use Doctrine\DBAL\Exception\UniqueConstraintViolationException;
 
 /**

lib/private/Preview/Movie.php

Doc Comments +5 added lines, -5 removed lines

@@ -81,8 +81,8 @@ 
 	}
 
 	/**
-	 * @param $absPath
-	 * @return bool|string
+	 * @param string $absPath
+	 * @return false|string
 	 */
 	private function extractMp4CoverArtwork($absPath) {
 		if (isset($this->noArtworkIndex[$absPath])) {
@@ -118,9 +118,9 @@ 
 	}
 
 	/**
-	 * @param $absPath
-	 * @param $second
-	 * @return bool|string
+	 * @param string $absPath
+	 * @param integer $second
+	 * @return string|false
 	 */
 	private function generateFromMovie($absPath, $second) {
 		$tmpPath = \OC::$server->getTempManager()->getTemporaryFile();

lib/private/DB/MigrationService.php

Doc Comments +1 added lines, -1 removed lines

@@ -361,7 +361,7 @@
 
 	/**
 	 * @param string $version
-	 * @return mixed
+	 * @return \Doctrine\DBAL\Schema\Schema
 	 * @throws \Exception
 	 */
 	protected function createInstance($version) {

lib/private/L10N/L10N.php

Doc Comments +1 added lines, -1 removed lines

@@ -171,7 +171,7 @@
 	 * Returns an associative array with all translations
 	 *
 	 * Called by String
-	 * @return array
+	 * @return string[]
 	 */
 	public function getTranslations() {
 		return $this->translations;

lib/public/Template.php

Doc Comments +2 added lines, -2 removed lines

@@ -100,8 +100,8 @@
 /**
  * Return the relative date in relation to today. Returns something like "last hour" or "two month ago"
  * @param int $timestamp unix timestamp
- * @param boolean $dateOnly
- * @return \OC\L10N\L10NString human readable interpretation of the timestamp
+ * @param integer $dateOnly
+ * @return string human readable interpretation of the timestamp
  *
  * @deprecated 8.0.0 Use \OCP\Template::relative_modified_date() instead
  */

apps/dav/lib/Connector/Sabre/File.php

Doc Comments +7 added lines, -1 removed lines

@@ -248,6 +248,9 @@ 
 		return '"' . $this->info->getEtag() . '"';
 	}
 
+	/**
+	 * @param string $path
+	 */
 	private function getPartFileBasePath($path) {
 		$partFileInStorage = \OC::$server->getConfig()->getSystemValue('part_file_in_storage', true);
 		if ($partFileInStorage) {
@@ -617,7 +620,7 @@ 
 	/**
 	 * Set $algo to get a specific checksum, leave null to get all checksums
 	 * (space seperated)
-	 * @param null $algo
+	 * @param string $algo
 	 * @return string
 	 */
 	public function getChecksum($algo = null) {
@@ -640,6 +643,9 @@ 
 		return '';
 	}
 
+	/**
+	 * @param string $string
+	 */
 	protected function header($string) {
 		\header($string);
 	}

apps/files_trashbin/lib/Trashbin.php

Doc Comments +6 added lines, -2 removed lines

@@ -218,6 +218,9 @@ 
 
 	/**
 	 *
+	 * @param string $targetFilename
+	 * @param string $targetLocation
+	 * @param integer $timestamp
 	 */
 	public static function insertTrashEntry($user, $targetFilename, $targetLocation, $timestamp) {
 		$query = \OC_DB::prepare("INSERT INTO `*PREFIX*files_trash` (`id`,`timestamp`,`location`,`user`) VALUES (?,?,?,?)");
@@ -330,6 +333,7 @@ 
 	 * @param string $ownerPath path relative to the owner's home storage
 	 * @param integer $timestamp when the file was deleted
 	 * @param bool $forceCopy true to only make a copy of the versions into the trashbin
+	 * @param \OC\Files\Storage\Storage $sourceStorage
 	 */
 	private static function retainVersions($filename, $owner, $ownerPath, $timestamp, $sourceStorage = null, $forceCopy = false) {
 		if (\OCP\App::isEnabled('files_versions') && !empty($ownerPath)) {
@@ -780,7 +784,7 @@ 
 	 * if the size limit for the trash bin is reached, we delete the oldest
 	 * files in the trash bin until we meet the limit again
 	 *
-	 * @param array $files
+	 * @param \OCP\Files\FileInfo[] $files
 	 * @param string $user
 	 * @param int $availableSpace available disc space
 	 * @return int size of deleted files
@@ -808,7 +812,7 @@ 
 	/**
 	 * delete files older then max storage time
 	 *
-	 * @param array $files list of files sorted by mtime
+	 * @param \OCP\Files\FileInfo[] $files list of files sorted by mtime
 	 * @param string $user
 	 * @return integer[] size of deleted files and number of deleted files
 	 */

lib/private/Files/Cache/Storage.php

Doc Comments +4 added lines, -1 removed lines

@@ -154,6 +154,9 @@ 
 		return $resultSet->fetchRow();
 	}
 
+	/**
+	 * @param string $storageId
+	 */
 	private static function unsetCache($storageId) {
 		// delete from local cache
 		if(self::$localCache !== null) {
@@ -205,7 +208,7 @@ 
 	/**
 	 * Get the numeric of the storage with the provided string id
 	 *
-	 * @param $storageId
+	 * @param string $storageId
 	 * @return int|null either the numeric storage id or null if the storage id is not knwon
 	 */
 	public static function getNumericStorageId($storageId) {

lib/private/Repair.php

Doc Comments +1 added lines, -1 removed lines

@@ -159,7 +159,7 @@
 	 * Returns expensive repair steps to be run on the
 	 * command line with a special option.
 	 *
-	 * @return IRepairStep[]
+	 * @return OldGroupMembershipShares[]
 	 */
 	public static function getExpensiveRepairSteps() {
 		return [