Completed
Pull Request — master (#26303)
by Philipp
12:52
created
apps/files_external/lib/Lib/Backend/Google.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,6 @@
 block discarded – undo
22 22
 namespace OCA\Files_External\Lib\Backend;
23 23
 
24 24
 use OCP\IL10N;
25
-use OCP\Files\External\DefinitionParameter;
26 25
 use OCP\Files\External\Auth\AuthMechanism;
27 26
 use OCP\Files\External\Backend\Backend;
28 27
 use OCA\Files_External\Lib\LegacyDependencyCheckPolyfill;
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Backend/Dropbox.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,6 @@
 block discarded – undo
22 22
 namespace OCA\Files_External\Lib\Backend;
23 23
 
24 24
 use OCP\IL10N;
25
-use OCP\Files\External\DefinitionParameter;
26 25
 use OCP\Files\External\Auth\AuthMechanism;
27 26
 use OCP\Files\External\Backend\Backend;
28 27
 use OCA\Files_External\Lib\LegacyDependencyCheckPolyfill;
Please login to merge, or discard this patch.
lib/private/App/AppManager.php 1 patch
Doc Comments   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
 	/**
121 121
 	 * List all installed apps
122 122
 	 *
123
-	 * @return string[]
123
+	 * @return integer[]
124 124
 	 */
125 125
 	public function getInstalledApps() {
126 126
 		return array_keys($this->getInstalledAppsValues());
@@ -347,6 +347,9 @@  discard block
 block discarded – undo
347 347
 		return in_array($appId, $this->shippedApps);
348 348
 	}
349 349
 
350
+	/**
351
+	 * @param string $appId
352
+	 */
350 353
 	private function isAlwaysEnabled($appId) {
351 354
 		$alwaysEnabled = $this->getAlwaysEnabledApps();
352 355
 		return in_array($appId, $alwaysEnabled);
@@ -374,7 +377,7 @@  discard block
 block discarded – undo
374 377
 
375 378
 	/**
376 379
 	 * @param string $package
377
-	 * @return mixed
380
+	 * @return integer
378 381
 	 * @since 9.2.0
379 382
 	 */
380 383
 	public function installApp($package) {
@@ -386,7 +389,7 @@  discard block
 block discarded – undo
386 389
 
387 390
 	/**
388 391
 	 * @param string $package
389
-	 * @return mixed
392
+	 * @return boolean
390 393
 	 * @since 9.2.0
391 394
 	 */
392 395
 	public function updateApp($package) {
Please login to merge, or discard this patch.
apps/files_sharing/lib/SharedMount.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
 	 *
111 111
 	 * @param string $newPath
112 112
 	 * @param \OCP\Share\IShare $share
113
-	 * @return bool
113
+	 * @return boolean|null
114 114
 	 */
115 115
 	private function updateFileTarget($newPath, &$share) {
116 116
 		$share->setTarget($newPath);
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
 	 * @param string $path
127 127
 	 * @param View $view
128 128
 	 * @param SharedMount[] $mountpoints
129
-	 * @return mixed
129
+	 * @return string
130 130
 	 */
131 131
 	private function generateUniqueTarget($path, $view, array $mountpoints) {
132 132
 		$pathinfo = pathinfo($path);
Please login to merge, or discard this patch.
lib/private/Files/Node/File.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
 	 * Creates a Folder that represents a non-existing path
33 33
 	 *
34 34
 	 * @param string $path path
35
-	 * @return string non-existing node class
35
+	 * @return NonExistingFile non-existing node class
36 36
 	 */
37 37
 	protected function createNonExistingNode($path) {
38 38
 		return new NonExistingFile($this->root, $this->view, $path);
Please login to merge, or discard this patch.
lib/private/Files/Node/Folder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
 	 * Creates a Folder that represents a non-existing path
35 35
 	 *
36 36
 	 * @param string $path path
37
-	 * @return string non-existing node class
37
+	 * @return NonExistingFolder non-existing node class
38 38
 	 */
39 39
 	protected function createNonExistingNode($path) {
40 40
 		return new NonExistingFolder($this->root, $this->view, $path);
Please login to merge, or discard this patch.
lib/private/DB/MigrationConfiguration.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -32,6 +32,9 @@
 block discarded – undo
32 32
 		$this->setMigrationsColumnName($this->getMigrationsColumnName());
33 33
 	}
34 34
 
35
+	/**
36
+	 * @param string $columnName
37
+	 */
35 38
 	public function setMigrationsColumnName($columnName) {
36 39
 		$columnName = $this->getConnection()->getDatabasePlatform()->quoteIdentifier($columnName);
37 40
 		parent::setMigrationsColumnName($columnName);
Please login to merge, or discard this patch.
apps/comments/lib/Dav/CommentNode.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@
 block discarded – undo
136 136
 	 * Returns the list of members for a group-principal
137 137
 	 *
138 138
 	 * @param string $principal
139
-	 * @return array
139
+	 * @return string[]
140 140
 	 */
141 141
 	function getGroupMemberSet($principal) {
142 142
 		// TODO: for now the group principal has only one member, the user itself
Please login to merge, or discard this patch.
apps/comments/lib/Dav/CommentsPlugin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@
 block discarded – undo
136 136
 	 * Returns the list of members for a group-principal
137 137
 	 *
138 138
 	 * @param string $principal
139
-	 * @return array
139
+	 * @return string[]
140 140
 	 */
141 141
 	function getGroupMemberSet($principal) {
142 142
 		// TODO: for now the group principal has only one member, the user itself
Please login to merge, or discard this patch.