owncloud / core

lib/private/DB/QueryBuilder/ExpressionBuilder/ExpressionBuilder.php

Doc Comments +1 added lines, -1 removed lines

@@ -360,7 +360,7 @@
 	 *
 	 * @param string $column
 	 * @param mixed $type One of IQueryBuilder::PARAM_*
-	 * @return string
+	 * @return QueryFunction
 	 */
 	public function castColumn($column, $type) {
 		return new QueryFunction(

apps/files_external/lib/Lib/Storage/SMB.php

Doc Comments +7 added lines, -1 removed lines

@@ -260,6 +260,9 @@ 
 		return $this->leave(__FUNCTION__, $result);
 	}
 
+	/**
+	 * @param string $path
+	 */
 	private function removeFromCache($path) {
 		$path = trim($path, '/');
 		// TODO The CappedCache does not really clear by prefix. It just clears all.
@@ -632,7 +635,7 @@ 
 	 * if wnd.logging.enable is set to true in the config will log a leave line
 	 * with the given function, the return value or the exception
 	 *
-	 * @param $function
+	 * @param string $function
 	 * @param mixed $result an exception will be logged and then returned
 	 * @return mixed
 	 */
@@ -659,6 +662,9 @@ 
 		return $result;
 	}
 
+	/**
+	 * @param string $function
+	 */
 	private function swallow($function, \Exception $exception) {
 		if (\OC::$server->getConfig()->getSystemValue('wnd.logging.enable', false) === true) {
 			Util::writeLog('wnd', "$function swallowing ".get_class($exception)

lib/private/AppFramework/Http/Request.php

Doc Comments +1 added lines, -1 removed lines

@@ -448,7 +448,7 @@
 
 	/**
 	 * Checks if the CSRF check was correct
-	 * @return bool true if CSRF check passed
+	 * @return null|boolean true if CSRF check passed
 	 */
 	public function passesCSRFCheck() {
 		if($this->csrfTokenManager === null) {

core/Controller/OccController.php

Doc Comments +2 added lines, -2 removed lines

@@ -131,8 +131,8 @@
 
 	/**
 	 * Check if command is allowed and has a valid security token
-	 * @param $command
-	 * @param $token
+	 * @param string $command
+	 * @param string $token
 	 */
 	protected function validateRequest($command, $token){
 		$allowedHosts = ['::1', '127.0.0.1', 'localhost'];

apps/dav/lib/Connector/Sabre/ShareTypeList.php

Doc Comments +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
 	 * The deserialize method is called during xml parsing.
 	 *
 	 * @param Reader $reader
-	 * @return mixed
+	 * @return null|ShareTypeList
 	 */
 	static function xmlDeserialize(Reader $reader) {
 		$shareTypes = [];

apps/dav/lib/Connector/Sabre/TagList.php

Doc Comments +1 added lines, -1 removed lines

@@ -79,7 +79,7 @@
 	 * the next element.
 	 *
 	 * @param Reader $reader
-	 * @return mixed
+	 * @return null|TagList
 	 */
 	static function xmlDeserialize(Reader $reader) {
 		$tags = [];

lib/private/Files/External/Service/StoragesService.php

Unused Use Statements -1 removed lines

@@ -27,7 +27,6 @@
 use OCP\IUser;
 use OCP\ILogger;
 use OCP\Files\Folder;
-
 use OC\Share20\Exception\ShareNotFound;
 
 /**

apps/dav/lib/CardDAV/AddressBookImpl.php

Doc Comments +3 added lines, -3 removed lines

@@ -51,7 +51,7 @@ 
 	 * @param AddressBook $addressBook
 	 * @param array $addressBookInfo
 	 * @param CardDavBackend $backend
-	 * @param IUrlGenerator $urlGenerator
+	 * @param IURLGenerator $urlGenerator
 	 */
 	public function __construct(
 			AddressBook $addressBook,
@@ -134,7 +134,7 @@ 
 	}
 
 	/**
-	 * @return mixed
+	 * @return integer
 	 * @since 5.0.0
 	 */
 	public function getPermissions() {
@@ -172,7 +172,7 @@ 
 	 * read vCard data into a vCard object
 	 *
 	 * @param string $cardData
-	 * @return VCard
+	 * @return \Sabre\VObject\Parser\Sabre\VObject\Document|null
 	 */
 	protected function readCard($cardData) {
 		return  Reader::read($cardData);

apps/dav/lib/CardDAV/CardDavBackend.php

Doc Comments +8 added lines, -3 removed lines

@@ -189,7 +189,8 @@ 
 	}
 
 	/**
-	 * @param $addressBookUri
+	 * @param string $addressBookUri
+	 * @param string $principal
 	 * @return array|null
 	 */
 	public function getAddressBooksByUri($principal, $addressBookUri) {
@@ -871,6 +872,7 @@ 
 	 *   * readOnly - boolean
 	 *   * summary - Optional, a description for the share
 	 *
+	 * @param integer $addressBookId
 	 * @return array
 	 */
 	public function getShares($addressBookId) {
@@ -924,7 +926,7 @@ 
 	 * read vCard data into a vCard object
 	 *
 	 * @param string $cardData
-	 * @return VCard
+	 * @return \Sabre\VObject\Parser\Sabre\VObject\Document|null
 	 */
 	protected function readCard($cardData) {
 		return  Reader::read($cardData);
@@ -970,7 +972,7 @@ 
 
 	/**
 	 * For shared address books the sharee is set in the ACL of the address book
-	 * @param $addressBookId
+	 * @param integer $addressBookId
 	 * @param $acl
 	 * @return array
 	 */
@@ -978,6 +980,9 @@ 
 		return $this->sharingBackend->applyShareAcl($addressBookId, $acl);
 	}
 
+	/**
+	 * @param boolean $toV2
+	 */
 	private function convertPrincipal($principalUri, $toV2) {
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
 			list(, $name) = URLUtil::splitPath($principalUri);