Completed
Pull Request — master (#30188)
by Jörn Friedrich
45:44 queued 32:36
created
apps/dav/lib/Server.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -278,7 +278,7 @@
 block discarded – undo
278 278
 	}
279 279
 
280 280
 	/**
281
-	 * @param string[] $subTree
281
+	 * @param string[] $subTrees
282 282
 	 * @return bool
283 283
 	 */
284 284
 	private function isRequestForSubtree(array $subTrees) {
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Storage/SMB.php 1 patch
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -284,6 +284,9 @@  discard block
 block discarded – undo
284 284
 		return $this->leave(__FUNCTION__, $result);
285 285
 	}
286 286
 
287
+	/**
288
+	 * @param string $path
289
+	 */
287 290
 	private function removeFromCache($path) {
288 291
 		$path = trim($path, '/');
289 292
 		// TODO The CappedCache does not really clear by prefix. It just clears all.
@@ -673,7 +676,7 @@  discard block
 block discarded – undo
673 676
 	 * if smb.logging.enable is set to true in the config will log a leave line
674 677
 	 * with the given function, the return value or the exception
675 678
 	 *
676
-	 * @param $function
679
+	 * @param string $function
677 680
 	 * @param mixed $result an exception will be logged and then returned
678 681
 	 * @return mixed
679 682
 	 */
@@ -700,6 +703,9 @@  discard block
 block discarded – undo
700 703
 		return $result;
701 704
 	}
702 705
 
706
+	/**
707
+	 * @param string $function
708
+	 */
703 709
 	private function swallow($function, \Exception $exception) {
704 710
 		if (\OC::$server->getConfig()->getSystemValue('smb.logging.enable', false) === true) {
705 711
 			Util::writeLog('smb', "$function swallowing ".get_class($exception)
Please login to merge, or discard this patch.
lib/private/Share/MailNotifications.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -180,10 +180,10 @@
 block discarded – undo
180 180
 	 * inform recipient about public link share
181 181
 	 *
182 182
 	 * @param string $recipient recipient email address
183
-	 * @param string $filename the shared file
184
-	 * @param string $link the public link
185 183
 	 * @param array $options allows ['cc'] and ['bcc'] recipients
186
-	 * @param int $expiration expiration date (timestamp)
184
+	 * @param string $subject
185
+	 * @param boolean|string $htmlBody
186
+	 * @param boolean|string $textBody
187 187
 	 * @return string[] $result of failed recipients
188 188
 	 */
189 189
 	public function sendLinkShareMailFromBody($recipient, $subject, $htmlBody, $textBody, $options = array()) {
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/CalDavBackend.php 1 patch
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -270,6 +270,9 @@  discard block
 block discarded – undo
270 270
 		return array_values($calendars);
271 271
 	}
272 272
 
273
+	/**
274
+	 * @param string $principalUri
275
+	 */
273 276
 	public function getUsersOwnCalendars($principalUri) {
274 277
 		$principalUri = $this->convertPrincipal($principalUri, true);
275 278
 		$fields = array_values($this->propertyMap);
@@ -1279,7 +1282,7 @@  discard block
 block discarded – undo
1279 1282
 	 * @param string $principalUri
1280 1283
 	 * @param string $uri
1281 1284
 	 * @param array $properties
1282
-	 * @return mixed
1285
+	 * @return integer
1283 1286
 	 * @throws Forbidden
1284 1287
 	 */
1285 1288
 	function createSubscription($principalUri, $uri, array $properties) {
@@ -1685,6 +1688,9 @@  discard block
 block discarded – undo
1685 1688
 		return $this->sharingBackend->applyShareAcl($resourceId, $acl);
1686 1689
 	}
1687 1690
 
1691
+	/**
1692
+	 * @param boolean $toV2
1693
+	 */
1688 1694
 	private function convertPrincipal($principalUri, $toV2 = null) {
1689 1695
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
1690 1696
 			list(, $name) = URLUtil::splitPath($principalUri);
Please login to merge, or discard this patch.
lib/private/legacy/app.php 2 patches
Doc Comments   -4 removed lines patch added patch discarded remove patch
@@ -623,7 +623,6 @@  discard block
 block discarded – undo
623 623
 	 * Read all app metadata from the info.xml file
624 624
 	 *
625 625
 	 * @param string $appId id of the app or the path of the info.xml file
626
-	 * @param boolean $path (optional)
627 626
 	 * @return array|null
628 627
 	 * @note all data is read from info.xml, not just pre-defined fields
629 628
 	 * @deprecated use \OC::$server->getAppManager()->getAppInfo($appId)
@@ -780,9 +779,6 @@  discard block
 block discarded – undo
780 779
 	/**
781 780
 	 * List all apps, this is used in apps.php
782 781
 	 *
783
-	 * @param bool $onlyLocal
784
-	 * @param bool $includeUpdateInfo Should we check whether there is an update
785
-	 *                                in the app store?
786 782
 	 * @return array
787 783
 	 */
788 784
 	public static function listAllApps() {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,6 @@
 block discarded – undo
45 45
  *
46 46
  */
47 47
 use OC\App\DependencyAnalyzer;
48
-use OC\App\InfoParser;
49 48
 use OC\App\Platform;
50 49
 use OC\Installer;
51 50
 use OC\Repair;
Please login to merge, or discard this patch.