Completed
Pull Request — master (#23351)
by Robin
09:40
created
lib/public/files.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,6 +45,7 @@  discard block
 block discarded – undo
45 45
 class Files {
46 46
 	/**
47 47
 	 * Recusive deletion of folders
48
+	 * @param string $dir
48 49
 	 * @return bool
49 50
 	 * @since 5.0.0
50 51
 	 */
@@ -66,7 +67,7 @@  discard block
 block discarded – undo
66 67
 	/**
67 68
 	 * Search for files by mimetype
68 69
 	 * @param string $mimetype
69
-	 * @return array
70
+	 * @return \OC\Files\FileInfo[]
70 71
 	 * @since 6.0.0
71 72
 	 */
72 73
 	static public function searchByMime( $mimetype ) {
Please login to merge, or discard this patch.
lib/private/files/storage/wrapper/quota.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -159,7 +159,7 @@
 block discarded – undo
159 159
 	 * Checks whether the given path is a part file
160 160
 	 *
161 161
 	 * @param string $path Path that may identify a .part file
162
-	 * @return string File path without .part extension
162
+	 * @return boolean File path without .part extension
163 163
 	 * @note this is needed for reusing keys
164 164
 	 */
165 165
 	private function isPartFile($path) {
Please login to merge, or discard this patch.
lib/private/api.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -329,7 +329,7 @@
 block discarded – undo
329 329
 
330 330
 	/**
331 331
 	 * http basic auth
332
-	 * @return string|false (username, or false on failure)
332
+	 * @return string (username, or false on failure)
333 333
 	 */
334 334
 	private static function loginUser() {
335 335
 		if(self::$isLoggedIn === true) {
Please login to merge, or discard this patch.
lib/private/group/manager.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -152,7 +152,7 @@
 block discarded – undo
152 152
 
153 153
 	/**
154 154
 	 * @param string $gid
155
-	 * @return \OCP\IGroup
155
+	 * @return null|Group
156 156
 	 */
157 157
 	protected function getGroupObject($gid) {
158 158
 		$backends = array();
Please login to merge, or discard this patch.
lib/private/preview.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -923,7 +923,7 @@
 block discarded – undo
923 923
 	 * @param int $previewWidth
924 924
 	 * @param int $previewHeight
925 925
 	 *
926
-	 * @return int[]
926
+	 * @return double[]
927 927
 	 */
928 928
 	private function scale($image, $askedWidth, $askedHeight, $previewWidth, $previewHeight) {
929 929
 		$scalingUp = $this->getScalingUp();
Please login to merge, or discard this patch.
apps/dav/lib/dav/sharing/plugin.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,6 @@
 block discarded – undo
25 25
 use OCA\DAV\Connector\Sabre\Auth;
26 26
 use OCA\DAV\DAV\Sharing\Xml\Invite;
27 27
 use OCP\IRequest;
28
-use Sabre\DAV\Exception\BadRequest;
29 28
 use Sabre\DAV\Exception\NotFound;
30 29
 use Sabre\DAV\INode;
31 30
 use Sabre\DAV\PropFind;
Please login to merge, or discard this patch.
apps/dav/command/createaddressbook.php 1 patch
Unused Use Statements   -5 removed lines patch added patch discarded remove patch
@@ -22,11 +22,6 @@
 block discarded – undo
22 22
 namespace OCA\DAV\Command;
23 23
 
24 24
 use OCA\DAV\CardDAV\CardDavBackend;
25
-use OCA\DAV\Connector\Sabre\Principal;
26
-use OCP\IConfig;
27
-use OCP\IDBConnection;
28
-use OCP\IGroupManager;
29
-use OCP\ILogger;
30 25
 use OCP\IUserManager;
31 26
 use Symfony\Component\Console\Command\Command;
32 27
 use Symfony\Component\Console\Input\InputArgument;
Please login to merge, or discard this patch.
apps/dav/command/syncsystemaddressbook.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -21,10 +21,8 @@
 block discarded – undo
21 21
 namespace OCA\DAV\Command;
22 22
 
23 23
 use OCA\DAV\CardDAV\SyncService;
24
-use OCP\IUserManager;
25 24
 use Symfony\Component\Console\Command\Command;
26 25
 use Symfony\Component\Console\Helper\ProgressBar;
27
-use Symfony\Component\Console\Input\InputArgument;
28 26
 use Symfony\Component\Console\Input\InputInterface;
29 27
 use Symfony\Component\Console\Output\OutputInterface;
30 28
 
Please login to merge, or discard this patch.
apps/dav/lib/caldav/caldavbackend.php 1 patch
Doc Comments   +8 added lines, -2 removed lines patch added patch discarded remove patch
@@ -286,6 +286,9 @@  discard block
 block discarded – undo
286 286
 		return $calendar;
287 287
 	}
288 288
 
289
+	/**
290
+	 * @param integer $calendarId
291
+	 */
289 292
 	public function getCalendarById($calendarId) {
290 293
 		$fields = array_values($this->propertyMap);
291 294
 		$fields[] = 'id';
@@ -594,7 +597,7 @@  discard block
 block discarded – undo
594 597
 	 * calendar-data. If the result of a subsequent GET to this object is not
595 598
 	 * the exact same as this request body, you should omit the ETag.
596 599
 	 *
597
-	 * @param mixed $calendarId
600
+	 * @param integer $calendarId
598 601
 	 * @param string $objectUri
599 602
 	 * @param string $calendarData
600 603
 	 * @return string
@@ -1033,7 +1036,7 @@  discard block
 block discarded – undo
1033 1036
 	 * @param string $principalUri
1034 1037
 	 * @param string $uri
1035 1038
 	 * @param array $properties
1036
-	 * @return mixed
1039
+	 * @return integer
1037 1040
 	 */
1038 1041
 	function createSubscription($principalUri, $uri, array $properties) {
1039 1042
 
@@ -1374,6 +1377,9 @@  discard block
 block discarded – undo
1374 1377
 		return $this->sharingBackend->applyShareAcl($resourceId, $acl);
1375 1378
 	}
1376 1379
 
1380
+	/**
1381
+	 * @param boolean $toV2
1382
+	 */
1377 1383
 	private function convertPrincipal($principalUri, $toV2) {
1378 1384
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
1379 1385
 			list(, $name) = URLUtil::splitPath($principalUri);
Please login to merge, or discard this patch.