owncloud / core

apps/files_sharing/lib/API/Remote.php

Unused Use Statements -1 removed lines

@@ -24,7 +24,6 @@
 namespace OCA\Files_Sharing\API;
 
 use OC\Files\Filesystem;
-use OCA\FederatedFileSharing\DiscoveryManager;
 use OCA\Files_Sharing\External\Manager;
 use Symfony\Component\EventDispatcher\GenericEvent;
 

lib/private/AppFramework/Middleware/Security/CORSMiddleware.php

Unused Use Statements -1 removed lines

@@ -27,7 +27,6 @@
 
 use OC\AppFramework\Middleware\Security\Exceptions\SecurityException;
 use OC\AppFramework\Utility\ControllerMethodReflector;
-use OC\Authentication\Exceptions\PasswordLoginForbiddenException;
 use OCP\AppFramework\Controller;
 use OCP\AppFramework\Http;
 use OCP\AppFramework\Http\JSONResponse;

apps/files_trashbin/lib/Trashbin.php

Doc Comments +6 added lines, -2 removed lines

@@ -218,6 +218,9 @@ 
 
 	/**
 	 *
+	 * @param string $targetFilename
+	 * @param string $targetLocation
+	 * @param integer $timestamp
 	 */
 	public static function insertTrashEntry($user, $targetFilename, $targetLocation, $timestamp) {
 		$query = \OC_DB::prepare("INSERT INTO `*PREFIX*files_trash` (`id`,`timestamp`,`location`,`user`) VALUES (?,?,?,?)");
@@ -330,6 +333,7 @@ 
 	 * @param string $ownerPath path relative to the owner's home storage
 	 * @param integer $timestamp when the file was deleted
 	 * @param bool $forceCopy true to only make a copy of the versions into the trashbin
+	 * @param \OC\Files\Storage\Storage $sourceStorage
 	 */
 	private static function retainVersions($filename, $owner, $ownerPath, $timestamp, $sourceStorage = null, $forceCopy = false) {
 		if (\OCP\App::isEnabled('files_versions') && !empty($ownerPath)) {
@@ -780,7 +784,7 @@ 
 	 * if the size limit for the trash bin is reached, we delete the oldest
 	 * files in the trash bin until we meet the limit again
 	 *
-	 * @param array $files
+	 * @param \OCP\Files\FileInfo[] $files
 	 * @param string $user
 	 * @param int $availableSpace available disc space
 	 * @return int size of deleted files
@@ -808,7 +812,7 @@ 
 	/**
 	 * delete files older then max storage time
 	 *
-	 * @param array $files list of files sorted by mtime
+	 * @param \OCP\Files\FileInfo[] $files list of files sorted by mtime
 	 * @param string $user
 	 * @return integer[] size of deleted files and number of deleted files
 	 */

core/Command/Security/ListRoutes.php

Doc Comments +3 added lines

@@ -122,6 +122,9 @@
 		}
 	}
 
+	/**
+	 * @param integer $name
+	 */
 	private function buildController($name) {
 		$parts = explode('.', $name);
 		if (count($parts) === 4 && $parts[0] === 'ocs') {

core/Command/User/SyncBackend.php

Doc Comments +3 added lines, -3 removed lines

@@ -157,7 +157,7 @@ 
 	 * @param SyncService $syncService
 	 * @param UserInterface $backend
 	 * @param string $missingAccountsAction
-	 * @param array $validActions
+	 * @param string[] $validActions
 	 */
 	private function syncMultipleUsers (
 		InputInterface $input,
@@ -206,7 +206,7 @@ 
 	 * @param SyncService $syncService
 	 * @param UserInterface $backend
 	 * @param string $missingAccountsAction
-	 * @param array $validActions
+	 * @param string[] $validActions
 	 */
 	private function syncSingleUser(
 		$uid,
@@ -251,7 +251,7 @@ 
 	}
 
 	/**
-	 * @param array $uids a list of uids to the the action
+	 * @param string[] $uids a list of uids to the the action
 	 * @param callable $callbackExists the callback used if the account for the uid exists. The
 	 * uid and the specific account will be passed as parameter to the callback in that order
 	 * @param callable $callbackMissing the callback used if the account doesn't exists. The uid (not

core/Migrations/Version20170221114437.php

Unused Use Statements -2 removed lines

@@ -1,8 +1,6 @@
 <?php
 namespace OC\Migrations;
 
-use OC\Migration\OutputAdapter;
-use OC\Migration\SimpleOutput;
 use OC\User\AccountMapper;
 use OC\User\AccountTermMapper;
 use OC\User\Database;

lib/private/Repair.php

Doc Comments +1 added lines, -1 removed lines

@@ -159,7 +159,7 @@
 	 * Returns expensive repair steps to be run on the
 	 * command line with a special option.
 	 *
-	 * @return IRepairStep[]
+	 * @return OldGroupMembershipShares[]
 	 */
 	public static function getExpensiveRepairSteps() {
 		return [

lib/private/User/AccountMapper.php

Doc Comments +10 added lines, -2 removed lines

@@ -46,7 +46,7 @@ 
 
 	/**
 	 * Delegate to term mapper to avoid needing to inject term mapper
-	 * @param $account_id
+	 * @param integer $account_id
 	 * @param array $terms
 	 */
 	public function setTermsForAccount($account_id, array $terms) {
@@ -55,7 +55,7 @@ 
 
 	/**
 	 * Delegate to term mapper to avoid needing to inject term mapper
-	 * @param $account_id
+	 * @param integer $account_id
 	 * @return AccountTerm[] $terms
 	 */
 	public function findByAccountId($account_id) {
@@ -176,6 +176,9 @@ 
 		return $this->findEntities($qb->getSQL(), $qb->getParameters(), $limit, $offset);
 	}
 
+	/**
+	 * @param boolean $hasLoggedIn
+	 */
 	public function getUserCountPerBackend($hasLoggedIn) {
 		$qb = $this->db->getQueryBuilder();
 		$qb->select(['backend', $qb->createFunction('count(*) as `count`')])
@@ -218,6 +221,11 @@ 
 		return (int) $data['count'];
 	}
 
+	/**
+	 * @param \Closure $callback
+	 * @param string $search
+	 * @param boolean $onlySeen
+	 */
 	public function callForAllUsers($callback, $search, $onlySeen) {
 		$qb = $this->db->getQueryBuilder();
 		$qb->select(['*'])

lib/private/User/SyncServiceCallback.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
 

 namespace OC\User;

 

-use OCP\Migration\IOutput;

+use OCP\Migration\IOutput;
 use OCP\Util;

 

 class SyncServiceCallback {