Completed
Pull Request — master (#26628)
by Cornelius
09:15
created
apps/files_sharing/lib/Controller/ShareesController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -327,7 +327,7 @@
 block discarded – undo
327 327
 	 * split user and remote from federated cloud id
328 328
 	 *
329 329
 	 * @param string $address federated share address
330
-	 * @return array [user, remoteURL]
330
+	 * @return string[] [user, remoteURL]
331 331
 	 * @throws \Exception
332 332
 	 */
333 333
 	public function splitUserRemote($address) {
Please login to merge, or discard this patch.
apps/federation/lib/Controller/OCSAuthAPIController.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -164,6 +164,10 @@
 block discarded – undo
164 164
 			'data' => ['sharedSecret' => $sharedSecret]];
165 165
 	}
166 166
 
167
+	/**
168
+	 * @param string $url
169
+	 * @param string $token
170
+	 */
167 171
 	protected function isValidToken($url, $token) {
168 172
 		$storedToken = $this->dbHandler->getToken($url);
169 173
 		return hash_equals($storedToken, $token);
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/CalDavBackend.php 1 patch
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -262,6 +262,9 @@  discard block
 block discarded – undo
262 262
 		return array_values($calendars);
263 263
 	}
264 264
 
265
+	/**
266
+	 * @param string $principalUri
267
+	 */
265 268
 	public function getUsersOwnCalendars($principalUri) {
266 269
 		$principalUri = $this->convertPrincipal($principalUri, true);
267 270
 		$fields = array_values($this->propertyMap);
@@ -1254,7 +1257,7 @@  discard block
 block discarded – undo
1254 1257
 	 * @param string $principalUri
1255 1258
 	 * @param string $uri
1256 1259
 	 * @param array $properties
1257
-	 * @return mixed
1260
+	 * @return integer
1258 1261
 	 */
1259 1262
 	function createSubscription($principalUri, $uri, array $properties) {
1260 1263
 
@@ -1657,6 +1660,9 @@  discard block
 block discarded – undo
1657 1660
 		return $this->sharingBackend->applyShareAcl($resourceId, $acl);
1658 1661
 	}
1659 1662
 
1663
+	/**
1664
+	 * @param boolean $toV2
1665
+	 */
1660 1666
 	private function convertPrincipal($principalUri, $toV2) {
1661 1667
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
1662 1668
 			list(, $name) = URLUtil::splitPath($principalUri);
Please login to merge, or discard this patch.
lib/private/User/Manager.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -379,7 +379,6 @@
 block discarded – undo
379 379
 
380 380
 	/**
381 381
 	 * @param \Closure $callback
382
-	 * @param string $search
383 382
 	 * @since 9.0.0
384 383
 	 */
385 384
 	public function callForSeenUsers (\Closure $callback) {
Please login to merge, or discard this patch.
lib/public/IUserManager.php 1 patch
Doc Comments   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -45,6 +45,7 @@  discard block
 block discarded – undo
45 45
 	 *
46 46
 	 * @param \OCP\UserInterface $backend
47 47
 	 * @since 8.0.0
48
+	 * @return void
48 49
 	 */
49 50
 	public function registerBackend($backend);
50 51
 
@@ -60,12 +61,14 @@  discard block
 block discarded – undo
60 61
 	 *
61 62
 	 * @param \OCP\UserInterface $backend
62 63
 	 * @since 8.0.0
64
+	 * @return void
63 65
 	 */
64 66
 	public function removeBackend($backend);
65 67
 
66 68
 	/**
67 69
 	 * remove all user backends
68 70
 	 * @since 8.0.0
71
+	 * @return void
69 72
 	 */
70 73
 	public function clearBackends() ;
71 74
 
@@ -131,7 +134,7 @@  discard block
 block discarded – undo
131 134
 	/**
132 135
 	 * returns how many users per backend exist (if supported by backend)
133 136
 	 *
134
-	 * @return array an array of backend class as key and count number as value
137
+	 * @return integer an array of backend class as key and count number as value
135 138
 	 * @since 8.0.0
136 139
 	 */
137 140
 	public function countUsers();
@@ -140,6 +143,7 @@  discard block
 block discarded – undo
140 143
 	 * @param \Closure $callback
141 144
 	 * @param string $search
142 145
 	 * @since 9.0.0
146
+	 * @return void
143 147
 	 */
144 148
 	public function callForAllUsers (\Closure $callback, $search = '');
145 149
 
@@ -153,8 +157,8 @@  discard block
 block discarded – undo
153 157
 
154 158
 	/**
155 159
 	 * @param \Closure $callback
156
-	 * @param string $search
157 160
 	 * @since 9.2.0
161
+	 * @return void
158 162
 	 */
159 163
 	public function callForSeenUsers (\Closure $callback);
160 164
 
Please login to merge, or discard this patch.
lib/private/AvatarManager.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -99,6 +99,9 @@
 block discarded – undo
99 99
 		}
100 100
 	}
101 101
 
102
+	/**
103
+	 * @param string $userId
104
+	 */
102 105
 	private function buildAvatarPath($userId) {
103 106
 		$avatar = substr_replace(substr_replace(md5($userId), '/', 4, 0), '/', 2, 0);
104 107
 		return explode('/', $avatar);
Please login to merge, or discard this patch.
lib/private/legacy/app.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
 
165 165
 	/**
166 166
 	 * Enables the app as a theme if it has the type "theme"
167
-	 * @param $app
167
+	 * @param string $app
168 168
 	 */
169 169
 	private static function enableTheme($app) {
170 170
 		if (self::isType($app, 'theme')) {
@@ -1365,8 +1365,8 @@  discard block
 block discarded – undo
1365 1365
 	}
1366 1366
 
1367 1367
 	/**
1368
-	 * @param $config
1369
-	 * @param $l
1368
+	 * @param OCP\IConfig $config
1369
+	 * @param OCP\IL10N $l
1370 1370
 	 * @param $info
1371 1371
 	 * @throws Exception
1372 1372
 	 */
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/ImageExportPlugin.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -136,6 +136,9 @@
 block discarded – undo
136 136
 		return false;
137 137
 	}
138 138
 
139
+	/**
140
+	 * @param string $cardData
141
+	 */
139 142
 	private function readCard($cardData) {
140 143
 		return Reader::read($cardData);
141 144
 	}
Please login to merge, or discard this patch.
lib/private/L10N/Factory.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -278,6 +278,11 @@
 block discarded – undo
278 278
 	 */
279 279
 	// FIXME This method is only public, until \OCP\IL10N does not need it anymore,
280 280
 	// FIXME This is also the reason, why it is not in the public interface
281
+
282
+	/**
283
+	 * @param string $app
284
+	 * @param string $lang
285
+	 */
281 286
 	public function getL10nFilesForApp($app, $lang) {
282 287
 		$languageFiles = [];
283 288
 
Please login to merge, or discard this patch.