Completed
Pull Request — master (#25887)
by Thomas
29:42
created
lib/private/Repair/Collation.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@
 block discarded – undo
67 67
 	}
68 68
 
69 69
 	/**
70
-	 * @param \Doctrine\DBAL\Connection $connection
70
+	 * @param \OC\DB\Connection $connection
71 71
 	 * @return string[]
72 72
 	 */
73 73
 	protected function getAllNonUTF8BinTables($connection) {
Please login to merge, or discard this patch.
lib/private/Repair/InnoDB.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
 	}
54 54
 
55 55
 	/**
56
-	 * @param \Doctrine\DBAL\Connection $connection
56
+	 * @param \OCP\IDBConnection $connection
57 57
 	 * @return string[]
58 58
 	 */
59 59
 	private function getAllMyIsamTables($connection) {
Please login to merge, or discard this patch.
lib/private/AppFramework/Http.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -110,7 +110,7 @@
 block discarded – undo
110 110
 
111 111
 	/**
112 112
 	 * Gets the correct header
113
-	 * @param Http::CONSTANT $status the constant from the Http class
113
+	 * @param integer $status the constant from the Http class
114 114
 	 * @param \DateTime $lastModified formatted last modified date
115 115
 	 * @param string $ETag the etag
116 116
 	 * @return string
Please login to merge, or discard this patch.
lib/private/AppFramework/Utility/ControllerMethodReflector.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
 
47 47
 
48 48
 	/**
49
-	 * @param object $object an object or classname
49
+	 * @param \OCP\AppFramework\Controller $object an object or classname
50 50
 	 * @param string $method the method which we want to inspect
51 51
 	 */
52 52
 	public function reflect($object, $method){
Please login to merge, or discard this patch.
lib/private/Encryption/Util.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@
 block discarded – undo
30 30
 use OC\Files\Filesystem;
31 31
 use OC\Files\View;
32 32
 use OCP\Encryption\IEncryptionModule;
33
-use OCP\Files\Storage;
34 33
 use OCP\IConfig;
35 34
 
36 35
 class Util {
Please login to merge, or discard this patch.
lib/private/Files/Cache/Cache.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -144,6 +144,9 @@
 block discarded – undo
144 144
 		return true;
145 145
 	}
146 146
 
147
+	/**
148
+	 * @param string $path
149
+	 */
147 150
 	public function url_stat($path) {
148 151
 		if (isset(self::$data[$path])) {
149 152
 			$size = strlen(self::$data[$path]);
Please login to merge, or discard this patch.
lib/private/Files/Config/UserMountCache.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -206,7 +206,7 @@
 block discarded – undo
206 206
 	}
207 207
 
208 208
 	/**
209
-	 * @param $fileId
209
+	 * @param integer $fileId
210 210
 	 * @return array
211 211
 	 * @throws \OCP\Files\NotFoundException
212 212
 	 */
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -23,8 +23,6 @@
 block discarded – undo
23 23
 
24 24
 namespace OC\Files\Config;
25 25
 
26
-use Doctrine\DBAL\Exception\UniqueConstraintViolationException;
27
-use OC\Files\Filesystem;
28 26
 use OCA\Files_Sharing\SharedMount;
29 27
 use OCP\DB\QueryBuilder\IQueryBuilder;
30 28
 use OCP\Files\Config\ICachedMountInfo;
Please login to merge, or discard this patch.
lib/private/Files/Filesystem.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -62,7 +62,6 @@
 block discarded – undo
62 62
 use OC\Files\Mount\MountPoint;
63 63
 use OC\Files\Storage\StorageFactory;
64 64
 use OCP\Files\Config\IMountProvider;
65
-use OCP\Files\Mount\IMountPoint;
66 65
 use OCP\Files\NotFoundException;
67 66
 use OCP\IUserManager;
68 67
 
Please login to merge, or discard this patch.
Doc Comments   +28 added lines, -2 removed lines patch added patch discarded remove patch
@@ -355,6 +355,9 @@  discard block
 block discarded – undo
355 355
 		}
356 356
 	}
357 357
 
358
+	/**
359
+	 * @param string $root
360
+	 */
358 361
 	static public function init($user, $root) {
359 362
 		if (self::$defaultInstance) {
360 363
 			return false;
@@ -494,7 +497,7 @@  discard block
 block discarded – undo
494 497
 	/**
495 498
 	 * mount an \OC\Files\Storage\Storage in our virtual filesystem
496 499
 	 *
497
-	 * @param \OC\Files\Storage\Storage|string $class
500
+	 * @param string $class
498 501
 	 * @param array $arguments
499 502
 	 * @param string $mountpoint
500 503
 	 */
@@ -626,6 +629,9 @@  discard block
 block discarded – undo
626 629
 		return self::$defaultInstance->is_dir($path);
627 630
 	}
628 631
 
632
+	/**
633
+	 * @param string $path
634
+	 */
629 635
 	static public function is_file($path) {
630 636
 		return self::$defaultInstance->is_file($path);
631 637
 	}
@@ -638,6 +644,9 @@  discard block
 block discarded – undo
638 644
 		return self::$defaultInstance->filetype($path);
639 645
 	}
640 646
 
647
+	/**
648
+	 * @param string $path
649
+	 */
641 650
 	static public function filesize($path) {
642 651
 		return self::$defaultInstance->filesize($path);
643 652
 	}
@@ -650,6 +659,9 @@  discard block
 block discarded – undo
650 659
 		return self::$defaultInstance->isCreatable($path);
651 660
 	}
652 661
 
662
+	/**
663
+	 * @param string $path
664
+	 */
653 665
 	static public function isReadable($path) {
654 666
 		return self::$defaultInstance->isReadable($path);
655 667
 	}
@@ -662,6 +674,9 @@  discard block
 block discarded – undo
662 674
 		return self::$defaultInstance->isDeletable($path);
663 675
 	}
664 676
 
677
+	/**
678
+	 * @param string $path
679
+	 */
665 680
 	static public function isSharable($path) {
666 681
 		return self::$defaultInstance->isSharable($path);
667 682
 	}
@@ -679,6 +694,7 @@  discard block
 block discarded – undo
679 694
 	}
680 695
 
681 696
 	/**
697
+	 * @param string $path
682 698
 	 * @return string
683 699
 	 */
684 700
 	static public function file_get_contents($path) {
@@ -701,6 +717,10 @@  discard block
 block discarded – undo
701 717
 		return self::$defaultInstance->copy($path1, $path2);
702 718
 	}
703 719
 
720
+	/**
721
+	 * @param string $path
722
+	 * @param string $mode
723
+	 */
704 724
 	static public function fopen($path, $mode) {
705 725
 		return self::$defaultInstance->fopen($path, $mode);
706 726
 	}
@@ -716,6 +736,9 @@  discard block
 block discarded – undo
716 736
 		return self::$defaultInstance->fromTmpFile($tmpFile, $path);
717 737
 	}
718 738
 
739
+	/**
740
+	 * @param string $path
741
+	 */
719 742
 	static public function getMimeType($path) {
720 743
 		return self::$defaultInstance->getMimeType($path);
721 744
 	}
@@ -728,6 +751,9 @@  discard block
 block discarded – undo
728 751
 		return self::$defaultInstance->free_space($path);
729 752
 	}
730 753
 
754
+	/**
755
+	 * @param string $query
756
+	 */
731 757
 	static public function search($query) {
732 758
 		return self::$defaultInstance->search($query);
733 759
 	}
@@ -836,7 +862,7 @@  discard block
 block discarded – undo
836 862
 	 * @param string $path
837 863
 	 * @param boolean $includeMountPoints whether to add mountpoint sizes,
838 864
 	 * defaults to true
839
-	 * @return \OC\Files\FileInfo|bool False if file does not exist
865
+	 * @return \OCP\Files\FileInfo|null False if file does not exist
840 866
 	 */
841 867
 	public static function getFileInfo($path, $includeMountPoints = true) {
842 868
 		return self::$defaultInstance->getFileInfo($path, $includeMountPoints);
Please login to merge, or discard this patch.
lib/private/Files/Node/LazyRoot.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
 	 * Magic method to first get the real rootFolder and then
35 35
 	 * call $method with $args on it
36 36
 	 *
37
-	 * @param $method
37
+	 * @param string $method
38 38
 	 * @param $args
39 39
 	 * @return mixed
40 40
 	 */
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,9 +2,7 @@
 block discarded – undo
2 2
 
3 3
 namespace OC\Files\Node;
4 4
 
5
-use OC\Files\Mount\MountPoint;
6 5
 use OCP\Files\IRootFolder;
7
-use OCP\Files\NotPermittedException;
8 6
 
9 7
 /**
10 8
  * Class LazyRoot
Please login to merge, or discard this patch.