owncloud /
core
| Conditions | 8 |
| Paths | 29 |
| Total Lines | 79 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 72 | public function getCapabilities() { |
||
| 73 | $res = []; |
||
| 74 | |||
| 75 | if ($this->config->getAppValue('core', 'shareapi_enabled', 'yes') !== 'yes') { |
||
| 76 | $res['api_enabled'] = false; |
||
| 77 | $res['public'] = ['enabled' => false]; |
||
| 78 | $res['user'] = ['send_mail' => false]; |
||
| 79 | $res['resharing'] = false; |
||
| 80 | $res['can_share'] = false; |
||
| 81 | } else { |
||
| 82 | $res['api_enabled'] = true; |
||
| 83 | |||
| 84 | $public = []; |
||
| 85 | $public['enabled'] = $this->config->getAppValue('core', 'shareapi_allow_links', 'yes') === 'yes'; |
||
| 86 | if ($public['enabled']) { |
||
| 87 | $public['password'] = []; |
||
| 88 | $public['password']['enforced_for'] = []; |
||
| 89 | $roPasswordEnforced = $this->config->getAppValue('core', 'shareapi_enforce_links_password_read_only', 'no') === 'yes'; |
||
| 90 | $rwPasswordEnforced = $this->config->getAppValue('core', 'shareapi_enforce_links_password_read_write', 'no') === 'yes'; |
||
| 91 | $woPasswordEnforced = $this->config->getAppValue('core', 'shareapi_enforce_links_password_write_only', 'no') === 'yes'; |
||
| 92 | $public['password']['enforced_for']['read_only'] = $roPasswordEnforced; |
||
| 93 | $public['password']['enforced_for']['read_write'] = $rwPasswordEnforced; |
||
| 94 | $public['password']['enforced_for']['upload_only'] = $woPasswordEnforced; |
||
| 95 | $public['password']['enforced'] = $roPasswordEnforced || $rwPasswordEnforced || $woPasswordEnforced; |
||
| 96 | |||
| 97 | $public['expire_date'] = []; |
||
| 98 | $public['expire_date']['enabled'] = $this->config->getAppValue('core', 'shareapi_default_expire_date', 'no') === 'yes'; |
||
| 99 | if ($public['expire_date']['enabled']) { |
||
| 100 | $public['expire_date']['days'] = $this->config->getAppValue('core', 'shareapi_expire_after_n_days', '7'); |
||
| 101 | $public['expire_date']['enforced'] = $this->config->getAppValue('core', 'shareapi_enforce_expire_date', 'no') === 'yes'; |
||
| 102 | } |
||
| 103 | |||
| 104 | $public['send_mail'] = $this->config->getAppValue('core', 'shareapi_allow_public_notification', 'no') === 'yes'; |
||
| 105 | $public['social_share'] = $this->config->getAppValue('core', 'shareapi_allow_social_share', 'yes') === 'yes'; |
||
| 106 | $public['upload'] = $this->config->getAppValue('core', 'shareapi_allow_public_upload', 'yes') === 'yes'; |
||
| 107 | $public['multiple'] = true; |
||
| 108 | $public['supports_upload_only'] = true; |
||
| 109 | } |
||
| 110 | $res["public"] = $public; |
||
| 111 | |||
| 112 | $res['user']['send_mail'] = $this->config->getAppValue('core', 'shareapi_allow_mail_notification', 'no') === 'yes'; |
||
| 113 | |||
| 114 | $res['resharing'] = $this->config->getAppValue('core', 'shareapi_allow_resharing', 'yes') === 'yes'; |
||
| 115 | |||
| 116 | $res['group_sharing'] = $this->config->getAppValue('core', 'shareapi_allow_group_sharing', 'yes') === 'yes'; |
||
| 117 | |||
| 118 | $res['auto_accept_share'] = $this->config->getAppValue('core', 'shareapi_auto_accept_share', 'yes') === 'yes'; |
||
| 119 | |||
| 120 | $res['share_with_group_members_only'] = $this->config->getAppValue('core', 'shareapi_only_share_with_group_members', 'yes') === 'yes'; |
||
| 121 | $res['share_with_membership_groups_only'] = $this->config->getAppValue('core', 'shareapi_only_share_with_membership_groups', 'yes') === 'yes'; |
||
| 122 | |||
| 123 | if (\OC_Util::isSharingDisabledForUser($this->config, $this->groupManager, $this->userSession->getUser())) { |
||
| 124 | $res['can_share'] = false; |
||
| 125 | } else { |
||
| 126 | $res['can_share'] = true; |
||
| 127 | } |
||
| 128 | |||
| 129 | $user_enumeration = []; |
||
| 130 | $user_enumeration['enabled'] = $this->config->getAppValue('core', 'shareapi_allow_share_dialog_user_enumeration', 'yes') === 'yes'; |
||
| 131 | if ($user_enumeration['enabled']) { |
||
| 132 | $user_enumeration['group_members_only'] = $this->config->getAppValue('core', 'shareapi_share_dialog_user_enumeration_group_members', 'no') === 'yes'; |
||
| 133 | } |
||
| 134 | $res["user_enumeration"] = $user_enumeration; |
||
| 135 | |||
| 136 | $res['default_permissions'] = (int)$this->config->getAppValue('core', 'shareapi_default_permissions', \OCP\Constants::PERMISSION_ALL); |
||
| 137 | } |
||
| 138 | |||
| 139 | //Federated sharing |
||
| 140 | $res['federation'] = [ |
||
| 141 | 'outgoing' => $this->config->getAppValue('files_sharing', 'outgoing_server2server_share_enabled', 'yes') === 'yes', |
||
| 142 | 'incoming' => $this->config->getAppValue('files_sharing', 'incoming_server2server_share_enabled', 'yes') === 'yes' |
||
| 143 | ]; |
||
| 144 | |||
| 145 | $res['search_min_length'] = $this->userSearch->getSearchMinLength(); |
||
| 146 | |||
| 147 | return [ |
||
| 148 | 'files_sharing' => $res, |
||
| 149 | ]; |
||
| 150 | } |
||
| 151 | } |
||
| 152 |
