Completed
Pull Request — master (#30269)
by Thomas
47:17 queued 22:46
created
lib/private/legacy/template/functions.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -191,6 +191,7 @@
 block discarded – undo
191 191
 
192 192
 /**
193 193
  * @param string $path
194
+ * @param string $token
194 195
  */
195 196
 function publicPreview_icon ( $path, $token ) {
196 197
 	return \OC::$server->getURLGenerator()->linkToRoute('core_ajax_public_preview', ['x' => 32, 'y' => 32, 'file' => $path, 't' => $token]);
Please login to merge, or discard this patch.
apps/federatedfilesharing/lib/RequestHandler.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -566,7 +566,7 @@
 block discarded – undo
566 566
 	/**
567 567
 	 * update permissions in database
568 568
 	 *
569
-	 * @param IShare $share
569
+	 * @param Share\IShare $share
570 570
 	 * @param int $permissions
571 571
 	 */
572 572
 	protected function updatePermissionsInDatabase(IShare $share, $permissions) {
Please login to merge, or discard this patch.
lib/private/legacy/db.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -150,7 +150,6 @@
 block discarded – undo
150 150
 	/**
151 151
 	 * saves database schema to xml file
152 152
 	 * @param string $file name of file
153
-	 * @param int $mode
154 153
 	 * @return bool
155 154
 	 *
156 155
 	 * TODO: write more documentation
Please login to merge, or discard this patch.
core/Controller/OccController.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -131,8 +131,8 @@
 block discarded – undo
131 131
 
132 132
 	/**
133 133
 	 * Check if command is allowed and has a valid security token
134
-	 * @param $command
135
-	 * @param $token
134
+	 * @param string $command
135
+	 * @param string $token
136 136
 	 */
137 137
 	protected function validateRequest($command, $token){
138 138
 		$allowedHosts = ['::1', '127.0.0.1', 'localhost'];
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/ShareTypeList.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@
 block discarded – undo
60 60
 	 * The deserialize method is called during xml parsing.
61 61
 	 *
62 62
 	 * @param Reader $reader
63
-	 * @return mixed
63
+	 * @return null|ShareTypeList
64 64
 	 */
65 65
 	static function xmlDeserialize(Reader $reader) {
66 66
 		$shareTypes = [];
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/TagList.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@
 block discarded – undo
79 79
 	 * the next element.
80 80
 	 *
81 81
 	 * @param Reader $reader
82
-	 * @return mixed
82
+	 * @return null|TagList
83 83
 	 */
84 84
 	static function xmlDeserialize(Reader $reader) {
85 85
 		$tags = [];
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/AddressBookImpl.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 	 * @param AddressBook $addressBook
52 52
 	 * @param array $addressBookInfo
53 53
 	 * @param CardDavBackend $backend
54
-	 * @param IUrlGenerator $urlGenerator
54
+	 * @param IURLGenerator $urlGenerator
55 55
 	 */
56 56
 	public function __construct(
57 57
 			AddressBook $addressBook,
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
 	}
135 135
 
136 136
 	/**
137
-	 * @return mixed
137
+	 * @return integer
138 138
 	 * @since 5.0.0
139 139
 	 */
140 140
 	public function getPermissions() {
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
 	 * read vCard data into a vCard object
173 173
 	 *
174 174
 	 * @param string $cardData
175
-	 * @return VCard
175
+	 * @return \Sabre\VObject\Parser\Sabre\VObject\Document|null
176 176
 	 */
177 177
 	protected function readCard($cardData) {
178 178
 		return  Reader::read($cardData);
Please login to merge, or discard this patch.
apps/federation/lib/Controller/OCSAuthAPIController.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -164,6 +164,10 @@
 block discarded – undo
164 164
 			'data' => ['sharedSecret' => $sharedSecret]];
165 165
 	}
166 166
 
167
+	/**
168
+	 * @param string $url
169
+	 * @param string $token
170
+	 */
167 171
 	protected function isValidToken($url, $token) {
168 172
 		$storedToken = $this->dbHandler->getToken($url);
169 173
 		return hash_equals($storedToken, $token);
Please login to merge, or discard this patch.
lib/private/AvatarManager.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -99,6 +99,9 @@
 block discarded – undo
99 99
 		}
100 100
 	}
101 101
 
102
+	/**
103
+	 * @param string $userId
104
+	 */
102 105
 	private function buildAvatarPath($userId) {
103 106
 		$avatar = substr_replace(substr_replace(md5($userId), '/', 4, 0), '/', 2, 0);
104 107
 		return explode('/', $avatar);
Please login to merge, or discard this patch.