Completed
Pull Request — master (#22648)
by Robin
15:12
created
apps/dav/lib/systemtag/systemtagsobjectmappingcollection.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,6 @@
 block discarded – undo
27 27
 use OCP\IUser;
28 28
 use OCP\ILogger;
29 29
 use OCP\Files\Folder;
30
-
31 30
 use OC\Share20\Exception\ShareNotFound;
32 31
 
33 32
 /**
Please login to merge, or discard this patch.
apps/dav/lib/systemtag/systemtagsobjecttypecollection.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,6 @@
 block discarded – undo
27 27
 use OCP\IUser;
28 28
 use OCP\ILogger;
29 29
 use OCP\Files\Folder;
30
-
31 30
 use OC\Share20\Exception\ShareNotFound;
32 31
 
33 32
 /**
Please login to merge, or discard this patch.
apps/files_trashbin/lib/trashbin.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -655,7 +655,7 @@  discard block
 block discarded – undo
655 655
 	 * if the size limit for the trash bin is reached, we delete the oldest
656 656
 	 * files in the trash bin until we meet the limit again
657 657
 	 *
658
-	 * @param array $files
658
+	 * @param \OCP\Files\FileInfo[] $files
659 659
 	 * @param string $user
660 660
 	 * @param int $availableSpace available disc space
661 661
 	 * @return int size of deleted files
@@ -683,7 +683,7 @@  discard block
 block discarded – undo
683 683
 	/**
684 684
 	 * delete files older then max storage time
685 685
 	 *
686
-	 * @param array $files list of files sorted by mtime
686
+	 * @param \OCP\Files\FileInfo[] $files list of files sorted by mtime
687 687
 	 * @param string $user
688 688
 	 * @return integer[] size of deleted files and number of deleted files
689 689
 	 */
Please login to merge, or discard this patch.
lib/private/repair/innodb.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
 	}
54 54
 
55 55
 	/**
56
-	 * @param \Doctrine\DBAL\Connection $connection
56
+	 * @param \OCP\IDBConnection $connection
57 57
 	 * @return string[]
58 58
 	 */
59 59
 	private function getAllMyIsamTables($connection) {
Please login to merge, or discard this patch.
lib/private/db.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -153,7 +153,6 @@  discard block
 block discarded – undo
153 153
 	/**
154 154
 	 * saves database schema to xml file
155 155
 	 * @param string $file name of file
156
-	 * @param int $mode
157 156
 	 * @return bool
158 157
 	 *
159 158
 	 * TODO: write more documentation
@@ -197,7 +196,7 @@  discard block
 block discarded – undo
197 196
 	 * simulate the database schema update
198 197
 	 * @param string $file file to read structure from
199 198
 	 * @throws Exception
200
-	 * @return string|boolean
199
+	 * @return boolean
201 200
 	 */
202 201
 	public static function simulateUpdateDbFromStructure($file) {
203 202
 		$schemaManager = self::getMDB2SchemaManager();
Please login to merge, or discard this patch.
apps/dav/lib/server.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,6 @@
 block discarded – undo
23 23
 namespace OCA\DAV;
24 24
 
25 25
 use OCA\DAV\CalDAV\Schedule\IMipPlugin;
26
-use OCA\DAV\Connector\FedAuth;
27 26
 use OCA\DAV\Connector\Sabre\Auth;
28 27
 use OCA\DAV\Connector\Sabre\BlockLegacyClientPlugin;
29 28
 use OCA\DAV\Files\CustomPropertiesBackend;
Please login to merge, or discard this patch.
apps/files_external/command/import.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -31,13 +31,10 @@
 block discarded – undo
31 31
 use OCP\IUserManager;
32 32
 use OCP\IUserSession;
33 33
 use Symfony\Component\Console\Command\Command;
34
-use Symfony\Component\Console\Helper\Table;
35
-use Symfony\Component\Console\Helper\TableHelper;
36 34
 use Symfony\Component\Console\Input\ArrayInput;
37 35
 use Symfony\Component\Console\Input\InputArgument;
38 36
 use Symfony\Component\Console\Input\InputInterface;
39 37
 use Symfony\Component\Console\Input\InputOption;
40
-use Symfony\Component\Console\Input\Input;
41 38
 use Symfony\Component\Console\Output\OutputInterface;
42 39
 
43 40
 class Import extends Base {
Please login to merge, or discard this patch.
lib/private/files/storage/storage.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -99,6 +99,7 @@  discard block
 block discarded – undo
99 99
 	 * @param int $type \OCP\Lock\ILockingProvider::LOCK_SHARED or \OCP\Lock\ILockingProvider::LOCK_EXCLUSIVE
100 100
 	 * @param \OCP\Lock\ILockingProvider $provider
101 101
 	 * @throws \OCP\Lock\LockedException
102
+	 * @return void
102 103
 	 */
103 104
 	public function acquireLock($path, $type, ILockingProvider $provider);
104 105
 
@@ -106,6 +107,7 @@  discard block
 block discarded – undo
106 107
 	 * @param string $path The path of the file to release the lock for
107 108
 	 * @param int $type \OCP\Lock\ILockingProvider::LOCK_SHARED or \OCP\Lock\ILockingProvider::LOCK_EXCLUSIVE
108 109
 	 * @param \OCP\Lock\ILockingProvider $provider
110
+	 * @return void
109 111
 	 */
110 112
 	public function releaseLock($path, $type, ILockingProvider $provider);
111 113
 
@@ -114,6 +116,7 @@  discard block
 block discarded – undo
114 116
 	 * @param int $type \OCP\Lock\ILockingProvider::LOCK_SHARED or \OCP\Lock\ILockingProvider::LOCK_EXCLUSIVE
115 117
 	 * @param \OCP\Lock\ILockingProvider $provider
116 118
 	 * @throws \OCP\Lock\LockedException
119
+	 * @return void
117 120
 	 */
118 121
 	public function changeLock($path, $type, ILockingProvider $provider);
119 122
 }
Please login to merge, or discard this patch.
lib/private/files/view.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
 	 * and does not take the chroot into account )
196 196
 	 *
197 197
 	 * @param string $path
198
-	 * @return \OCP\Files\Mount\IMountPoint
198
+	 * @return Mount\MountPoint|null
199 199
 	 */
200 200
 	public function getMount($path) {
201 201
 		return Filesystem::getMountManager()->find($this->getAbsolutePath($path));
@@ -906,7 +906,7 @@  discard block
 block discarded – undo
906 906
 
907 907
 	/**
908 908
 	 * @param string $path
909
-	 * @return bool|string
909
+	 * @return string|false
910 910
 	 * @throws \OCP\Files\InvalidPathException
911 911
 	 */
912 912
 	public function toTmpFile($path) {
@@ -2029,7 +2029,7 @@  discard block
 block discarded – undo
2029 2029
 
2030 2030
 	/**
2031 2031
 	 * @param string $filename
2032
-	 * @return array
2032
+	 * @return string[]
2033 2033
 	 * @throws \OC\User\NoUserException
2034 2034
 	 * @throws NotFoundException
2035 2035
 	 */
Please login to merge, or discard this patch.