Completed
Pull Request — master (#31634)
by Victor
12:36
created
settings/ChangePassword/Controller.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -67,6 +67,9 @@
 block discarded – undo
67 67
 		}
68 68
 	}
69 69
 
70
+	/**
71
+	 * @param string|boolean $username
72
+	 */
70 73
 	private static function sendNotificationMail($username) {
71 74
 		$userObject = \OC::$server->getUserManager()->get($username);
72 75
 		$email = $userObject->getEMailAddress();
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/SyncService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -245,7 +245,7 @@
 block discarded – undo
245 245
 	}
246 246
 
247 247
 	/**
248
-	 * @return array|null
248
+	 * @return string
249 249
 	 */
250 250
 	public function getLocalSystemAddressBook() {
251 251
 		if ($this->localSystemAddressBook === null) {
Please login to merge, or discard this patch.
apps/files_sharing/lib/Hooks.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,6 @@
 block discarded – undo
33 33
 use OCP\Share\IShare;
34 34
 use Symfony\Component\EventDispatcher\GenericEvent;
35 35
 use OCA\Files_Sharing\Service\NotificationPublisher;
36
-use OCP\Share\Exceptions\ShareNotFound;
37 36
 
38 37
 class Hooks {
39 38
 	/**
Please login to merge, or discard this patch.
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -138,6 +138,10 @@
 block discarded – undo
138 138
 		);
139 139
 	}
140 140
 
141
+	/**
142
+	 * @param IShare[] $shares
143
+	 * @param string $fileId
144
+	 */
141 145
 	private function filterSharesByFileId($shares, $fileId) {
142 146
 		return \array_filter($shares, function (IShare $share) use ($fileId) {
143 147
 			return \strval($share->getNodeId()) === \strval($fileId);
Please login to merge, or discard this patch.
lib/private/Share/MailNotifications.php 1 patch
Doc Comments   +4 added lines, -3 removed lines patch added patch discarded remove patch
@@ -218,10 +218,10 @@  discard block
 block discarded – undo
218 218
 	 * inform recipient about public link share
219 219
 	 *
220 220
 	 * @param string $recipient recipient email address
221
-	 * @param string $filename the shared file
222
-	 * @param string $link the public link
223 221
 	 * @param array $options allows ['cc'] and ['bcc'] recipients
224
-	 * @param int $expiration expiration date (timestamp)
222
+	 * @param string $subject
223
+	 * @param boolean|string $htmlBody
224
+	 * @param boolean|string $textBody
225 225
 	 * @return string[] $result of failed recipients
226 226
 	 */
227 227
 	public function sendLinkShareMailFromBody($recipient, $subject, $htmlBody, $textBody, $options = []) {
@@ -273,6 +273,7 @@  discard block
 block discarded – undo
273 273
 	 * @param string $personalNote optional personal note
274 274
 	 * @param string $prefix prefix of mail template files
275 275
 	 * @param IL10N || null $overrideL10n
276
+	 * @param IL10N $overrideL10n
276 277
 	 *
277 278
 	 * @return array an array of the html mail body and the plain text mail body
278 279
 	 */
Please login to merge, or discard this patch.