owncloud / core

apps/files_sharing/lib/External/Manager.php

Doc Comments +3 added lines

@@ -308,6 +308,9 @@
 		return $result;
 	}
 
+	/**
+	 * @param string $mountPoint
+	 */
 	public function removeShare($mountPoint) {
 		$mountPointObj = $this->mountManager->find($mountPoint);
 		$id = $mountPointObj->getStorage()->getCache()->getId('');

apps/files_trashbin/lib/Storage.php

Doc Comments +1 added lines, -1 removed lines

@@ -134,7 +134,7 @@
 	 * check if it is a file located in data/user/files only files in the
 	 * 'files' directory should be moved to the trash
 	 *
-	 * @param $path
+	 * @param string $path
 	 * @return bool
 	 */
 	protected function shouldMoveToTrash($path) {

apps/files_versions/lib/Storage.php

Doc Comments +3 added lines

@@ -315,6 +315,9 @@
 		}
 	}
 
+	/**
+	 * @param string $revision
+	 */
 	public static function restoreVersion($uid, $filename, $fileToRestore, $revision) {
 		if (\OCP\Config::getSystemValue('files_versions', Storage::DEFAULTENABLED) !== true) {
 			return false;

core/Command/User/SyncBackend.php

Doc Comments +4 added lines, -4 removed lines

@@ -169,7 +169,7 @@ 
 	 * @param SyncService $syncService
 	 * @param UserInterface $backend
 	 * @param string $missingAccountsAction
-	 * @param array $validActions
+	 * @param string[] $validActions
 	 */
 	private function syncMultipleUsers(
 		InputInterface $input,
@@ -217,7 +217,7 @@ 
 	 * @param UserInterface $backend
 	 * @param string $uid
 	 * @param string $missingAccountsAction
-	 * @param array $validActions
+	 * @param string[] $validActions
 	 */
 	private function syncSingleUser(
 		InputInterface $input,
@@ -258,7 +258,7 @@ 
 	}
 
 	/**
-	 * @param array $uids a list of uids to the the action
+	 * @param string[] $uids a list of uids to the the action
 	 * @param callable $callbackExists the callback used if the account for the uid exists. The
 	 * uid and the specific account will be passed as parameter to the callback in that order
 	 * @param callable $callbackMissing the callback used if the account doesn't exists. The uid (not
@@ -279,7 +279,7 @@ 
 	 * @param string[] $unknownUsers
 	 * @param InputInterface $input
 	 * @param OutputInterface $output
-	 * @param $missingAccountsAction
+	 * @param string $missingAccountsAction
 	 * @param $validActions
 	 */
 	private function handleUnknownUsers(array $unknownUsers, InputInterface $input, OutputInterface $output, $missingAccountsAction, $validActions) {

core/Controller/OccController.php

Doc Comments +2 added lines, -2 removed lines

@@ -131,8 +131,8 @@
 
 	/**
 	 * Check if command is allowed and has a valid security token
-	 * @param $command
-	 * @param $token
+	 * @param string $command
+	 * @param string $token
 	 */
 	protected function validateRequest($command, $token) {
 		$allowedHosts = ['::1', '127.0.0.1', 'localhost'];

lib/private/Files/Node/Root.php

Doc Comments +4 added lines, -1 removed lines

@@ -175,7 +175,7 @@ 
 	 * @param string $path
 	 * @throws \OCP\Files\NotFoundException
 	 * @throws \OCP\Files\NotPermittedException
-	 * @return File|Folder
+	 * @return string
 	 */
 	public function get($path) {
 		$path = $this->normalizePath($path);
@@ -373,6 +373,9 @@ 
 		return $folder;
 	}
 
+	/**
+	 * @param string $fullPath
+	 */
 	private function resolveVirtualNode($fullPath) {
 		$pieces = \explode('/', $fullPath);
 		if ($pieces[1] !== 'meta') {

lib/private/legacy/api.php

Doc Comments +2 added lines, -2 removed lines

@@ -269,7 +269,7 @@ 
 	/**
 	 * authenticate the api call
 	 * @param array $action the action details as supplied to OC_API::register()
-	 * @return bool
+	 * @return boolean|string
 	 */
 	private static function isAuthorised($action) {
 		$level = $action['authlevel'];
@@ -318,7 +318,7 @@ 
 
 	/**
 	 * http basic auth
-	 * @return string|false (username, or false on failure)
+	 * @return string|boolean (username, or false on failure)
 	 */
 	private static function loginUser() {
 		if (self::$isLoggedIn === true) {

lib/private/Repair/RepairMismatchFileCachePath.php

Doc Comments +14 added lines, -1 removed lines

@@ -102,7 +102,7 @@ 
 	 * @param string $wrongPath wrong path of the entry to fix
 	 * @param int $correctStorageNumericId numeric idea of the correct storage
 	 * @param string $correctPath value to which to set the path of the entry
-	 * @return bool true for success
+	 * @return boolean|null true for success
 	 */
 	private function fixEntryPath(IOutput $out, $fileId, $wrongPath, $correctStorageNumericId, $correctPath) {
 		// delete target if exists
@@ -132,6 +132,9 @@ 
 		$out->advance(1, $text);
 	}
 
+	/**
+	 * @param \OCP\DB\QueryBuilder\IQueryBuilder $qb
+	 */
 	private function addQueryConditionsParentIdWrongPath($qb) {
 		// thanks, VicDeo!
 		if ($this->connection->getDatabasePlatform() instanceof MySqlPlatform) {
@@ -171,6 +174,9 @@ 
 		}
 	}
 
+	/**
+	 * @param \OCP\DB\QueryBuilder\IQueryBuilder $qb
+	 */
 	private function addQueryConditionsNonExistingParentIdEntry($qb, $storageNumericId = null) {
 		// Subquery for parent existence
 		$qbe = $this->connection->getQueryBuilder();
@@ -200,6 +206,9 @@ 
 		}
 	}
 
+	/**
+	 * @param integer $storageNumericId
+	 */
 	private function countResultsToProcessParentIdWrongPath($storageNumericId = null) {
 		$qb = $this->connection->getQueryBuilder();
 		$qb->select($qb->createFunction('COUNT(*)'));
@@ -210,6 +219,9 @@ 
 		return $count;
 	}
 
+	/**
+	 * @param integer $storageNumericId
+	 */
 	private function countResultsToProcessNonExistingParentIdEntry($storageNumericId = null) {
 		$qb = $this->connection->getQueryBuilder();
 		$qb->select($qb->createFunction('COUNT(*)'));
@@ -359,6 +371,7 @@ 
 	 *
 	 * @param int $storageId storage id
 	 * @param string $path path for which to create the parent entry
+	 * @param integer $reuseFileId
 	 * @return int file id of the newly created parent
 	 */
 	private function getOrCreateEntry($storageId, $path, $reuseFileId = null) {

lib/private/Tags.php

Doc Comments +10 added lines, -2 removed lines

@@ -741,11 +741,19 @@ 
 	}
 
 	// case-insensitive array_search
+
+	/**
+	 * @param string $needle
+	 */
 	protected function array_searchi($needle, $haystack, $mem='getName') {
 		if (!\is_array($haystack)) {
 			return false;
 		}
 		return \array_search(\strtolower($needle), \array_map(
+
+			/**
+			 * @param string $tag
+			 */
 			function ($tag) use ($mem) {
 				return \strtolower(\call_user_func([$tag, $mem]));
 			}, $haystack)
@@ -770,7 +778,7 @@ 
 	* Get a tag by its name.
 	*
 	* @param string $name The tag name.
-	* @return integer|bool The tag object's offset within the $this->tags
+	* @return \OCP\AppFramework\Db\Entity The tag object's offset within the $this->tags
 	*                      array or false if it doesn't exist.
 	*/
 	private function getTagByName($name) {
@@ -781,7 +789,7 @@ 
 	* Get a tag by its ID.
 	*
 	* @param string $id The tag ID to look for.
-	* @return integer|bool The tag object's offset within the $this->tags
+	* @return \OCP\AppFramework\Db\Entity The tag object's offset within the $this->tags
 	*                      array or false if it doesn't exist.
 	*/
 	private function getTagById($id) {