owncloud / core

lib/private/files/type/loader.php

Unused Use Statements -1 removed lines

@@ -27,7 +27,6 @@
 use OCP\IUser;
 use OCP\ILogger;
 use OCP\Files\Folder;
-
 use OC\Share20\Exception\ShareNotFound;
 
 /**

lib/private/memcache/apc.php

Doc Comments +1 added lines, -1 removed lines

@@ -120,7 +120,7 @@
 	 * Set a value in the cache if it's not already stored
 	 *
 	 * @param string $key
-	 * @param mixed $value
+	 * @param integer $value
 	 * @param int $ttl Time To Live in seconds. Defaults to 60*60*24
 	 * @return bool
 	 */

apps/dav/lib/carddav/carddavbackend.php

Doc Comments +3 added lines

@@ -108,6 +108,9 @@
 		return $addressBooks;
 	}
 
+	/**
+	 * @param string $addressBookUri
+	 */
 	private function getAddressBooksByUri($addressBookUri) {
 		$query = $this->db->getQueryBuilder();
 		$result = $query->select(['id', 'uri', 'displayname', 'principaluri', 'description', 'synctoken'])

apps/dav/lib/connector/sabre/taglist.php

Doc Comments +1 added lines, -1 removed lines

@@ -78,7 +78,7 @@
 	 * the next element.
 	 *
 	 * @param Reader $reader
-	 * @return mixed
+	 * @return TagList
 	 */
 	static function xmlDeserialize(Reader $reader) {
 		$tags = [];

apps/user_ldap/lib/access.php

Doc Comments +10 added lines, -8 removed lines

@@ -390,7 +390,7 @@ 
 
 	/**
 	 * returns the internal ownCloud name for the given LDAP DN of the user, false on DN outside of search DN or failure
-	 * @param string $dn the dn of the user object
+	 * @param string $fdn the dn of the user object
 	 * @param string $ldapName optional, the display name of the object
 	 * @return string|false with with the name to use in ownCloud
 	 */
@@ -407,7 +407,7 @@ 
 
 	/**
 	 * returns an internal ownCloud name for the given LDAP DN, false on DN outside of search DN
-	 * @param string $dn the dn of the user object
+	 * @param string $fdn the dn of the user object
 	 * @param string $ldapName optional, the display name of the object
 	 * @param bool $isUser optional, whether it is a user object (otherwise group assumed)
 	 * @return string|false with with the name to use in ownCloud
@@ -662,7 +662,7 @@ 
 	 * the login filter.
 	 *
 	 * @param string $loginName
-	 * @param array $attributes optional, list of attributes to read
+	 * @param string[] $attributes optional, list of attributes to read
 	 * @return array
 	 */
 	public function fetchUsersByLoginName($loginName, $attributes = array('dn')) {
@@ -768,7 +768,7 @@ 
 
 	/**
 	 * @param string $filter
-	 * @param string|string[] $attr
+	 * @param string[] $attr
 	 * @param int $limit
 	 * @param int $offset
 	 * @return false|int
@@ -818,6 +818,7 @@ 
 	 * retrieved. Results will according to the order in the array.
 	 * @param int $limit optional, maximum results to be counted
 	 * @param int $offset optional, a starting point
+	 * @param string $filter
 	 * @return array|false array with the search result as first value and pagedSearchOK as
 	 * second | false if not successful
 	 */
@@ -864,7 +865,7 @@ 
 	 * @param bool $pagedSearchOK whether a paged search has been executed
 	 * @param bool $skipHandling required for paged search when cookies to
 	 * prior results need to be gained
-	 * @return bool cookie validity, true if we have more pages, false otherwise.
+	 * @return null|boolean cookie validity, true if we have more pages, false otherwise.
 	 */
 	private function processPagedSearchStatus($sr, $filter, $base, $iFoundItems, $limit, $offset, $pagedSearchOK, $skipHandling) {
 		$cookie = null;
@@ -1081,7 +1082,7 @@ 
 
 	/**
 	 * @param string $name
-	 * @return bool|mixed|string
+	 * @return string
 	 */
 	public function sanitizeUsername($name) {
 		if($this->connection->ldapIgnoreNamingRules) {
@@ -1105,6 +1106,7 @@ 
 	* escapes (user provided) parts for LDAP filter
 	* @param string $input, the provided value
 	* @param bool $allowAsterisk whether in * at the beginning should be preserved
+	* @param string $input
 	* @return string the escaped string
 	*/
 	public function escapeFilterPart($input, $allowAsterisk = false) {
@@ -1552,7 +1554,7 @@ 
 
 	/**
 	 * Check whether the most recent paged search was successful. It flushed the state var. Use it always after a possible paged search.
-	 * @return boolean|null true on success, null or false otherwise
+	 * @return boolean true on success, null or false otherwise
 	 */
 	public function getPagedSearchResultState() {
 		$result = $this->pagedSearchedSuccessful;
@@ -1567,7 +1569,7 @@ 
 	 * @param string[] $attr optional, when a certain attribute shall be filtered outside
 	 * @param int $limit
 	 * @param int $offset
-	 * @return bool|true
+	 * @return boolean
 	 */
 	private function initPagedSearch($filter, $bases, $attr, $limit, $offset) {
 		$pagedSearchOK = false;

apps/files_sharing/api/share20ocs.php

Unused Use Statements -1 removed lines

@@ -27,7 +27,6 @@
 use OCP\IUser;
 use OCP\ILogger;
 use OCP\Files\Folder;
-
 use OC\Share20\Exception\ShareNotFound;
 
 /**

lib/private/files/cache/cache.php

Doc Comments +3 added lines

@@ -144,6 +144,9 @@
 		return true;
 	}
 
+	/**
+	 * @param string $path
+	 */
 	public function url_stat($path) {
 		if (isset(self::$data[$path])) {
 			$size = strlen(self::$data[$path]);

tests/lib/share20/managertest.php

Unused Use Statements -1 removed lines

@@ -27,7 +27,6 @@
 use OCP\IUser;
 use OCP\ILogger;
 use OCP\Files\Folder;
-
 use OC\Share20\Exception\ShareNotFound;
 
 /**

build/integration/features/bootstrap/BasicStructure.php

Doc Comments +4 added lines, -1 removed lines

@@ -93,7 +93,6 @@ 
 
 	/**
 	 * @When /^sending "([^"]*)" to "([^"]*)" with$/
-	 * @param \Behat\Gherkin\Node\TableNode|null $formData
 	 */
 	public function sendingToWith($verb, $url, $body) {
 		$fullUrl = $this->baseUrl . "v{$this->apiVersion}.php" . $url;
@@ -136,6 +135,10 @@ 
 		PHPUnit_Framework_Assert::assertEquals($statusCode, $this->response->getStatusCode());
 	}
 
+	/**
+	 * @param string $path
+	 * @param string $filename
+	 */
 	public static function removeFile($path, $filename){
 		if (file_exists("$path" . "$filename")) {
 			unlink("$path" . "$filename");

Unused Use Statements -2 removed lines

@@ -1,7 +1,5 @@
 <?php
 
-use Behat\Behat\Context\Context;
-use Behat\Behat\Context\SnippetAcceptingContext;
 use GuzzleHttp\Client;
 use GuzzleHttp\Message\ResponseInterface;