owncloud / core

apps/dav/lib/Upload/ChunkingPluginZsync.php

Doc Comments +1 added lines

@@ -110,6 +110,7 @@
 	 *
 	 * @param string &$zsyncMetadata actual metadata
 	 * @param string $destination destination path
+	 * @param string|null $zsyncMetadata
 	 */
 	private function postMoveZsync(&$zsyncMetadata, $destination) {
 		if (!$zsyncMetadata)

lib/private/User/Manager.php

Doc Comments +3 added lines

@@ -432,6 +432,9 @@
 		}, $accounts);
 	}
 
+	/**
+	 * @param string $backendClass
+	 */
 	public function getBackend($backendClass) {
 		if (isset($this->backends[$backendClass])) {
 			return $this->backends[$backendClass];

Unused Use Statements -3 removed lines

@@ -41,9 +41,6 @@
 use OCP\IUser;
 use OCP\IUserManager;
 use OCP\IConfig;
-use OCP\User\IProvidesExtendedSearchBackend;
-use OCP\User\IProvidesEMailBackend;
-use OCP\User\IProvidesQuotaBackend;
 use OCP\UserInterface;
 use OCP\Util\UserSearch;
 use Symfony\Component\EventDispatcher\GenericEvent;

lib/private/User/User.php

Doc Comments +5 added lines, -1 removed lines

@@ -78,7 +78,7 @@ 
 	 *
 	 * @param Account $account
 	 * @param AccountMapper $mapper
-	 * @param null $emitter
+	 * @param Manager $emitter
 	 * @param IConfig|null $config
 	 * @param null $urlGenerator
 	 * @param EventDispatcher|null $eventDispatcher
@@ -452,6 +452,10 @@ 
 		return $url;
 	}
 
+	/**
+	 * @param string $feature
+	 * @param string $value
+	 */
 	public function triggerChange($feature, $value = null) {
 		if ($this->emitter && in_array($feature, $this->account->getUpdatedFields())) {
 			$this->emitter->emit('\OC\User', 'changeUser', [$this, $feature, $value]);

Unused Use Statements -1 removed lines

@@ -43,7 +43,6 @@
 use OCP\IUserBackend;
 use OCP\IUserSession;
 use OCP\User\IChangePasswordBackend;
-use OCP\UserInterface;
 use Symfony\Component\EventDispatcher\EventDispatcher;
 use Symfony\Component\EventDispatcher\GenericEvent;
 

lib/private/Mail/Message.php

Doc Comments +1 added lines, -1 removed lines

@@ -109,7 +109,7 @@
 	/**
 	 * Returns the Reply-To address of this message
 	 *
-	 * @return array
+	 * @return string
 	 */
 	public function getReplyTo() {
 		return $this->swiftMessage->getReplyTo();

lib/private/App/AppManager.php

Doc Comments +7 added lines, -4 removed lines

@@ -122,7 +122,7 @@ 
 	/**
 	 * List all installed apps
 	 *
-	 * @return string[]
+	 * @return integer[]
 	 */
 	public function getInstalledApps() {
 		return array_keys($this->getInstalledAppsValues());
@@ -231,7 +231,7 @@ 
 	/**
 	 * Do not allow more than one active app-theme
 	 *
-	 * @param $appId
+	 * @param string $appId
 	 * @throws AppManagerException
 	 */
 	protected function canEnableTheme($appId) {
@@ -390,6 +390,9 @@ 
 		return in_array($appId, $this->shippedApps);
 	}
 
+	/**
+	 * @param string $appId
+	 */
 	private function isAlwaysEnabled($appId) {
 		$alwaysEnabled = $this->getAlwaysEnabledApps();
 		return in_array($appId, $alwaysEnabled);
@@ -418,7 +421,7 @@ 
 	/**
 	 * @param string $package package path
 	 * @param bool $skipMigrations whether to skip migrations, which would only install the code
-	 * @return string|false app id or false in case of error
+	 * @return integer app id or false in case of error
 	 * @since 10.0
 	 */
 	public function installApp($package, $skipMigrations = false) {
@@ -431,7 +434,7 @@ 
 
 	/**
 	 * @param string $package
-	 * @return mixed
+	 * @return boolean
 	 * @since 10.0
 	 */
 	public function updateApp($package) {

lib/private/Repair/RepairMismatchFileCachePath.php

Doc Comments +14 added lines, -1 removed lines

@@ -95,7 +95,7 @@ 
 	 * @param string $wrongPath wrong path of the entry to fix
 	 * @param int $correctStorageNumericId numeric idea of the correct storage
 	 * @param string $correctPath value to which to set the path of the entry 
-	 * @return bool true for success
+	 * @return boolean|null true for success
 	 */
 	private function fixEntryPath(IOutput $out, $fileId, $wrongPath, $correctStorageNumericId, $correctPath) {
 		// delete target if exists
@@ -125,6 +125,9 @@ 
 		$out->advance(1, $text);
 	}
 
+	/**
+	 * @param \OCP\DB\QueryBuilder\IQueryBuilder $qb
+	 */
 	private function addQueryConditionsParentIdWrongPath($qb) {
 		// thanks, VicDeo!
 		if ($this->connection->getDatabasePlatform() instanceof MySqlPlatform) {
@@ -164,6 +167,9 @@ 
 		}
 	}
 
+	/**
+	 * @param \OCP\DB\QueryBuilder\IQueryBuilder $qb
+	 */
 	private function addQueryConditionsNonExistingParentIdEntry($qb, $storageNumericId = null) {
 		// Subquery for parent existence
 		$qbe = $this->connection->getQueryBuilder();
@@ -193,6 +199,9 @@ 
 		}
 	}
 
+	/**
+	 * @param integer $storageNumericId
+	 */
 	private function countResultsToProcessParentIdWrongPath($storageNumericId = null) {
 		$qb = $this->connection->getQueryBuilder();
 		$qb->select($qb->createFunction('COUNT(*)'));
@@ -203,6 +212,9 @@ 
 		return $count;
 	}
 
+	/**
+	 * @param integer $storageNumericId
+	 */
 	private function countResultsToProcessNonExistingParentIdEntry($storageNumericId = null) {
 		$qb = $this->connection->getQueryBuilder();
 		$qb->select($qb->createFunction('COUNT(*)'));
@@ -353,6 +365,7 @@ 
 	 *
 	 * @param int $storageId storage id
 	 * @param string $path path for which to create the parent entry
+	 * @param integer $reuseFileId
 	 * @return int file id of the newly created parent
 	 */
 	private function getOrCreateEntry($storageId, $path, $reuseFileId = null) {

apps/dav/lib/Server.php

Doc Comments +1 added lines, -1 removed lines

@@ -278,7 +278,7 @@
 	}
 
 	/**
-	 * @param string[] $subTree
+	 * @param string[] $subTrees
 	 * @return bool
 	 */
 	private function isRequestForSubtree(array $subTrees) {

apps/files/lib/Command/Scan.php

Doc Comments +5 added lines

@@ -311,6 +311,11 @@
 		}
 	}
 
+	/**
+	 * @param InputInterface $input
+	 * @param OutputInterface $output
+	 * @param boolean $shouldRepairStoragesIndividually
+	 */
 	protected function processUserChunks($input, $output, $users, $inputPath, $shouldRepairStoragesIndividually, $group = null) {
 		# no messaging level option means: no full printout but statistics
 		# $quiet   means no print at all

apps/files_external/lib/Lib/Storage/SMB.php

Doc Comments +7 added lines, -1 removed lines

@@ -284,6 +284,9 @@ 
 		return $this->leave(__FUNCTION__, $result);
 	}
 
+	/**
+	 * @param string $path
+	 */
 	private function removeFromCache($path) {
 		$path = trim($path, '/');
 		// TODO The CappedCache does not really clear by prefix. It just clears all.
@@ -673,7 +676,7 @@ 
 	 * if smb.logging.enable is set to true in the config will log a leave line
 	 * with the given function, the return value or the exception
 	 *
-	 * @param $function
+	 * @param string $function
 	 * @param mixed $result an exception will be logged and then returned
 	 * @return mixed
 	 */
@@ -700,6 +703,9 @@ 
 		return $result;
 	}
 
+	/**
+	 * @param string $function
+	 */
 	private function swallow($function, \Exception $exception) {
 		if (\OC::$server->getConfig()->getSystemValue('smb.logging.enable', false) === true) {
 			Util::writeLog('smb', "$function swallowing ".get_class($exception)