Completed
Pull Request — stable8.2 (#29162)
by Tom
11:55
created
core/lostpassword/controller/lostcontroller.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -131,7 +131,7 @@
 block discarded – undo
131 131
 	}
132 132
 
133 133
 	/**
134
-	 * @param $message
134
+	 * @param string $message
135 135
 	 * @param array $additional
136 136
 	 * @return array
137 137
 	 */
Please login to merge, or discard this patch.
lib/private/activitymanager.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
 	/**
330 330
 	 * @param string $app
331 331
 	 * @param string $text
332
-	 * @param array $params
332
+	 * @param string $params
333 333
 	 * @param boolean $stripPath
334 334
 	 * @param boolean $highlightParams
335 335
 	 * @param string $languageCode
@@ -427,7 +427,7 @@  discard block
 block discarded – undo
427 427
 	}
428 428
 
429 429
 	/**
430
-	 * @param array $types
430
+	 * @param string[] $types
431 431
 	 * @param string $filter
432 432
 	 * @return array
433 433
 	 */
Please login to merge, or discard this patch.
lib/private/allconfig.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 	 * Looks up a system wide defined value
112 112
 	 *
113 113
 	 * @param string $key the key of the value, under which it was saved
114
-	 * @param mixed $default the default value to be returned if the value isn't set
114
+	 * @param string $default the default value to be returned if the value isn't set
115 115
 	 * @return mixed the value or $default
116 116
 	 */
117 117
 	public function getSystemValue($key, $default = '') {
@@ -264,7 +264,7 @@  discard block
 block discarded – undo
264 264
 	 * @param string $userId the userId of the user that we want to store the value under
265 265
 	 * @param string $appName the appName that we stored the value under
266 266
 	 * @param string $key the key under which the value is being stored
267
-	 * @param mixed $default the default value to be returned if the value isn't set
267
+	 * @param null|string $default the default value to be returned if the value isn't set
268 268
 	 * @return string
269 269
 	 */
270 270
 	public function getUserValue($userId, $appName, $key, $default = '') {
@@ -381,7 +381,7 @@  discard block
 block discarded – undo
381 381
 	 *
382 382
 	 * @param string $appName app to get the value for
383 383
 	 * @param string $key the key to get the value for
384
-	 * @param array $userIds the user IDs to fetch the values for
384
+	 * @param string[] $userIds the user IDs to fetch the values for
385 385
 	 * @return array Mapped values: userId => value
386 386
 	 */
387 387
 	public function getUserValueForUsers($appName, $key, $userIds) {
Please login to merge, or discard this patch.
lib/private/app/codechecker/nodevisitor.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -296,6 +296,9 @@
 block discarded – undo
296 296
 		}
297 297
 	}
298 298
 
299
+	/**
300
+	 * @param string $name
301
+	 */
299 302
 	private function buildReason($name, $errorCode) {
300 303
 		if (isset($this->errorMessages[$errorCode])) {
301 304
 			$desc = $this->list->getDescription($errorCode, $name);
Please login to merge, or discard this patch.
lib/private/app/dependencyanalyzer.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@
 block discarded – undo
73 73
 	 * 5.2.6.5 and 5.1 will be turned into 5.2 and 5.1
74 74
 	 * @param string $first
75 75
 	 * @param string $second
76
-	 * @return array first element is the first version, second element is the
76
+	 * @return string[] first element is the first version, second element is the
77 77
 	 * second version
78 78
 	 */
79 79
 	private function normalizeVersions($first, $second) {
Please login to merge, or discard this patch.
lib/private/app/platformrepository.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -206,6 +206,9 @@
 block discarded – undo
206 206
 		throw new \UnexpectedValueException('Invalid version string "' . $version . '"' . $extraMessage);
207 207
 	}
208 208
 
209
+	/**
210
+	 * @param string $stability
211
+	 */
209 212
 	private function expandStability($stability) {
210 213
 		$stability = strtolower($stability);
211 214
 		switch ($stability) {
Please login to merge, or discard this patch.
lib/private/appframework/utility/simplecontainer.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -113,7 +113,7 @@
 block discarded – undo
113 113
 
114 114
 	/**
115 115
 	 * @param string $name
116
-	 * @param mixed $value
116
+	 * @param string $value
117 117
 	 */
118 118
 	public function registerParameter($name, $value) {
119 119
 		$this[$name] = $value;
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -29,9 +29,7 @@
 block discarded – undo
29 29
 use ReflectionClass;
30 30
 use ReflectionException;
31 31
 use Closure;
32
-
33 32
 use Pimple\Container;
34
-
35 33
 use OCP\AppFramework\QueryException;
36 34
 use OCP\IContainer;
37 35
 
Please login to merge, or discard this patch.
lib/private/db/connection.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
 	 * If an SQLLogger is configured, the execution is logged.
168 168
 	 *
169 169
 	 * @param string                                      $query  The SQL query to execute.
170
-	 * @param array                                       $params The parameters to bind to the query, if any.
170
+	 * @param string[]                                       $params The parameters to bind to the query, if any.
171 171
 	 * @param array                                       $types  The types the previous parameters are in.
172 172
 	 * @param \Doctrine\DBAL\Cache\QueryCacheProfile|null $qcp    The query cache profile, optional.
173 173
 	 *
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
 	 * columns or sequences.
213 213
 	 *
214 214
 	 * @param string $seqName Name of the sequence object from which the ID should be returned.
215
-	 * @return string A string representation of the last inserted ID.
215
+	 * @return integer A string representation of the last inserted ID.
216 216
 	 */
217 217
 	public function lastInsertId($seqName = null)
218 218
 	{
Please login to merge, or discard this patch.
lib/private/db/migrator.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
 	protected $config;
53 53
 
54 54
 	/**
55
-	 * @param \Doctrine\DBAL\Connection $connection
55
+	 * @param Connection $connection
56 56
 	 * @param ISecureRandom $random
57 57
 	 * @param IConfig $config
58 58
 	 */
Please login to merge, or discard this patch.