owncloud / core

apps/dav/appinfo/Migrations/Version20170202213905.php

Doc Comments +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
 
 	/**
 	 * @param IDBConnection $connection
-	 * @return array
+	 * @return string[]
 	 */
 	public function sql(IDBConnection $connection) {
 		$qb = $connection->getQueryBuilder();

lib/public/AppFramework/Db/Mapper.php

Doc Comments +1 added lines

@@ -308,6 +308,7 @@
 	 * @param array $params the parameters of the sql query
 	 * @param int $limit the maximum number of rows
 	 * @param int $offset from which row we want to start
+	 * @param string $msg
 	 * @return string formatted error message string
 	 * @since 9.1.0
 	 */

lib/base.php

Doc Comments +1 added lines, -1 removed lines

@@ -329,7 +329,7 @@
 	/**
 	 * Checks if the version requires an update and shows
 	 * @param bool $showTemplate Whether an update screen should get shown
-	 * @return bool
+	 * @return null|boolean
 	 */
 	public static function checkUpgrade($showTemplate = true) {
 		if (\OCP\Util::needUpgrade()) {

lib/private/User/Database.php

Doc Comments +1 added lines, -1 removed lines

@@ -308,7 +308,7 @@
 	/**
 	 * counts the users in the database
 	 *
-	 * @return int|bool
+	 * @return integer
 	 */
 	public function countUsers() {
 		$query = \OC_DB::prepare('SELECT COUNT(*) FROM `*PREFIX*users`');

Unused Use Statements -1 removed lines

@@ -53,7 +53,6 @@
 use OC\Cache\CappedMemoryCache;
 use OCP\IUserBackend;
 use OCP\User\IProvidesDisplayNameBackend;
-use OCP\User\IProvidesEMailBackend;
 use OCP\User\IProvidesHomeBackend;
 use OCP\Util;
 

lib/private/Encryption/Util.php

Unused Use Statements -1 removed lines

@@ -31,7 +31,6 @@
 use OC\Files\Filesystem;
 use OC\Files\View;
 use OCP\Encryption\IEncryptionModule;
-use OCP\Files\Storage;
 use OCP\IConfig;
 use OCP\IUser;
 

apps/dav/lib/Connector/Sabre/SharesPlugin.php

Doc Comments -1 removed lines

@@ -68,7 +68,6 @@
 	/**
 	 * @param \Sabre\DAV\Tree $tree tree
 	 * @param IUserSession $userSession user session
-	 * @param \OCP\Files\Folder $userFolder user home folder
 	 * @param \OCP\Share\IManager $shareManager share manager
 	 */
 	public function __construct(

apps/dav/lib/Connector/Sabre/FilesReportPlugin.php

Doc Comments +3 added lines, -2 removed lines

@@ -152,7 +152,7 @@ 
 	 * This will be used in the {DAV:}supported-report-set property.
 	 *
 	 * @param string $uri
-	 * @return array
+	 * @return string[]
 	 */
 	public function getSupportedReportSet($uri) {
 		return [self::REPORT_NAME];
@@ -164,7 +164,7 @@ 
 	 * @param string $reportName
 	 * @param mixed $report
 	 * @param string $uri
-	 * @return bool
+	 * @return null|false
 	 * @throws BadRequest
 	 * @throws PreconditionFailed
 	 * @internal param $ [] $report
@@ -350,6 +350,7 @@ 
 	 * with a leading slash but no trailing slash
 	 * @param string[] $requestedProps requested properties
 	 * @param Node[] nodes nodes for which to fetch and prepare responses
+	 * @param Node[] $nodes
 	 * @return Response[]
 	 */
 	public function prepareResponses($filesUri, $requestedProps, $nodes) {

apps/dav/lib/Connector/LegacyDAVACL.php

Doc Comments +4 added lines

@@ -49,6 +49,10 @@
 		);
 	}
 
+	/**
+	 * @param string $principal
+	 * @param boolean $toV2
+	 */
 	private function convertPrincipal($principal, $toV2) {
 		list(, $name) = URLUtil::splitPath($principal);
 		if ($toV2) {

lib/private/User/AccountMapper.php

Doc Comments +13 added lines, -2 removed lines

@@ -42,7 +42,7 @@ 
 
 	/**
 	 * Delegate to term mapper to avoid needing to inject term mapper
-	 * @param $account_id
+	 * @param integer $account_id
 	 * @param array $terms
 	 */
 	public function setTermsForAccount($account_id, array $terms) {
@@ -51,7 +51,7 @@ 
 
 	/**
 	 * Delegate to term mapper to avoid needing to inject term mapper
-	 * @param $account_id
+	 * @param integer $account_id
 	 * @return AccountTerm[] $terms
 	 */
 	public function findByAccountId($account_id) {
@@ -164,6 +164,9 @@ 
 		return $this->findEntities($qb->getSQL(), $qb->getParameters(), $limit, $offset);
 	}
 
+	/**
+	 * @param boolean $hasLoggedIn
+	 */
 	public function getUserCountPerBackend($hasLoggedIn) {
 		$qb = $this->db->getQueryBuilder();
 		$qb->select(['backend', $qb->createFunction('count(*) as `count`')])
@@ -186,6 +189,9 @@ 
 		return $return;
 	}
 
+	/**
+	 * @param boolean $hasLoggedIn
+	 */
 	public function getUserCount($hasLoggedIn) {
 		$qb = $this->db->getQueryBuilder();
 		$qb->select([$qb->createFunction('count(*) as `count`')])
@@ -202,6 +208,11 @@ 
 		return (int) $data['count'];
 	}
 
+	/**
+	 * @param \Closure $callback
+	 * @param string $search
+	 * @param boolean $onlySeen
+	 */
 	public function callForAllUsers($callback, $search, $onlySeen) {
 		$qb = $this->db->getQueryBuilder();
 		$qb->select(['*'])