Completed
Push — stable8.1 ( 954a0a...5df937 )
by Thomas
67:11
created
apps/files_external/service/storagesservice.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -394,7 +394,7 @@
 block discarded – undo
394 394
 	/**
395 395
 	 * Add new storage to the configuration
396 396
 	 *
397
-	 * @param array $newStorage storage attributes
397
+	 * @param StorageConfig $newStorage storage attributes
398 398
 	 *
399 399
 	 * @return StorageConfig storage config, with added id
400 400
 	 */
Please login to merge, or discard this patch.
apps/files_external/tests/amazons3migration.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -123,6 +123,9 @@
 block discarded – undo
123 123
 		return $storages;
124 124
 	}
125 125
 
126
+	/**
127
+	 * @param string $id
128
+	 */
126 129
 	public function deleteStorage($id) {
127 130
 		$stmt = \OC::$server->getDatabaseConnection()->prepare(
128 131
 			'DELETE FROM `*PREFIX*storages` WHERE `id` = ?'
Please login to merge, or discard this patch.
apps/files_sharing/appinfo/application.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,6 @@
 block discarded – undo
25 25
 
26 26
 namespace OCA\Files_Sharing\AppInfo;
27 27
 
28
-use OCA\Files_Sharing\Helper;
29 28
 use OCA\Files_Sharing\MountProvider;
30 29
 use OCA\Files_Sharing\Propagation\PropagationManager;
31 30
 use OCA\Files_Sharing\Propagation\GroupPropagationManager;
Please login to merge, or discard this patch.
apps/files_sharing/lib/cache.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -98,7 +98,7 @@
 block discarded – undo
98 98
 	/**
99 99
 	 * get the stored metadata of a file or folder
100 100
 	 *
101
-	 * @param string|int $file
101
+	 * @param string $file
102 102
 	 * @return array|false
103 103
 	 */
104 104
 	public function get($file) {
Please login to merge, or discard this patch.
apps/files_sharing/lib/controllers/externalsharescontroller.php 2 patches
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -45,7 +45,6 @@  discard block
 block discarded – undo
45 45
 	/**
46 46
 	 * @param string $appName
47 47
 	 * @param IRequest $request
48
-	 * @param bool $incomingShareEnabled
49 48
 	 * @param \OCA\Files_Sharing\External\Manager $externalManager
50 49
 	 * @param IClientService $clientService
51 50
 	 */
@@ -84,7 +83,7 @@  discard block
 block discarded – undo
84 83
 	 * @NoAdminRequired
85 84
 	 * @NoOutgoingFederatedSharingRequired
86 85
 	 *
87
-	 * @param $id
86
+	 * @param integer $id
88 87
 	 * @return JSONResponse
89 88
 	 */
90 89
 	public function destroy($id) {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -23,8 +23,6 @@
 block discarded – undo
23 23
 
24 24
 namespace OCA\Files_Sharing\Controllers;
25 25
 
26
-use OC;
27
-use OCP;
28 26
 use OCP\AppFramework\Controller;
29 27
 use OCP\IRequest;
30 28
 use OCP\AppFramework\Http\JSONResponse;
Please login to merge, or discard this patch.
apps/files_sharing/lib/controllers/sharecontroller.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -124,7 +124,7 @@
 block discarded – undo
124 124
 	 * @UseSession
125 125
 	 *
126 126
 	 * Authenticates against password-protected shares
127
-	 * @param $token
127
+	 * @param string $token
128 128
 	 * @param string $password
129 129
 	 * @return RedirectResponse|TemplateResponse
130 130
 	 */
Please login to merge, or discard this patch.
apps/files_sharing/lib/middleware/sharingcheckmiddleware.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,6 @@
 block discarded – undo
27 27
 use OCP\App\IAppManager;
28 28
 use OCP\AppFramework\Http\NotFoundResponse;
29 29
 use OCP\AppFramework\Middleware;
30
-use OCP\AppFramework\Http\TemplateResponse;
31 30
 use OCP\Files\NotFoundException;
32 31
 use OCP\IConfig;
33 32
 use OCP\AppFramework\Utility\IControllerMethodReflector;
Please login to merge, or discard this patch.
apps/files_sharing/lib/sharedmount.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -53,6 +53,11 @@
 block discarded – undo
53 53
 	 */
54 54
 	private $user;
55 55
 
56
+	/**
57
+	 * @param string $storage
58
+	 * @param string $mountpoint
59
+	 * @param \OCP\Files\Storage\IStorageFactory $loader
60
+	 */
56 61
 	public function __construct($storage, $mountpoint, $arguments = null, $loader = null) {
57 62
 		// first update the mount point before creating the parent
58 63
 		$this->ownerPropagator = $arguments['propagator'];
Please login to merge, or discard this patch.
apps/files_sharing/lib/sharedstorage.php 2 patches
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -32,8 +32,6 @@
 block discarded – undo
32 32
 
33 33
 use OC\Files\Filesystem;
34 34
 use OCA\Files_Sharing\ISharedStorage;
35
-use OCA\Files_Sharing\Propagator;
36
-use OCA\Files_Sharing\SharedMount;
37 35
 use OCP\Lock\ILockingProvider;
38 36
 
39 37
 /**
Please login to merge, or discard this patch.
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -144,6 +144,9 @@
 block discarded – undo
144 144
 		return true;
145 145
 	}
146 146
 
147
+	/**
148
+	 * @param string $path
149
+	 */
147 150
 	public function url_stat($path) {
148 151
 		if (isset(self::$data[$path])) {
149 152
 			$size = strlen(self::$data[$path]);
Please login to merge, or discard this patch.