Completed
Pull Request — master (#28019)
by Tom
19:11 queued 06:14
created
core/Migrations/Version20170221114437.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -1,12 +1,10 @@
 block discarded – undo
1 1
 <?php
2 2
 namespace OC\Migrations;
3 3
 
4
-use OC\User\Account;
5 4
 use OC\User\AccountMapper;
6 5
 use OC\User\AccountTermMapper;
7 6
 use OC\User\Database;
8 7
 use OC\User\SyncService;
9
-use OCP\IConfig;
10 8
 use OCP\Migration\ISimpleMigration;
11 9
 use OCP\Migration\IOutput;
12 10
 
Please login to merge, or discard this patch.
lib/private/App/AppManager.php 1 patch
Doc Comments   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
 	/**
123 123
 	 * List all installed apps
124 124
 	 *
125
-	 * @return string[]
125
+	 * @return integer[]
126 126
 	 */
127 127
 	public function getInstalledApps() {
128 128
 		return array_keys($this->getInstalledAppsValues());
@@ -355,6 +355,9 @@  discard block
 block discarded – undo
355 355
 		return in_array($appId, $this->shippedApps);
356 356
 	}
357 357
 
358
+	/**
359
+	 * @param string $appId
360
+	 */
358 361
 	private function isAlwaysEnabled($appId) {
359 362
 		$alwaysEnabled = $this->getAlwaysEnabledApps();
360 363
 		return in_array($appId, $alwaysEnabled);
@@ -383,7 +386,7 @@  discard block
 block discarded – undo
383 386
 	/**
384 387
 	 * @param string $package package path
385 388
 	 * @param bool $skipMigrations whether to skip migrations, which would only install the code
386
-	 * @return string|false app id or false in case of error
389
+	 * @return integer app id or false in case of error
387 390
 	 * @since 10.0
388 391
 	 */
389 392
 	public function installApp($package, $skipMigrations = false) {
@@ -400,7 +403,7 @@  discard block
 block discarded – undo
400 403
 
401 404
 	/**
402 405
 	 * @param string $package
403
-	 * @return mixed
406
+	 * @return boolean
404 407
 	 * @since 10.0
405 408
 	 */
406 409
 	public function updateApp($package) {
Please login to merge, or discard this patch.
lib/private/User/AccountMapper.php 1 patch
Doc Comments   +13 added lines, -2 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
 
43 43
 	/**
44 44
 	 * Delegate to term mapper to avoid needing to inject term mapper
45
-	 * @param $account_id
45
+	 * @param integer $account_id
46 46
 	 * @param array $terms
47 47
 	 */
48 48
 	public function setTermsForAccount($account_id, array $terms) {
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 
52 52
 	/**
53 53
 	 * Delegate to term mapper to avoid needing to inject term mapper
54
-	 * @param $account_id
54
+	 * @param integer $account_id
55 55
 	 * @return AccountTerm[] $terms
56 56
 	 */
57 57
 	public function findByAccountId($account_id) {
@@ -164,6 +164,9 @@  discard block
 block discarded – undo
164 164
 		return $this->findEntities($qb->getSQL(), $qb->getParameters(), $limit, $offset);
165 165
 	}
166 166
 
167
+	/**
168
+	 * @param boolean $hasLoggedIn
169
+	 */
167 170
 	public function getUserCountPerBackend($hasLoggedIn) {
168 171
 		$qb = $this->db->getQueryBuilder();
169 172
 		$qb->select(['backend', $qb->createFunction('count(*) as `count`')])
@@ -186,6 +189,9 @@  discard block
 block discarded – undo
186 189
 		return $return;
187 190
 	}
188 191
 
192
+	/**
193
+	 * @param boolean $hasLoggedIn
194
+	 */
189 195
 	public function getUserCount($hasLoggedIn) {
190 196
 		$qb = $this->db->getQueryBuilder();
191 197
 		$qb->select([$qb->createFunction('count(*) as `count`')])
@@ -202,6 +208,11 @@  discard block
 block discarded – undo
202 208
 		return (int) $data['count'];
203 209
 	}
204 210
 
211
+	/**
212
+	 * @param \Closure $callback
213
+	 * @param string $search
214
+	 * @param boolean $onlySeen
215
+	 */
205 216
 	public function callForAllUsers($callback, $search, $onlySeen) {
206 217
 		$qb = $this->db->getQueryBuilder();
207 218
 		$qb->select(['*'])
Please login to merge, or discard this patch.
lib/private/DB/QueryBuilder/ExpressionBuilder/ExpressionBuilder.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -361,7 +361,7 @@  discard block
 block discarded – undo
361 361
 	 *
362 362
 	 * @param string $column
363 363
 	 * @param mixed $type One of IQueryBuilder::PARAM_*
364
-	 * @return string
364
+	 * @return QueryFunction
365 365
 	 */
366 366
 	public function castColumn($column, $type) {
367 367
 		return new QueryFunction(
@@ -372,7 +372,7 @@  discard block
 block discarded – undo
372 372
 	/**
373 373
 	 * Returns a query function to find the number of characters in a string column
374 374
 	 * @param string $column
375
-	 * @return string
375
+	 * @return QueryFunction
376 376
 	 */
377 377
 	public function length($column) {
378 378
 		$column = $this->helper->quoteColumnName($column);
Please login to merge, or discard this patch.