Completed
Pull Request — master (#22506)
by Robin
10:31
created
lib/private/group/dummy.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@
 block discarded – undo
106 106
 	 * Removes a user from a group
107 107
 	 * @param string $uid Name of the user to remove from group
108 108
 	 * @param string $gid Name of the group from which remove the user
109
-	 * @return bool
109
+	 * @return null|false
110 110
 	 *
111 111
 	 * removes the user from a group.
112 112
 	 */
Please login to merge, or discard this patch.
lib/private/group/manager.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -144,6 +144,9 @@
 block discarded – undo
144 144
 		return $this->getGroupObject($gid);
145 145
 	}
146 146
 
147
+	/**
148
+	 * @param string $gid
149
+	 */
147 150
 	protected function getGroupObject($gid) {
148 151
 		$backends = array();
149 152
 		foreach ($this->backends as $backend) {
Please login to merge, or discard this patch.
lib/private/helper.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -197,6 +197,9 @@  discard block
 block discarded – undo
197 197
 		return self::linkToRoute( 'core_ajax_preview', array('x' => 32, 'y' => 32, 'file' => $path ));
198 198
 	}
199 199
 
200
+	/**
201
+	 * @param string $path
202
+	 */
200 203
 	public static function publicPreviewIcon( $path, $token ) {
201 204
 		return self::linkToRoute( 'core_ajax_public_preview', array('x' => 32, 'y' => 32, 'file' => $path, 't' => $token));
202 205
 	}
@@ -827,7 +830,7 @@  discard block
 block discarded – undo
827 830
 	 *
828 831
 	 * @param string $path
829 832
 	 * @param \OCP\Files\FileInfo $rootInfo (optional)
830
-	 * @return array
833
+	 * @return string
831 834
 	 * @throws \OCP\Files\NotFoundException
832 835
 	 */
833 836
 	public static function getStorageInfo($path, $rootInfo = null) {
Please login to merge, or discard this patch.
lib/private/memcache/factory.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -172,7 +172,7 @@
 block discarded – undo
172 172
 	/**
173 173
 	 * @see \OC\Memcache\Factory::createLocal()
174 174
 	 * @param string $prefix
175
-	 * @return \OC\Memcache\Cache|null
175
+	 * @return Cache
176 176
 	 */
177 177
 	public function createLowLatency($prefix = '') {
178 178
 		return $this->createLocal($prefix);
Please login to merge, or discard this patch.
lib/private/preview.php 1 patch
Doc Comments   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
 	/**
202 202
 	 * returns the max width set in ownCloud's config
203 203
 	 *
204
-	 * @return string
204
+	 * @return integer
205 205
 	 */
206 206
 	public function getConfigMaxX() {
207 207
 		return $this->configMaxWidth;
@@ -210,7 +210,7 @@  discard block
 block discarded – undo
210 210
 	/**
211 211
 	 * returns the max height set in ownCloud's config
212 212
 	 *
213
-	 * @return string
213
+	 * @return integer
214 214
 	 */
215 215
 	public function getConfigMaxY() {
216 216
 		return $this->configMaxHeight;
@@ -545,7 +545,7 @@  discard block
 block discarded – undo
545 545
 	/**
546 546
 	 * Determines the size of the preview we should be looking for in the cache
547 547
 	 *
548
-	 * @return int[]
548
+	 * @return integer[]
549 549
 	 */
550 550
 	private function simulatePreviewDimensions() {
551 551
 		$askedWidth = $this->getMaxX();
@@ -569,7 +569,7 @@  discard block
 block discarded – undo
569 569
 	 *
570 570
 	 * @param int $originalWidth
571 571
 	 * @param int $originalHeight
572
-	 * @return \int[]
572
+	 * @return integer[]
573 573
 	 */
574 574
 	private function applyAspectRatio($askedWidth, $askedHeight, $originalWidth = 0, $originalHeight = 0) {
575 575
 		if(!$originalWidth){
@@ -601,7 +601,7 @@  discard block
 block discarded – undo
601 601
 	 * @param int $askedHeight
602 602
 	 * @param int $previewWidth
603 603
 	 * @param int $previewHeight
604
-	 * @return \int[]
604
+	 * @return integer[]
605 605
 	 */
606 606
 	private function applyCover($askedWidth, $askedHeight, $previewWidth, $previewHeight) {
607 607
 		$originalRatio = $previewWidth / $previewHeight;
@@ -627,7 +627,7 @@  discard block
 block discarded – undo
627 627
 	 * @param int $askedWidth
628 628
 	 * @param int $askedHeight
629 629
 	 *
630
-	 * @return \int[]
630
+	 * @return integer[]
631 631
 	 */
632 632
 	private function fixSize($askedWidth, $askedHeight) {
633 633
 		if ($this->scalingUp) {
@@ -920,9 +920,9 @@  discard block
 block discarded – undo
920 920
 	 * @param int $askedWidth
921 921
 	 * @param int $askedHeight
922 922
 	 * @param int $previewWidth
923
-	 * @param null $previewHeight
923
+	 * @param integer $previewHeight
924 924
 	 *
925
-	 * @return int[]
925
+	 * @return double[]
926 926
 	 */
927 927
 	private function scale($image, $askedWidth, $askedHeight, $previewWidth, $previewHeight) {
928 928
 		$scalingUp = $this->getScalingUp();
@@ -970,7 +970,7 @@  discard block
 block discarded – undo
970 970
 	 * @param int $askedWidth
971 971
 	 * @param int $askedHeight
972 972
 	 * @param int $previewWidth
973
-	 * @param null $previewHeight
973
+	 * @param double $previewHeight
974 974
 	 */
975 975
 	private function crop($image, $askedWidth, $askedHeight, $previewWidth, $previewHeight = null) {
976 976
 		$cropX = floor(abs($askedWidth - $previewWidth) * 0.5);
@@ -989,7 +989,7 @@  discard block
 block discarded – undo
989 989
 	 * @param int $askedWidth
990 990
 	 * @param int $askedHeight
991 991
 	 * @param int $previewWidth
992
-	 * @param null $previewHeight
992
+	 * @param double $previewHeight
993 993
 	 */
994 994
 	private function cropAndFill($image, $askedWidth, $askedHeight, $previewWidth, $previewHeight) {
995 995
 		if ($previewWidth > $askedWidth) {
@@ -1217,7 +1217,7 @@  discard block
 block discarded – undo
1217 1217
 	 * @param int $maxDim
1218 1218
 	 * @param string $dimName
1219 1219
 	 *
1220
-	 * @return mixed
1220
+	 * @return integer
1221 1221
 	 */
1222 1222
 	private function limitMaxDim($dim, $maxDim, $dimName) {
1223 1223
 		if (!is_null($maxDim)) {
Please login to merge, or discard this patch.
lib/private/repair.php 1 patch
Doc Comments   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
 	 * Returns expensive repair steps to be run on the
124 124
 	 * command line with a special option.
125 125
 	 *
126
-	 * @return array of RepairStep instances
126
+	 * @return OldGroupMembershipShares[] of RepairStep instances
127 127
 	 */
128 128
 	public static function getExpensiveRepairSteps() {
129 129
 		return [
@@ -161,6 +161,8 @@  discard block
 block discarded – undo
161 161
 	 * {@inheritDoc}
162 162
 	 *
163 163
 	 * Re-declared as public to allow invocation from within the closure above in php 5.3
164
+	 * @param string $scope
165
+	 * @param string $method
164 166
 	 */
165 167
 	public function emit($scope, $method, array $arguments = array()) {
166 168
 		parent::emit($scope, $method, $arguments);
Please login to merge, or discard this patch.
lib/private/server.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -856,7 +856,7 @@
 block discarded – undo
856 856
 	 * Get the certificate manager for the user
857 857
 	 *
858 858
 	 * @param string $userId (optional) if not specified the current loggedin user is used
859
-	 * @return \OCP\ICertificateManager | null if $uid is null and no user is logged in
859
+	 * @return null|CertificateManager | null if $uid is null and no user is logged in
860 860
 	 */
861 861
 	public function getCertificateManager($userId = null) {
862 862
 		if (is_null($userId)) {
Please login to merge, or discard this patch.
lib/private/session/cryptosessiondata.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -153,7 +153,7 @@
 block discarded – undo
153 153
 
154 154
 	/**
155 155
 	 * @param mixed $offset
156
-	 * @return mixed
156
+	 * @return string|null
157 157
 	 */
158 158
 	public function offsetGet($offset) {
159 159
 		return $this->get($offset);
Please login to merge, or discard this patch.
lib/private/tags.php 1 patch
Doc Comments   +10 added lines, -2 removed lines patch added patch discarded remove patch
@@ -741,11 +741,19 @@  discard block
 block discarded – undo
741 741
 	}
742 742
 
743 743
 	// case-insensitive array_search
744
+
745
+	/**
746
+	 * @param string $needle
747
+	 */
744 748
 	protected function array_searchi($needle, $haystack, $mem='getName') {
745 749
 		if(!is_array($haystack)) {
746 750
 			return false;
747 751
 		}
748 752
 		return array_search(strtolower($needle), array_map(
753
+
754
+			/**
755
+			 * @param string $tag
756
+			 */
749 757
 			function($tag) use($mem) {
750 758
 				return strtolower(call_user_func(array($tag, $mem)));
751 759
 			}, $haystack)
@@ -770,7 +778,7 @@  discard block
 block discarded – undo
770 778
 	* Get a tag by its name.
771 779
 	*
772 780
 	* @param string $name The tag name.
773
-	* @return integer|bool The tag object's offset within the $this->tags
781
+	* @return \OCP\AppFramework\Db\Entity The tag object's offset within the $this->tags
774 782
 	*                      array or false if it doesn't exist.
775 783
 	*/
776 784
 	private function getTagByName($name) {
@@ -781,7 +789,7 @@  discard block
 block discarded – undo
781 789
 	* Get a tag by its ID.
782 790
 	*
783 791
 	* @param string $id The tag ID to look for.
784
-	* @return integer|bool The tag object's offset within the $this->tags
792
+	* @return \OCP\AppFramework\Db\Entity The tag object's offset within the $this->tags
785 793
 	*                      array or false if it doesn't exist.
786 794
 	*/
787 795
 	private function getTagById($id) {
Please login to merge, or discard this patch.