Completed
Pull Request — master (#29838)
by Sergio
28:34 queued 14:04
created
lib/private/legacy/response.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
 	 * @param string $domain
276 276
 	 * @param Sabre\HTTP\ResponseInterface $response
277 277
 	 * @param \OCP\IConfig $config
278
-	 * @param Array $headers
278
+	 * @param string[] $headers
279 279
 	 *
280 280
 	 * Format of $headers:
281 281
 	 * Array [
@@ -314,7 +314,7 @@  discard block
 block discarded – undo
314 314
 	 * This function adds the CORS headers for all domains
315 315
 	 *
316 316
 	 * @param Sabre\HTTP\ResponseInterface $response
317
-	 * @param Array $headers
317
+	 * @param string[] $headers
318 318
 	 *
319 319
 	 * Format of $headers:
320 320
 	 * Array [
Please login to merge, or discard this patch.
lib/private/App/AppManager.php 1 patch
Doc Comments   +7 added lines, -4 removed lines patch added patch discarded remove patch
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
 	/**
123 123
 	 * List all installed apps
124 124
 	 *
125
-	 * @return string[]
125
+	 * @return integer[]
126 126
 	 */
127 127
 	public function getInstalledApps() {
128 128
 		return array_keys($this->getInstalledAppsValues());
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
 	/**
232 232
 	 * Do not allow more than one active app-theme
233 233
 	 *
234
-	 * @param $appId
234
+	 * @param string $appId
235 235
 	 * @throws AppManagerException
236 236
 	 */
237 237
 	protected function canEnableTheme($appId) {
@@ -390,6 +390,9 @@  discard block
 block discarded – undo
390 390
 		return in_array($appId, $this->shippedApps);
391 391
 	}
392 392
 
393
+	/**
394
+	 * @param string $appId
395
+	 */
393 396
 	private function isAlwaysEnabled($appId) {
394 397
 		$alwaysEnabled = $this->getAlwaysEnabledApps();
395 398
 		return in_array($appId, $alwaysEnabled);
@@ -418,7 +421,7 @@  discard block
 block discarded – undo
418 421
 	/**
419 422
 	 * @param string $package package path
420 423
 	 * @param bool $skipMigrations whether to skip migrations, which would only install the code
421
-	 * @return string|false app id or false in case of error
424
+	 * @return integer app id or false in case of error
422 425
 	 * @since 10.0
423 426
 	 */
424 427
 	public function installApp($package, $skipMigrations = false) {
@@ -431,7 +434,7 @@  discard block
 block discarded – undo
431 434
 
432 435
 	/**
433 436
 	 * @param string $package
434
-	 * @return mixed
437
+	 * @return boolean
435 438
 	 * @since 10.0
436 439
 	 */
437 440
 	public function updateApp($package) {
Please login to merge, or discard this patch.
lib/private/Repair/RepairMismatchFileCachePath.php 1 patch
Doc Comments   +14 added lines, -1 removed lines patch added patch discarded remove patch
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
 	 * @param string $wrongPath wrong path of the entry to fix
96 96
 	 * @param int $correctStorageNumericId numeric idea of the correct storage
97 97
 	 * @param string $correctPath value to which to set the path of the entry 
98
-	 * @return bool true for success
98
+	 * @return boolean|null true for success
99 99
 	 */
100 100
 	private function fixEntryPath(IOutput $out, $fileId, $wrongPath, $correctStorageNumericId, $correctPath) {
101 101
 		// delete target if exists
@@ -125,6 +125,9 @@  discard block
 block discarded – undo
125 125
 		$out->advance(1, $text);
126 126
 	}
127 127
 
128
+	/**
129
+	 * @param \OCP\DB\QueryBuilder\IQueryBuilder $qb
130
+	 */
128 131
 	private function addQueryConditionsParentIdWrongPath($qb) {
129 132
 		// thanks, VicDeo!
130 133
 		if ($this->connection->getDatabasePlatform() instanceof MySqlPlatform) {
@@ -164,6 +167,9 @@  discard block
 block discarded – undo
164 167
 		}
165 168
 	}
166 169
 
170
+	/**
171
+	 * @param \OCP\DB\QueryBuilder\IQueryBuilder $qb
172
+	 */
167 173
 	private function addQueryConditionsNonExistingParentIdEntry($qb, $storageNumericId = null) {
168 174
 		// Subquery for parent existence
169 175
 		$qbe = $this->connection->getQueryBuilder();
@@ -193,6 +199,9 @@  discard block
 block discarded – undo
193 199
 		}
194 200
 	}
195 201
 
202
+	/**
203
+	 * @param integer $storageNumericId
204
+	 */
196 205
 	private function countResultsToProcessParentIdWrongPath($storageNumericId = null) {
197 206
 		$qb = $this->connection->getQueryBuilder();
198 207
 		$qb->select($qb->createFunction('COUNT(*)'));
@@ -203,6 +212,9 @@  discard block
 block discarded – undo
203 212
 		return $count;
204 213
 	}
205 214
 
215
+	/**
216
+	 * @param integer $storageNumericId
217
+	 */
206 218
 	private function countResultsToProcessNonExistingParentIdEntry($storageNumericId = null) {
207 219
 		$qb = $this->connection->getQueryBuilder();
208 220
 		$qb->select($qb->createFunction('COUNT(*)'));
@@ -353,6 +365,7 @@  discard block
 block discarded – undo
353 365
 	 *
354 366
 	 * @param int $storageId storage id
355 367
 	 * @param string $path path for which to create the parent entry
368
+	 * @param integer $reuseFileId
356 369
 	 * @return int file id of the newly created parent
357 370
 	 */
358 371
 	private function getOrCreateEntry($storageId, $path, $reuseFileId = null) {
Please login to merge, or discard this patch.