owncloud / core

lib/private/Share20/DefaultShareProvider.php

Doc Comments +1 added lines, -1 removed lines

@@ -1051,7 +1051,7 @@
 	/**
 	 * Check whether the share object fits the expectations of this provider
 	 *
-	 * @param IShare $share share
+	 * @param \OCP\Share\IShare $share share
 	 *
 	 * @throws InvalidArgumentException if the share validation failed
 	 */

apps/dav/lib/Connector/LegacyDAVACL.php

Doc Comments +4 added lines

@@ -49,6 +49,10 @@
 		);
 	}
 
+	/**
+	 * @param string $principal
+	 * @param boolean $toV2
+	 */
 	private function convertPrincipal($principal, $toV2) {
 		list(, $name) = URLUtil::splitPath($principal);
 		if ($toV2) {

lib/private/User/AccountMapper.php

Doc Comments +13 added lines, -2 removed lines

@@ -42,7 +42,7 @@ 
 
 	/**
 	 * Delegate to term mapper to avoid needing to inject term mapper
-	 * @param $account_id
+	 * @param integer $account_id
 	 * @param array $terms
 	 */
 	public function setTermsForAccount($account_id, array $terms) {
@@ -51,7 +51,7 @@ 
 
 	/**
 	 * Delegate to term mapper to avoid needing to inject term mapper
-	 * @param $account_id
+	 * @param integer $account_id
 	 * @return AccountTerm[] $terms
 	 */
 	public function findByAccountId($account_id) {
@@ -164,6 +164,9 @@ 
 		return $this->findEntities($qb->getSQL(), $qb->getParameters(), $limit, $offset);
 	}
 
+	/**
+	 * @param boolean $hasLoggedIn
+	 */
 	public function getUserCountPerBackend($hasLoggedIn) {
 		$qb = $this->db->getQueryBuilder();
 		$qb->select(['backend', $qb->createFunction('count(*) as `count`')])
@@ -186,6 +189,9 @@ 
 		return $return;
 	}
 
+	/**
+	 * @param boolean $hasLoggedIn
+	 */
 	public function getUserCount($hasLoggedIn) {
 		$qb = $this->db->getQueryBuilder();
 		$qb->select([$qb->createFunction('count(*) as `count`')])
@@ -202,6 +208,11 @@ 
 		return (int) $data['count'];
 	}
 
+	/**
+	 * @param \Closure $callback
+	 * @param string $search
+	 * @param boolean $onlySeen
+	 */
 	public function callForAllUsers($callback, $search, $onlySeen) {
 		$qb = $this->db->getQueryBuilder();
 		$qb->select(['*'])

lib/private/DB/QueryBuilder/ExpressionBuilder/ExpressionBuilder.php

Doc Comments +2 added lines, -2 removed lines

@@ -361,7 +361,7 @@ 
 	 *
 	 * @param string $column
 	 * @param mixed $type One of IQueryBuilder::PARAM_*
-	 * @return string
+	 * @return QueryFunction
 	 */
 	public function castColumn($column, $type) {
 		return new QueryFunction(
@@ -372,7 +372,7 @@ 
 	/**
 	 * Returns a query function to find the number of characters in a string column
 	 * @param string $column
-	 * @return string
+	 * @return QueryFunction
 	 */
 	public function length($column) {
 		$column = $this->helper->quoteColumnName($column);

lib/private/Encryption/DecryptAll.php

Doc Comments +1 added lines, -1 removed lines

@@ -127,7 +127,7 @@
 	/**
 	 * prepare encryption modules to perform the decrypt all function
 	 *
-	 * @param $user
+	 * @param string $user
 	 * @return bool
 	 */
 	protected function prepareEncryptionModules($user) {

apps/provisioning_api/lib/Users.php

Doc Comments +1 added lines, -1 removed lines

@@ -449,7 +449,7 @@
 	 * @param IUser $user user to check access
 	 * @param IGroup|null $group group to check or null
 	 *
-	 * @return true if the user can manage the group
+	 * @return boolean if the user can manage the group
 	 */
 	private function canUserManageGroup($user, $group) {
 		if ($this->groupManager->isAdmin($user->getUID())) {

Unused Use Statements -1 removed lines

@@ -32,7 +32,6 @@
 use OC\OCS\Result;
 use OC_Helper;
 use OCP\API;
-use OCP\Files\FileInfo;
 use OCP\Files\NotFoundException;
 use OCP\IGroup;
 use OCP\IGroupManager;

lib/private/Preview/Movie.php

Doc Comments +5 added lines, -5 removed lines

@@ -81,8 +81,8 @@ 
 	}
 
 	/**
-	 * @param $absPath
-	 * @return bool|string
+	 * @param string $absPath
+	 * @return false|string
 	 */
 	private function extractMp4CoverArtwork($absPath) {
 		if (isset($this->noArtworkIndex[$absPath])) {
@@ -118,9 +118,9 @@ 
 	}
 
 	/**
-	 * @param $absPath
-	 * @param $second
-	 * @return bool|string
+	 * @param string $absPath
+	 * @param integer $second
+	 * @return string|false
 	 */
 	private function generateFromMovie($absPath, $second) {
 		$tmpPath = \OC::$server->getTempManager()->getTemporaryFile();

lib/private/DB/MigrationService.php

Doc Comments +1 added lines, -1 removed lines

@@ -361,7 +361,7 @@
 
 	/**
 	 * @param string $version
-	 * @return mixed
+	 * @return \Doctrine\DBAL\Schema\Schema
 	 * @throws \Exception
 	 */
 	protected function createInstance($version) {

lib/public/Template.php

Doc Comments +2 added lines, -2 removed lines

@@ -100,8 +100,8 @@
 /**
  * Return the relative date in relation to today. Returns something like "last hour" or "two month ago"
  * @param int $timestamp unix timestamp
- * @param boolean $dateOnly
- * @return \OC\L10N\L10NString human readable interpretation of the timestamp
+ * @param integer $dateOnly
+ * @return string human readable interpretation of the timestamp
  *
  * @deprecated 8.0.0 Use \OCP\Template::relative_modified_date() instead
  */