owncloud / core

apps/files_sharing/lib/external/storage.php

Doc Comments +3 added lines

@@ -90,6 +90,9 @@
 		return $this->token;
 	}
 
+	/**
+	 * @return resource
+	 */
 	public function getPassword() {
 		return $this->password;
 	}

Unused Use Statements -1 removed lines

@@ -30,7 +30,6 @@
 namespace OCA\Files_Sharing\Controllers;
 
 use OC;
-use OC\Files\Filesystem;
 use OC_Files;
 use OC_Util;
 use OCP;

apps/files_sharing/lib/helper.php

Doc Comments +3 added lines

@@ -138,6 +138,9 @@
 		return true;
 	}
 
+	/**
+	 * @param string $target
+	 */
 	public static function getSharesFromItem($target) {
 		$result = array();
 		$owner = \OC\Files\Filesystem::getOwner($target);

apps/files_sharing/lib/sharedmount.php

Doc Comments +5 added lines

@@ -20,6 +20,11 @@
 	 */
 	protected $storage = null;
 
+	/**
+	 * @param string $storage
+	 * @param string $mountpoint
+	 * @param \OC\Files\Storage\StorageFactory $loader
+	 */
 	public function __construct($storage, $mountpoint, $arguments = null, $loader = null) {
 		// first update the mount point before creating the parent
 		$newMountPoint = $this->verifyMountPoint($arguments['share'], $arguments['user']);

apps/files_sharing/tests/controller/sharecontroller.php

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 use OCA\Files_Sharing\Application;
 use OCP\AppFramework\Http\NotFoundResponse;
 use OCP\AppFramework\IAppContainer;
-use OCP\Files;
 use OCP\AppFramework\Http\RedirectResponse;
 use OCP\AppFramework\Http\TemplateResponse;
 use OCP\Security\ISecureRandom;

apps/files_trashbin/lib/trashbin.php

Doc Comments +11 added lines, -8 removed lines

@@ -39,6 +39,9 @@ 
 	 */
 	private static $scannedVersions = false;
 
+	/**
+	 * @param string $filename
+	 */
 	public static function getUidAndFilename($filename) {
 		$uid = \OC\Files\Filesystem::getOwner($filename);
 		\OC\Files\Filesystem::initMountPoints($uid);
@@ -399,7 +402,7 @@ 
 	 * @param string $uniqueFilename new file name to restore the file without overwriting existing files
 	 * @param string $location location if file
 	 * @param int $timestamp deletion time
-	 * @return bool
+	 * @return false|null
 	 */
 	private static function restoreVersions(\OC\Files\View $view, $file, $filename, $uniqueFilename, $location, $timestamp) {
 
@@ -453,7 +456,7 @@ 
 	 * @param string $uniqueFilename new file name to restore the file without overwriting existing files
 	 * @param string $location location of file
 	 * @param int $timestamp deletion time
-	 * @return bool
+	 * @return false|null
 	 */
 	private static function restoreEncryptionKeys(\OC\Files\View $view, $file, $filename, $uniqueFilename, $location, $timestamp) {
 
@@ -550,9 +553,9 @@ 
 
 	/**
 	 * @param \OC\Files\View $view
-	 * @param $file
-	 * @param $filename
-	 * @param $timestamp
+	 * @param string $file
+	 * @param string $filename
+	 * @param integer|null $timestamp
 	 * @return int
 	 */
 	private static function deleteVersions(\OC\Files\View $view, $file, $filename, $timestamp) {
@@ -579,9 +582,9 @@ 
 
 	/**
 	 * @param \OC\Files\View $view
-	 * @param $file
-	 * @param $filename
-	 * @param $timestamp
+	 * @param string $file
+	 * @param string $filename
+	 * @param integer|null $timestamp
 	 * @return int
 	 */
 	private static function deleteEncryptionKeys(\OC\Files\View $view, $file, $filename, $timestamp) {

apps/files_trashbin/tests/storage.php

Unused Use Statements -2 removed lines

@@ -8,9 +8,7 @@
 
 namespace OCA\Files_trashbin\Tests\Storage;
 
-use OC\Files\Storage\Home;
 use OC\Files\Storage\Temporary;
-use OC\Files\Mount\MountPoint;
 use OC\Files\Filesystem;
 
 class Storage extends \Test\TestCase {

apps/files_versions/lib/storage.php

Doc Comments +1 added lines

@@ -531,6 +531,7 @@
 
 	/**
 	 * Erase a file's versions which exceed the set quota
+	 * @param integer $versionsSize
 	 */
 	private static function expire($filename, $versionsSize = null, $offset = 0) {
 		$config = \OC::$server->getConfig();

apps/user_ldap/command/showconfig.php

Unused Use Statements -1 removed lines

@@ -28,7 +28,6 @@
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Helper\Table;
 use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 
 class ListCertificates extends Base {

apps/user_ldap/lib/access.php

Doc Comments +8 added lines, -6 removed lines

@@ -337,7 +337,7 @@ 
 
 	/**
 	 * returns the internal ownCloud name for the given LDAP DN of the user, false on DN outside of search DN or failure
-	 * @param string $dn the dn of the user object
+	 * @param string $fdn the dn of the user object
 	 * @param string $ldapName optional, the display name of the object
 	 * @return string with with the name to use in ownCloud
 	 */
@@ -354,7 +354,7 @@ 
 
 	/**
 	 * returns an internal ownCloud name for the given LDAP DN, false on DN outside of search DN
-	 * @param string $dn the dn of the user object
+	 * @param string $fdn the dn of the user object
 	 * @param string $ldapName optional, the display name of the object
 	 * @param bool $isUser optional, whether it is a user object (otherwise group assumed)
 	 * @return string with with the name to use in ownCloud
@@ -640,7 +640,7 @@ 
 
 	/**
 	 * @param string $filter
-	 * @param string|string[] $attr
+	 * @param string[] $attr
 	 * @param int $limit
 	 * @param int $offset
 	 * @return false|int
@@ -679,6 +679,7 @@ 
 	 * retrieved. Results will according to the order in the array.
 	 * @param int $limit optional, maximum results to be counted
 	 * @param int $offset optional, a starting point
+	 * @param string $filter
 	 * @return array|false array with the search result as first value and pagedSearchOK as
 	 * second | false if not successful
 	 */
@@ -935,7 +936,7 @@ 
 
 	/**
 	 * @param string $name
-	 * @return bool|mixed|string
+	 * @return string
 	 */
 	public function sanitizeUsername($name) {
 		if($this->connection->ldapIgnoreNamingRules) {
@@ -959,6 +960,7 @@ 
 	* escapes (user provided) parts for LDAP filter
 	* @param string $input, the provided value
 	* @param bool $allowAsterisk whether in * at the beginning should be preserved
+	* @param string $input
 	* @return string the escaped string
 	*/
 	public function escapeFilterPart($input, $allowAsterisk = false) {
@@ -1477,7 +1479,7 @@ 
 
 	/**
 	 * Check whether the most recent paged search was successful. It flushed the state var. Use it always after a possible paged search.
-	 * @return boolean|null true on success, null or false otherwise
+	 * @return boolean true on success, null or false otherwise
 	 */
 	public function getPagedSearchResultState() {
 		$result = $this->pagedSearchedSuccessful;
@@ -1492,7 +1494,7 @@ 
 	 * @param string[] $attr optional, when a certain attribute shall be filtered outside
 	 * @param int $limit
 	 * @param int $offset
-	 * @return bool|true
+	 * @return boolean
 	 */
 	private function initPagedSearch($filter, $bases, $attr, $limit, $offset) {
 		$pagedSearchOK = false;