Completed
Pull Request — stable8 (#25505)
by Thomas
24:29
created
lib/private/backgroundjob/joblist.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
 	}
49 49
 
50 50
 	/**
51
-	 * @param Job|string $job
51
+	 * @param \Test\BackgroundJob\TestJob $job
52 52
 	 * @param mixed $argument
53 53
 	 */
54 54
 	public function add($job, $argument = null) {
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
 	}
69 69
 
70 70
 	/**
71
-	 * @param Job|string $job
71
+	 * @param Job $job
72 72
 	 * @param mixed $argument
73 73
 	 */
74 74
 	public function remove($job, $argument = null) {
Please login to merge, or discard this patch.
lib/private/files/mapper.php 1 patch
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -153,6 +153,9 @@  discard block
 block discarded – undo
153 153
 		return $result['physic_path'];
154 154
 	}
155 155
 
156
+	/**
157
+	 * @param string|false $physicalPath
158
+	 */
156 159
 	private function resolvePhysicalPath($physicalPath) {
157 160
 		$physicalPath = $this->resolveRelativePath($physicalPath);
158 161
 		$sql = \OC_DB::prepare('SELECT * FROM `*PREFIX*file_map` WHERE `physic_path_hash` = ?');
@@ -210,6 +213,10 @@  discard block
 block discarded – undo
210 213
 		return $physicalPath;
211 214
 	}
212 215
 
216
+	/**
217
+	 * @param string|false $logicPath
218
+	 * @param string|false $physicalPath
219
+	 */
213 220
 	private function insert($logicPath, $physicalPath) {
214 221
 		$sql = 'INSERT INTO `*PREFIX*file_map` (`logic_path`, `physic_path`, `logic_path_hash`, `physic_path_hash`)
215 222
 				VALUES (?, ?, ?, ?)';
Please login to merge, or discard this patch.
lib/private/repair.php 1 patch
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -144,6 +144,8 @@
 block discarded – undo
144 144
 	 * {@inheritDoc}
145 145
 	 *
146 146
 	 * Re-declared as public to allow invocation from within the closure above in php 5.3
147
+	 * @param string $scope
148
+	 * @param string $method
147 149
 	 */
148 150
 	public function emit($scope, $method, array $arguments = array()) {
149 151
 		parent::emit($scope, $method, $arguments);
Please login to merge, or discard this patch.
lib/private/template.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@
 block discarded – undo
136 136
 	 * Returns the list of members for a group-principal
137 137
 	 *
138 138
 	 * @param string $principal
139
-	 * @return array
139
+	 * @return string[]
140 140
 	 */
141 141
 	function getGroupMemberSet($principal) {
142 142
 		// TODO: for now the group principal has only one member, the user itself
Please login to merge, or discard this patch.
lib/private/template/functions.php 1 patch
Doc Comments   +4 added lines, -3 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
 
31 31
 /**
32 32
  * Prints a sanitized string
33
- * @param string|array $string the string which will be escaped and printed
33
+ * @param string $string the string which will be escaped and printed
34 34
  */
35 35
 function p($string) {
36 36
 	print(OC_Util::sanitizeHTML($string));
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 /**
40 40
  * Prints an unsanitized string - usage of this function may result into XSS.
41 41
  * Consider using p() instead.
42
- * @param string|array $string the string which will be printed as it is
42
+ * @param string $string the string which will be printed as it is
43 43
  */
44 44
 function print_unescaped($string) {
45 45
 	print($string);
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
  * make preview_icon available as a simple function
185 185
  * Returns the path to the preview of the image.
186 186
  * @param string $path path of file
187
- * @return link to the preview
187
+ * @return string to the preview
188 188
  *
189 189
  * For further information have a look at OC_Helper::previewIcon
190 190
  */
@@ -194,6 +194,7 @@  discard block
 block discarded – undo
194 194
 
195 195
 /**
196 196
  * @param string $path
197
+ * @param string $token
197 198
  */
198 199
 function publicPreview_icon ( $path, $token ) {
199 200
 	return OC_Helper::publicPreviewIcon( $path, $token );
Please login to merge, or discard this patch.
tests/lib/appframework/middleware/security/CORSMiddlewareTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,6 @@
 block discarded – undo
27 27
 use OCP\IUser;
28 28
 use OCP\ILogger;
29 29
 use OCP\Files\Folder;
30
-
31 30
 use OC\Share20\Exception\ShareNotFound;
32 31
 
33 32
 /**
Please login to merge, or discard this patch.
tests/lib/repair/cleantags.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -160,8 +160,8 @@
 block discarded – undo
160 160
 	}
161 161
 
162 162
 	/**
163
-	 * @param $tableName
164
-	 * @param $idName
163
+	 * @param string $tableName
164
+	 * @param string $idName
165 165
 	 * @return int
166 166
 	 */
167 167
 	protected function getLastInsertID($tableName, $idName) {
Please login to merge, or discard this patch.
apps/files/controller/apicontroller.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@
 block discarded – undo
91 91
 	 *
92 92
 	 * @NoAdminRequired
93 93
 	 *
94
-	 * @param array $tagName tag name to filter by
94
+	 * @param string[] $tagName tag name to filter by
95 95
 	 * @return DataResponse
96 96
 	 */
97 97
 	public function getFilesByTag($tagName) {
Please login to merge, or discard this patch.
apps/files/index.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,6 @@
 block discarded – undo
20 20
  * License along with this library.  If not, see <http://www.gnu.org/licenses/>.
21 21
  *
22 22
  */
23
-use OCA\Files\Appinfo\Application;
24 23
 
25 24
 // Check if we are a user
26 25
 OCP\User::checkLoggedIn();
Please login to merge, or discard this patch.