Completed
Pull Request — stable8 (#25505)
by Thomas
24:29
created
apps/files_sharing/lib/sharedstorage.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -144,6 +144,9 @@
 block discarded – undo
144 144
 		return true;
145 145
 	}
146 146
 
147
+	/**
148
+	 * @param string $path
149
+	 */
147 150
 	public function url_stat($path) {
148 151
 		if (isset(self::$data[$path])) {
149 152
 			$size = strlen(self::$data[$path]);
Please login to merge, or discard this patch.
apps/files_sharing/tests/sharedmount.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -144,6 +144,9 @@
 block discarded – undo
144 144
 		return true;
145 145
 	}
146 146
 
147
+	/**
148
+	 * @param string $path
149
+	 */
147 150
 	public function url_stat($path) {
148 151
 		if (isset(self::$data[$path])) {
149 152
 			$size = strlen(self::$data[$path]);
Please login to merge, or discard this patch.
lib/private/files/objectstore/objectstorestorage.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -144,6 +144,9 @@
 block discarded – undo
144 144
 		return true;
145 145
 	}
146 146
 
147
+	/**
148
+	 * @param string $path
149
+	 */
147 150
 	public function url_stat($path) {
148 151
 		if (isset(self::$data[$path])) {
149 152
 			$size = strlen(self::$data[$path]);
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@
 block discarded – undo
30 30
 namespace OCA\Files_Sharing\Controllers;
31 31
 
32 32
 use OC;
33
-use OC\Files\Filesystem;
34 33
 use OC_Files;
35 34
 use OC_Util;
36 35
 use OCP;
Please login to merge, or discard this patch.
apps/files_versions/tests/versions.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -759,6 +759,10 @@  discard block
 block discarded – undo
759 759
 		);
760 760
 	}
761 761
 
762
+	/**
763
+	 * @param OC\Files\View $view
764
+	 * @param string $path
765
+	 */
762 766
 	private function createAndCheckVersions($view, $path) {
763 767
 		$view->file_put_contents($path, 'test file');
764 768
 		$view->file_put_contents($path, 'version 1');
@@ -782,7 +786,6 @@  discard block
 block discarded – undo
782 786
 	/**
783 787
 	 * @param string $user
784 788
 	 * @param bool $create
785
-	 * @param bool $password
786 789
 	 */
787 790
 	public static function loginHelper($user, $create = false) {
788 791
 
Please login to merge, or discard this patch.
apps/user_ldap/lib/user/user.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -369,6 +369,7 @@
 block discarded – undo
369 369
 	 * already. If not, it will marked like this, because it is expected that
370 370
 	 * the method will be run, when false is returned.
371 371
 	 * @param string email | quota | avatar (can be extended)
372
+	 * @param string $feature
372 373
 	 * @return bool
373 374
 	 */
374 375
 	private function wasRefreshed($feature) {
Please login to merge, or discard this patch.
lib/private/connector/sabre/principal.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -168,7 +168,7 @@
 block discarded – undo
168 168
 	 * The principals should be passed as a list of uri's.
169 169
 	 *
170 170
 	 * @param string $principal
171
-	 * @param array $members
171
+	 * @param string[] $members
172 172
 	 * @throws \Sabre\DAV\Exception
173 173
 	 */
174 174
 	public function setGroupMemberSet($principal, array $members) {
Please login to merge, or discard this patch.
lib/private/subadmin.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -166,6 +166,11 @@
 block discarded – undo
166 166
 	/*
167 167
 	 * alias for self::isSubAdminofGroup()
168 168
 	 */
169
+
170
+	/**
171
+	 * @param string $subadmin
172
+	 * @param string $group
173
+	 */
169 174
 	public static function isGroupAccessible($subadmin, $group) {
170 175
 		return self::isSubAdminofGroup($subadmin, $group);
171 176
 	}
Please login to merge, or discard this patch.
apps/files_external/lib/config.php 1 patch
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 	 * If the configuration parameter is optional, add a '&' to the beginning of the value
86 86
 	 * If the configuration parameter is hidden, add a '#' to the beginning of the value
87 87
 	 *
88
-	 * @return array
88
+	 * @return string
89 89
 	 */
90 90
 	public static function getBackends() {
91 91
 		$sortFunc = function ($a, $b) {
@@ -484,6 +484,7 @@  discard block
 block discarded – undo
484 484
 	 *
485 485
 	 * @param string $class backend class name
486 486
 	 * @param array $options backend configuration options
487
+	 * @param boolean $isPersonal
487 488
 	 * @return int see self::STATUS_*
488 489
 	 */
489 490
 	public static function getBackendStatus($class, $options, $isPersonal) {
@@ -789,7 +790,7 @@  discard block
 block discarded – undo
789 790
 	 * @param OC_L10N $l
790 791
 	 * @param string $module
791 792
 	 * @param string $backend
792
-	 * @return string
793
+	 * @return OC_L10N_String
793 794
 	 */
794 795
 	private static function getSingleDependencyMessage(OC_L10N $l, $module, $backend) {
795 796
 		switch (strtolower($module)) {
Please login to merge, or discard this patch.
lib/private/api.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
 	/**
156 156
 	 * merge the returned result objects into one response
157 157
 	 * @param array $responses
158
-	 * @return array|\OC_OCS_Result
158
+	 * @return OC_OCS_Result
159 159
 	 */
160 160
 	public static function mergeResponses($responses) {
161 161
 		// Sort into shipped and third-party
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
293 293
 
294 294
 	/**
295 295
 	 * http basic auth
296
-	 * @return string|false (username, or false on failure)
296
+	 * @return string (username, or false on failure)
297 297
 	 */
298 298
 	private static function loginUser() {
299 299
 		if(self::$isLoggedIn === true) {
Please login to merge, or discard this patch.