Completed
Pull Request — stable8 (#25505)
by Thomas
24:29
created
lib/private/db.php 1 patch
Doc Comments   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
 	/**
161 161
 	 * gets last value of autoincrement
162 162
 	 * @param string $table The optional table name (will replace *PREFIX*) and add sequence suffix
163
-	 * @return string id
163
+	 * @return integer id
164 164
 	 * @throws \OC\DatabaseException
165 165
 	 *
166 166
 	 * \Doctrine\DBAL\Connection lastInsertId
@@ -196,7 +196,6 @@  discard block
 block discarded – undo
196 196
 	/**
197 197
 	 * saves database schema to xml file
198 198
 	 * @param string $file name of file
199
-	 * @param int $mode
200 199
 	 * @return bool
201 200
 	 *
202 201
 	 * TODO: write more documentation
@@ -240,7 +239,7 @@  discard block
 block discarded – undo
240 239
 	 * simulate the database schema update
241 240
 	 * @param string $file file to read structure from
242 241
 	 * @throws Exception
243
-	 * @return string|boolean
242
+	 * @return boolean
244 243
 	 */
245 244
 	public static function simulateUpdateDbFromStructure($file) {
246 245
 		$schemaManager = self::getMDB2SchemaManager();
Please login to merge, or discard this patch.
lib/private/db/mdb2schemamanager.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -49,7 +49,6 @@  discard block
 block discarded – undo
49 49
 	/**
50 50
 	 * saves database scheme to xml file
51 51
 	 * @param string $file name of file
52
-	 * @param int|string $mode
53 52
 	 * @return bool
54 53
 	 *
55 54
 	 * TODO: write more documentation
@@ -123,7 +122,7 @@  discard block
 block discarded – undo
123 122
 	/**
124 123
 	 * update the database scheme
125 124
 	 * @param string $file file to read structure from
126
-	 * @return string|boolean
125
+	 * @return boolean
127 126
 	 */
128 127
 	public function simulateUpdateDbFromStructure($file) {
129 128
 		$toSchema = $this->readSchemaFromFile($file);
Please login to merge, or discard this patch.
lib/private/db/migrator.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
 	protected $config;
53 53
 
54 54
 	/**
55
-	 * @param \Doctrine\DBAL\Connection $connection
55
+	 * @param Connection $connection
56 56
 	 * @param ISecureRandom $random
57 57
 	 * @param IConfig $config
58 58
 	 */
Please login to merge, or discard this patch.
lib/private/defaults.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -261,6 +261,9 @@
 block discarded – undo
261 261
 		return $footer;
262 262
 	}
263 263
 
264
+	/**
265
+	 * @param string $key
266
+	 */
264 267
 	public function buildDocLinkToKey($key) {
265 268
 		if ($this->themeExist('buildDocLinkToKey')) {
266 269
 			return $this->theme->buildDocLinkToKey($key);
Please login to merge, or discard this patch.
lib/private/diagnostics/querylogger.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
 	}
54 54
 
55 55
 	/**
56
-	 * @return \OCP\Diagnostics\IQuery[]
56
+	 * @return Query[]
57 57
 	 */
58 58
 	public function getQueries() {
59 59
 		return $this->queries;
Please login to merge, or discard this patch.
lib/private/eventsource.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@
 block discarded – undo
88 88
 	 * send a message to the client
89 89
 	 *
90 90
 	 * @param string $type
91
-	 * @param mixed $data
91
+	 * @param string $data
92 92
 	 *
93 93
 	 * @throws \BadMethodCallException
94 94
 	 * if only one parameter is given, a typeless message will be send with that parameter as data
Please login to merge, or discard this patch.
lib/private/files/fileinfo.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -185,7 +185,7 @@
 block discarded – undo
185 185
 	}
186 186
 
187 187
 	/**
188
-	 * @return \OCP\Files\FileInfo::TYPE_FILE|\OCP\Files\FileInfo::TYPE_FOLDER
188
+	 * @return string
189 189
 	 */
190 190
 	public function getType() {
191 191
 		if (!isset($this->data['type'])) {
Please login to merge, or discard this patch.
lib/private/files/node/folder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -195,7 +195,7 @@
 block discarded – undo
195 195
 	/**
196 196
 	 * search for files by tag
197 197
 	 *
198
-	 * @param string|int $tag name or tag id
198
+	 * @param string $tag name or tag id
199 199
 	 * @param string $userId owner of the tags
200 200
 	 * @return Node[]
201 201
 	 */
Please login to merge, or discard this patch.
lib/private/files/node/root.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -169,7 +169,7 @@
 block discarded – undo
169 169
 	 * @param string $path
170 170
 	 * @throws \OCP\Files\NotFoundException
171 171
 	 * @throws \OCP\Files\NotPermittedException
172
-	 * @return \OCP\Files\Node
172
+	 * @return string
173 173
 	 */
174 174
 	public function get($path) {
175 175
 		$path = $this->normalizePath($path);
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -8,14 +8,11 @@
 block discarded – undo
8 8
 
9 9
 namespace OC\Files\Node;
10 10
 
11
-use OC\Files\Cache\Cache;
12 11
 use OC\Files\Mount\Manager;
13 12
 use OC\Files\Mount\MountPoint;
14 13
 use OCP\Files\NotFoundException;
15 14
 use OCP\Files\NotPermittedException;
16
-use OC\Hooks\Emitter;
17 15
 use OC\Hooks\PublicEmitter;
18
-
19 16
 use OCP\Files\IRootFolder;
20 17
 
21 18
 /**
Please login to merge, or discard this patch.