Completed
Pull Request — stable8 (#25505)
by Thomas
24:29
created
lib/private/preferences.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@
 block discarded – undo
72 72
 	 * Get the available keys for an app
73 73
 	 * @param string $user user
74 74
 	 * @param string $app the app we are looking for
75
-	 * @return array an array of key names
75
+	 * @return string[] an array of key names
76 76
 	 * @deprecated use getUserKeys of \OCP\IConfig instead
77 77
 	 *
78 78
 	 * This function gets all keys of an app of an user. Please note that the
Please login to merge, or discard this patch.
lib/private/preview.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@
 block discarded – undo
69 69
 	 * @param int $maxY The maximum Y size of the thumbnail. It can be smaller depending on the shape of the image
70 70
 	 * @param bool $scalingUp Disable/Enable upscaling of previews
71 71
 	 * @throws \Exception
72
-	 * @return mixed (bool / string)
72
+	 * @return integer (bool / string)
73 73
 	 *                    false if thumbnail does not exist
74 74
 	 *                    path to thumbnail if thumbnail exists
75 75
 	 */
Please login to merge, or discard this patch.
lib/private/search/result/file.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@
 block discarded – undo
30 30
 namespace OCA\Files_Sharing\Controllers;
31 31
 
32 32
 use OC;
33
-use OC\Files\Filesystem;
34 33
 use OC_Files;
35 34
 use OC_Util;
36 35
 use OCP;
Please login to merge, or discard this patch.
lib/private/share/helper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@
 block discarded – undo
136 136
 	 * Returns the list of members for a group-principal
137 137
 	 *
138 138
 	 * @param string $principal
139
-	 * @return array
139
+	 * @return string[]
140 140
 	 */
141 141
 	function getGroupMemberSet($principal) {
142 142
 		// TODO: for now the group principal has only one member, the user itself
Please login to merge, or discard this patch.
lib/private/share/share.php 1 patch
Doc Comments   +11 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1067,7 +1067,7 @@  discard block
 block discarded – undo
1067 1067
 	 * @param string $shareTime timestamp when the file was shared
1068 1068
 	 * @param string $itemType
1069 1069
 	 * @param string $itemSource
1070
-	 * @return DateTime validated date
1070
+	 * @return \DateTime validated date
1071 1071
 	 * @throws \Exception
1072 1072
 	 */
1073 1073
 	private static function validateExpireDate($expireDate, $shareTime, $itemType, $itemSource) {
@@ -2066,6 +2066,16 @@  discard block
 block discarded – undo
2066 2066
 		return $id ? $id : false;
2067 2067
 	}
2068 2068
 
2069
+	/**
2070
+	 * @param string $itemType
2071
+	 * @param string $itemSource
2072
+	 * @param integer $shareType
2073
+	 * @param string $shareWith
2074
+	 * @param string $uidOwner
2075
+	 * @param integer $permissions
2076
+	 * @param string|null $itemSourceName
2077
+	 * @param null|\DateTime $expirationDate
2078
+	 */
2069 2079
 	private static function checkReshare($itemType, $itemSource, $shareType, $shareWith, $uidOwner, $permissions, $itemSourceName, $expirationDate) {
2070 2080
 		$backend = self::getBackend($itemType);
2071 2081
 
Please login to merge, or discard this patch.
lib/private/tempmanager.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -41,6 +41,9 @@  discard block
 block discarded – undo
41 41
 		$this->log = $logger;
42 42
 	}
43 43
 
44
+	/**
45
+	 * @param string $postFix
46
+	 */
44 47
 	protected function generatePath($postFix) {
45 48
 		return $this->tmpBaseDir . '/oc_tmp_' . md5(time() . rand()) . $postFix;
46 49
 	}
@@ -98,6 +101,9 @@  discard block
 block discarded – undo
98 101
 		$this->cleanFiles($this->current);
99 102
 	}
100 103
 
104
+	/**
105
+	 * @param string[] $files
106
+	 */
101 107
 	protected function cleanFiles($files) {
102 108
 		foreach ($files as $file) {
103 109
 			if (file_exists($file)) {
Please login to merge, or discard this patch.
lib/private/urlgenerator.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -45,8 +45,7 @@
 block discarded – undo
45 45
 
46 46
 	/**
47 47
 	 * Creates an absolute url using a defined route
48
-	 * @param string $route
49
-	 * @param array $parameters
48
+	 * @param string $routeName
50 49
 	 * @internal param array $args with param=>value, will be appended to the returned url
51 50
 	 * @return string the url
52 51
 	 *
Please login to merge, or discard this patch.
lib/public/share.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -262,7 +262,6 @@
 block discarded – undo
262 262
 	/**
263 263
 	 * Unshare an item shared with the current user
264 264
 	 * @param string $itemType
265
-	 * @param string $itemTarget
266 265
 	 * @return boolean true on success or false on failure
267 266
 	 *
268 267
 	 * Unsharing from self is not allowed for items inside collections
Please login to merge, or discard this patch.
lib/public/util.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -328,7 +328,7 @@  discard block
 block discarded – undo
328 328
 	/**
329 329
 	 * Make a computer file size (2 kB to 2048)
330 330
 	 * @param string $str file size in a fancy format
331
-	 * @return int a file size in bytes
331
+	 * @return double a file size in bytes
332 332
 	 *
333 333
 	 * Inspired by: http://www.php.net/manual/en/function.filesize.php#92418
334 334
 	 */
@@ -414,7 +414,7 @@  discard block
 block discarded – undo
414 414
 	 * @param array $input The array to work on
415 415
 	 * @param int $case Either MB_CASE_UPPER or MB_CASE_LOWER (default)
416 416
 	 * @param string $encoding The encoding parameter is the character encoding. Defaults to UTF-8
417
-	 * @return array
417
+	 * @return string
418 418
 	 */
419 419
 	public static function mb_array_change_key_case($input, $case = MB_CASE_LOWER, $encoding = 'UTF-8') {
420 420
 		return(\OC_Helper::mb_array_change_key_case($input, $case, $encoding));
Please login to merge, or discard this patch.