Completed
Pull Request — stable8 (#25505)
by Thomas
24:29
created
lib/private/activitymanager.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
 	}
110 110
 
111 111
 	/**
112
-	 * @param array $types
112
+	 * @param string[] $types
113 113
 	 * @param string $filter
114 114
 	 * @return array
115 115
 	 */
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
 	/**
148 148
 	 * @param string $app
149 149
 	 * @param string $text
150
-	 * @param array $params
150
+	 * @param string $params
151 151
 	 * @param boolean $stripPath
152 152
 	 * @param boolean $highlightParams
153 153
 	 * @param string $languageCode
Please login to merge, or discard this patch.
lib/private/allconfig.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
 	 * Looks up a system wide defined value
94 94
 	 *
95 95
 	 * @param string $key the key of the value, under which it was saved
96
-	 * @param mixed $default the default value to be returned if the value isn't set
96
+	 * @param string $default the default value to be returned if the value isn't set
97 97
 	 * @return mixed the value or $default
98 98
 	 */
99 99
 	public function getSystemValue($key, $default = '') {
@@ -351,7 +351,7 @@  discard block
 block discarded – undo
351 351
 	 *
352 352
 	 * @param string $appName app to get the value for
353 353
 	 * @param string $key the key to get the value for
354
-	 * @param array $userIds the user IDs to fetch the values for
354
+	 * @param string[] $userIds the user IDs to fetch the values for
355 355
 	 * @return array Mapped values: userId => value
356 356
 	 */
357 357
 	public function getUserValueForUsers($appName, $key, $userIds) {
Please login to merge, or discard this patch.
lib/private/app.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -519,7 +519,7 @@  discard block
 block discarded – undo
519 519
 
520 520
 	/**
521 521
 	 * search for an app in all app-directories
522
-	 * @param $appId
522
+	 * @param string $appId
523 523
 	 * @return mixed (bool|string)
524 524
 	 */
525 525
 	protected static function findAppInDirectories($appId) {
@@ -741,6 +741,8 @@  discard block
 block discarded – undo
741 741
 
742 742
 	/**
743 743
 	 * register a personal form to be shown
744
+	 * @param string $app
745
+	 * @param string $page
744 746
 	 */
745 747
 	public static function registerPersonal($app, $page) {
746 748
 		self::$personalForms[] = $app . '/' . $page . '.php';
@@ -920,6 +922,7 @@  discard block
 block discarded – undo
920 922
 
921 923
 	/**
922 924
 	 * get a list of all apps on apps.owncloud.com
925
+	 * @param integer $category
923 926
 	 * @return array, multi-dimensional array of apps.
924 927
 	 *     Keys: id, name, type, typename, personid, license, detailpage, preview, changed, description
925 928
 	 */
Please login to merge, or discard this patch.
lib/private/appconfig.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@
 block discarded – undo
76 76
 
77 77
 	/**
78 78
 	 * @param string $app
79
-	 * @return \string[]
79
+	 * @return string[]
80 80
 	 */
81 81
 	private function getAppValues($app) {
82 82
 		$appCache = $this->getAppCache($app);
Please login to merge, or discard this patch.
lib/private/appframework/dependencyinjection/dicontainer.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,6 @@
 block discarded – undo
37 37
 use OC\AppFramework\Utility\TimeFactory;
38 38
 use OC\AppFramework\Utility\ControllerMethodReflector;
39 39
 use OCP\AppFramework\IApi;
40
-use OCP\AppFramework\QueryException;
41 40
 use OCP\AppFramework\IAppContainer;
42 41
 use OCP\AppFramework\Middleware;
43 42
 use OCP\IServerContainer;
Please login to merge, or discard this patch.
lib/private/appframework/utility/simplecontainer.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 
34 34
 
35 35
 	/**
36
-	 * @param ReflectionClass $class the class to instantiate
36
+	 * @param \ReflectionClass $class the class to instantiate
37 37
 	 * @return stdClass the created class
38 38
 	 */
39 39
 	private function buildClass(\ReflectionClass $class) {
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
 
101 101
 	/**
102 102
 	 * @param string $name
103
-	 * @param mixed $value
103
+	 * @param string $value
104 104
 	 */
105 105
 	function registerParameter($name, $value) {
106 106
 		$this[$name] = $value;
Please login to merge, or discard this patch.
lib/private/avatar.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
 
45 45
 	/**
46 46
 	 * sets the users avatar
47
-	 * @param \OC_Image|resource|string $data OC_Image, imagedata or path to set a new avatar
47
+	 * @param null|string $data OC_Image, imagedata or path to set a new avatar
48 48
 	 * @throws Exception if the provided file is not a jpg or png image
49 49
 	 * @throws Exception if the provided image is not valid
50 50
 	 * @throws \OC\NotSquareException if the image is not square
Please login to merge, or discard this patch.
lib/private/connector/sabre/file.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
 	/**
172 172
 	 * Returns the data
173 173
 	 *
174
-	 * @return string|resource
174
+	 * @return string|null
175 175
 	 */
176 176
 	public function get() {
177 177
 		//throw exception if encryption is disabled but files are still encrypted
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
221 221
 	/**
222 222
 	 * Returns the size of the node, in bytes
223 223
 	 *
224
-	 * @return int|float
224
+	 * @return integer
225 225
 	 */
226 226
 	public function getSize() {
227 227
 		return $this->info->getSize();
@@ -236,7 +236,7 @@  discard block
 block discarded – undo
236 236
 	 *
237 237
 	 * Return null if the ETag can not effectively be determined
238 238
 	 *
239
-	 * @return mixed
239
+	 * @return string
240 240
 	 */
241 241
 	public function getETag() {
242 242
 		return '"' . $this->info->getEtag() . '"';
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
 	 *
248 248
 	 * If null is returned, we'll assume application/octet-stream
249 249
 	 *
250
-	 * @return mixed
250
+	 * @return string
251 251
 	 */
252 252
 	public function getContentType() {
253 253
 		$mimeType = $this->info->getMimetype();
Please login to merge, or discard this patch.
lib/private/connector/sabre/node.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -310,7 +310,7 @@
 block discarded – undo
310 310
 	/**
311 311
 	 * get the users email address
312 312
 	 *
313
-	 * @return string|null
313
+	 * @return string
314 314
 	 * @since 9.0.0
315 315
 	 */
316 316
 	public function getEMailAddress() {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -1,7 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3 3
 use Sabre\DAV\URLUtil;
4
-use OC\Connector\Sabre\TagList;
5 4
 
6 5
 /**
7 6
  * ownCloud
Please login to merge, or discard this patch.