Completed
Pull Request — stable8.2 (#26410)
by Thomas
38:55
created
apps/user_ldap/command/setconfig.php 1 patch
Doc Comments   -2 removed lines patch added patch discarded remove patch
@@ -73,8 +73,6 @@
 block discarded – undo
73 73
 	/**
74 74
 	 * save the configuration value as provided
75 75
 	 * @param string $configID
76
-	 * @param string $configKey
77
-	 * @param string $configValue
78 76
 	 */
79 77
 	protected function setValue($configID, $key, $value) {
80 78
 		$configHolder = new Configuration($configID);
Please login to merge, or discard this patch.
apps/user_ldap/lib/configuration.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -281,7 +281,6 @@
 block discarded – undo
281 281
 	 * 
282 282
 	 * @param string $varName name of config-key
283 283
 	 * @param array|string $value to set
284
-	 * @param boolean $trim Trim value? (default: false)
285 284
 	 */
286 285
 	protected function setMultiLine($varName, $value) {
287 286
 		if(empty($value)) {
Please login to merge, or discard this patch.
apps/user_ldap/lib/jobs.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
 	}
69 69
 
70 70
 	/**
71
-	 * @return int
71
+	 * @return string
72 72
 	 */
73 73
 	static private function getRefreshInterval() {
74 74
 		//defaults to every hour
Please login to merge, or discard this patch.
user_ldap/tests/integration/lib/integrationtestfetchusersbyloginname.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,6 @@
 block discarded – undo
21 21
 
22 22
 namespace OCA\user_ldap\tests\integration\lib;
23 23
 
24
-use OCA\user_ldap\lib\user\Manager as LDAPUserManager;
25 24
 use OCA\user_ldap\tests\integration\AbstractIntegrationTest;
26 25
 use OCA\User_LDAP\Mapping\UserMapping;
27 26
 use OCA\user_ldap\USER_LDAP;
Please login to merge, or discard this patch.
apps/user_ldap/user_ldap.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -149,8 +149,8 @@
 block discarded – undo
149 149
 	 * Get a list of all users
150 150
 	 *
151 151
 	 * @param string $search
152
-	 * @param null|int $limit
153
-	 * @param null|int $offset
152
+	 * @param integer $limit
153
+	 * @param integer $offset
154 154
 	 * @return string[] an array of all uids
155 155
 	 */
156 156
 	public function getUsers($search = '', $limit = 10, $offset = 0) {
Please login to merge, or discard this patch.
build/license.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -118,6 +118,9 @@  discard block
 block discarded – undo
118 118
 		echo "License updated: $path" . PHP_EOL;
119 119
 	}
120 120
 
121
+	/**
122
+	 * @param string $source
123
+	 */
121 124
 	private function isMITLicensed($source) {
122 125
 		$lines = explode(PHP_EOL, $source);
123 126
 		while(!empty($lines)) {
@@ -131,6 +134,9 @@  discard block
 block discarded – undo
131 134
 		return false;
132 135
 	}
133 136
 
137
+	/**
138
+	 * @param string $source
139
+	 */
134 140
 	private function eatOldLicense($source) {
135 141
 		$lines = explode(PHP_EOL, $source);
136 142
 		while(!empty($lines)) {
Please login to merge, or discard this patch.
core/lostpassword/controller/lostcontroller.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -131,7 +131,7 @@
 block discarded – undo
131 131
 	}
132 132
 
133 133
 	/**
134
-	 * @param $message
134
+	 * @param string $message
135 135
 	 * @param array $additional
136 136
 	 * @return array
137 137
 	 */
Please login to merge, or discard this patch.
lib/private/activitymanager.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
 	/**
330 330
 	 * @param string $app
331 331
 	 * @param string $text
332
-	 * @param array $params
332
+	 * @param string $params
333 333
 	 * @param boolean $stripPath
334 334
 	 * @param boolean $highlightParams
335 335
 	 * @param string $languageCode
@@ -427,7 +427,7 @@  discard block
 block discarded – undo
427 427
 	}
428 428
 
429 429
 	/**
430
-	 * @param array $types
430
+	 * @param string[] $types
431 431
 	 * @param string $filter
432 432
 	 * @return array
433 433
 	 */
Please login to merge, or discard this patch.
lib/private/allconfig.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 	 * Looks up a system wide defined value
112 112
 	 *
113 113
 	 * @param string $key the key of the value, under which it was saved
114
-	 * @param mixed $default the default value to be returned if the value isn't set
114
+	 * @param string $default the default value to be returned if the value isn't set
115 115
 	 * @return mixed the value or $default
116 116
 	 */
117 117
 	public function getSystemValue($key, $default = '') {
@@ -264,7 +264,7 @@  discard block
 block discarded – undo
264 264
 	 * @param string $userId the userId of the user that we want to store the value under
265 265
 	 * @param string $appName the appName that we stored the value under
266 266
 	 * @param string $key the key under which the value is being stored
267
-	 * @param mixed $default the default value to be returned if the value isn't set
267
+	 * @param null|string $default the default value to be returned if the value isn't set
268 268
 	 * @return string
269 269
 	 */
270 270
 	public function getUserValue($userId, $appName, $key, $default = '') {
@@ -381,7 +381,7 @@  discard block
 block discarded – undo
381 381
 	 *
382 382
 	 * @param string $appName app to get the value for
383 383
 	 * @param string $key the key to get the value for
384
-	 * @param array $userIds the user IDs to fetch the values for
384
+	 * @param string[] $userIds the user IDs to fetch the values for
385 385
 	 * @return array Mapped values: userId => value
386 386
 	 */
387 387
 	public function getUserValueForUsers($appName, $key, $userIds) {
Please login to merge, or discard this patch.