owncloud / core

lib/private/Files/External/Service/StoragesService.php

Unused Use Statements -1 removed lines

@@ -27,7 +27,6 @@
 use OCP\IUser;
 use OCP\ILogger;
 use OCP\Files\Folder;
-
 use OC\Share20\Exception\ShareNotFound;
 
 /**

apps/dav/lib/CardDAV/AddressBookImpl.php

Doc Comments +3 added lines, -3 removed lines

@@ -51,7 +51,7 @@ 
 	 * @param AddressBook $addressBook
 	 * @param array $addressBookInfo
 	 * @param CardDavBackend $backend
-	 * @param IUrlGenerator $urlGenerator
+	 * @param IURLGenerator $urlGenerator
 	 */
 	public function __construct(
 			AddressBook $addressBook,
@@ -134,7 +134,7 @@ 
 	}
 
 	/**
-	 * @return mixed
+	 * @return integer
 	 * @since 5.0.0
 	 */
 	public function getPermissions() {
@@ -172,7 +172,7 @@ 
 	 * read vCard data into a vCard object
 	 *
 	 * @param string $cardData
-	 * @return VCard
+	 * @return \Sabre\VObject\Parser\Sabre\VObject\Document|null
 	 */
 	protected function readCard($cardData) {
 		return  Reader::read($cardData);

apps/dav/lib/CardDAV/CardDavBackend.php

Doc Comments +8 added lines, -3 removed lines

@@ -189,7 +189,8 @@ 
 	}
 
 	/**
-	 * @param $addressBookUri
+	 * @param string $addressBookUri
+	 * @param string $principal
 	 * @return array|null
 	 */
 	public function getAddressBooksByUri($principal, $addressBookUri) {
@@ -871,6 +872,7 @@ 
 	 *   * readOnly - boolean
 	 *   * summary - Optional, a description for the share
 	 *
+	 * @param integer $addressBookId
 	 * @return array
 	 */
 	public function getShares($addressBookId) {
@@ -924,7 +926,7 @@ 
 	 * read vCard data into a vCard object
 	 *
 	 * @param string $cardData
-	 * @return VCard
+	 * @return \Sabre\VObject\Parser\Sabre\VObject\Document|null
 	 */
 	protected function readCard($cardData) {
 		return  Reader::read($cardData);
@@ -970,7 +972,7 @@ 
 
 	/**
 	 * For shared address books the sharee is set in the ACL of the address book
-	 * @param $addressBookId
+	 * @param integer $addressBookId
 	 * @param $acl
 	 * @return array
 	 */
@@ -978,6 +980,9 @@ 
 		return $this->sharingBackend->applyShareAcl($addressBookId, $acl);
 	}
 
+	/**
+	 * @param boolean $toV2
+	 */
 	private function convertPrincipal($principalUri, $toV2) {
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
 			list(, $name) = URLUtil::splitPath($principalUri);

core/Application.php

Unused Use Statements -1 removed lines

@@ -32,7 +32,6 @@
 use OC\Core\Controller\AvatarController;
 use OC\Core\Controller\LoginController;
 use OC\Core\Controller\LostController;
-use OC\Core\Controller\OccController;
 use OC\Core\Controller\TokenController;
 use OC\Core\Controller\TwoFactorChallengeController;
 use OC\Core\Controller\UserController;

apps/files_sharing/lib/Controller/ShareesController.php

Doc Comments +1 added lines, -1 removed lines

@@ -327,7 +327,7 @@
 	 * split user and remote from federated cloud id
 	 *
 	 * @param string $address federated share address
-	 * @return array [user, remoteURL]
+	 * @return string[] [user, remoteURL]
 	 * @throws \Exception
 	 */
 	public function splitUserRemote($address) {

apps/federation/lib/Controller/OCSAuthAPIController.php

Doc Comments +4 added lines

@@ -164,6 +164,10 @@
 			'data' => ['sharedSecret' => $sharedSecret]];
 	}
 
+	/**
+	 * @param string $url
+	 * @param string $token
+	 */
 	protected function isValidToken($url, $token) {
 		$storedToken = $this->dbHandler->getToken($url);
 		return hash_equals($storedToken, $token);

apps/dav/lib/CalDAV/CalDavBackend.php

Doc Comments +7 added lines, -1 removed lines

@@ -262,6 +262,9 @@ 
 		return array_values($calendars);
 	}
 
+	/**
+	 * @param string $principalUri
+	 */
 	public function getUsersOwnCalendars($principalUri) {
 		$principalUri = $this->convertPrincipal($principalUri, true);
 		$fields = array_values($this->propertyMap);
@@ -1254,7 +1257,7 @@ 
 	 * @param string $principalUri
 	 * @param string $uri
 	 * @param array $properties
-	 * @return mixed
+	 * @return integer
 	 */
 	function createSubscription($principalUri, $uri, array $properties) {
 
@@ -1657,6 +1660,9 @@ 
 		return $this->sharingBackend->applyShareAcl($resourceId, $acl);
 	}
 
+	/**
+	 * @param boolean $toV2
+	 */
 	private function convertPrincipal($principalUri, $toV2) {
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
 			list(, $name) = URLUtil::splitPath($principalUri);

lib/private/User/Manager.php

Doc Comments -1 removed lines

@@ -379,7 +379,6 @@
 
 	/**
 	 * @param \Closure $callback
-	 * @param string $search
 	 * @since 9.0.0
 	 */
 	public function callForSeenUsers (\Closure $callback) {

lib/public/IUserManager.php

Doc Comments +6 added lines, -2 removed lines

@@ -45,6 +45,7 @@ 
 	 *
 	 * @param \OCP\UserInterface $backend
 	 * @since 8.0.0
+	 * @return void
 	 */
 	public function registerBackend($backend);
 
@@ -60,12 +61,14 @@ 
 	 *
 	 * @param \OCP\UserInterface $backend
 	 * @since 8.0.0
+	 * @return void
 	 */
 	public function removeBackend($backend);
 
 	/**
 	 * remove all user backends
 	 * @since 8.0.0
+	 * @return void
 	 */
 	public function clearBackends() ;
 
@@ -131,7 +134,7 @@ 
 	/**
 	 * returns how many users per backend exist (if supported by backend)
 	 *
-	 * @return array an array of backend class as key and count number as value
+	 * @return integer an array of backend class as key and count number as value
 	 * @since 8.0.0
 	 */
 	public function countUsers();
@@ -140,6 +143,7 @@ 
 	 * @param \Closure $callback
 	 * @param string $search
 	 * @since 9.0.0
+	 * @return void
 	 */
 	public function callForAllUsers (\Closure $callback, $search = '');
 
@@ -153,8 +157,8 @@ 
 
 	/**
 	 * @param \Closure $callback
-	 * @param string $search
 	 * @since 9.2.0
+	 * @return void
 	 */
 	public function callForSeenUsers (\Closure $callback);