Completed
Pull Request — master (#31651)
by Thomas
12:11
created
settings/ChangePassword/Controller.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -67,6 +67,9 @@
 block discarded – undo
67 67
 		}
68 68
 	}
69 69
 
70
+	/**
71
+	 * @param string|boolean $username
72
+	 */
70 73
 	private static function sendNotificationMail($username) {
71 74
 		$userObject = \OC::$server->getUserManager()->get($username);
72 75
 		$email = $userObject->getEMailAddress();
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/SyncService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -245,7 +245,7 @@
 block discarded – undo
245 245
 	}
246 246
 
247 247
 	/**
248
-	 * @return array|null
248
+	 * @return string
249 249
 	 */
250 250
 	public function getLocalSystemAddressBook() {
251 251
 		if ($this->localSystemAddressBook === null) {
Please login to merge, or discard this patch.
apps/files_sharing/lib/Hooks.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,6 @@
 block discarded – undo
33 33
 use OCP\Share\IShare;
34 34
 use Symfony\Component\EventDispatcher\GenericEvent;
35 35
 use OCA\Files_Sharing\Service\NotificationPublisher;
36
-use OCP\Share\Exceptions\ShareNotFound;
37 36
 
38 37
 class Hooks {
39 38
 	/**
Please login to merge, or discard this patch.
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -138,6 +138,10 @@
 block discarded – undo
138 138
 		);
139 139
 	}
140 140
 
141
+	/**
142
+	 * @param IShare[] $shares
143
+	 * @param string $fileId
144
+	 */
141 145
 	private function filterSharesByFileId($shares, $fileId) {
142 146
 		return \array_filter($shares, function (IShare $share) use ($fileId) {
143 147
 			return \strval($share->getNodeId()) === \strval($fileId);
Please login to merge, or discard this patch.
settings/Application.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -39,12 +39,9 @@
 block discarded – undo
39 39
 use OC\Settings\Controller\AuthSettingsController;
40 40
 use OC\Settings\Controller\CertificateController;
41 41
 use OC\Settings\Controller\CheckSetupController;
42
-use OC\Settings\Controller\GroupsController;
43 42
 use OC\Settings\Controller\LegalSettingsController;
44 43
 use OC\Settings\Controller\LogSettingsController;
45 44
 use OC\Settings\Controller\MailSettingsController;
46
-use OC\Settings\Controller\UsersController;
47
-use OC\Settings\Middleware\SubadminMiddleware;
48 45
 use OCP\AppFramework\App;
49 46
 use OCP\IContainer;
50 47
 use OCP\Util;
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/Node.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -384,6 +384,9 @@
 block discarded – undo
384 384
 		$this->fileView->changeLock($this->path, $type);
385 385
 	}
386 386
 
387
+	/**
388
+	 * @param boolean $recursive
389
+	 */
387 390
 	public function getLocks($recursive) {
388 391
 		$this->fileView->getLocks($this->path);
389 392
 	}
Please login to merge, or discard this patch.
apps/dav/lib/Files/FileLocksBackend.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -33,6 +33,9 @@  discard block
 block discarded – undo
33 33
 	/** @var Tree */
34 34
 	private $tree;
35 35
 
36
+	/**
37
+	 * @param Tree $tree
38
+	 */
36 39
 	public function __construct($tree) {
37 40
 		$this->tree = $tree;
38 41
 	}
@@ -75,7 +78,7 @@  discard block
 block discarded – undo
75 78
 	 *
76 79
 	 * @param string $uri
77 80
 	 * @param Locks\LockInfo $lockInfo
78
-	 * @return bool
81
+	 * @return boolean|null
79 82
 	 */
80 83
 	function lock($uri, Locks\LockInfo $lockInfo) {
81 84
 		// TODO: Implement lock() method.
@@ -86,7 +89,7 @@  discard block
 block discarded – undo
86 89
 	 *
87 90
 	 * @param string $uri
88 91
 	 * @param Locks\LockInfo $lockInfo
89
-	 * @return bool
92
+	 * @return boolean|null
90 93
 	 */
91 94
 	function unlock($uri, Locks\LockInfo $lockInfo) {
92 95
 		// TODO: Implement unlock() method.
Please login to merge, or discard this patch.