Completed
Pull Request — master (#24728)
by Joas
35:07
created
settings/Controller/CheckSetupController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -268,7 +268,7 @@
 block discarded – undo
268 268
 
269 269
 	/**
270 270
 	 * @NoCSRFRequired
271
-	 * @return DataResponse
271
+	 * @return DataDisplayResponse
272 272
 	 */
273 273
 	public function getFailedIntegrityCheckFiles() {
274 274
 		$completeResults = $this->checker->getResults();
Please login to merge, or discard this patch.
lib/private/App/AppManager.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
 	/**
89 89
 	 * List all installed apps
90 90
 	 *
91
-	 * @return string[]
91
+	 * @return integer[]
92 92
 	 */
93 93
 	public function getInstalledApps() {
94 94
 		return array_keys($this->getInstalledAppsValues());
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
 	/**
217 217
 	 * Returns a list of apps that need upgrade
218 218
 	 *
219
-	 * @param array $version ownCloud version as array of version components
219
+	 * @param array $ocVersion ownCloud version as array of version components
220 220
 	 * @return array list of app info from apps that need an upgrade
221 221
 	 *
222 222
 	 * @internal
@@ -289,6 +289,9 @@  discard block
 block discarded – undo
289 289
 		return in_array($appId, $this->shippedApps);
290 290
 	}
291 291
 
292
+	/**
293
+	 * @param string $appId
294
+	 */
292 295
 	private function isAlwaysEnabled($appId) {
293 296
 		$alwaysEnabled = $this->getAlwaysEnabledApps();
294 297
 		return in_array($appId, $alwaysEnabled);
Please login to merge, or discard this patch.
lib/private/App/CodeChecker/NodeVisitor.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -42,6 +42,9 @@
 block discarded – undo
42 42
 	protected $testId;
43 43
 	protected $preName;
44 44
 
45
+	/**
46
+	 * @param string $name
47
+	 */
45 48
 	public function __construct($name=null){
46 49
 		$this->addType('testId', 'integer');		
47 50
 		$this->name = $name;
Please login to merge, or discard this patch.
lib/private/App/Platform.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,6 @@
 block discarded – undo
22 22
 
23 23
 namespace OC\App;
24 24
 
25
-use OC_Util;
26 25
 use OCP\IConfig;
27 26
 
28 27
 /**
Please login to merge, or discard this patch.
apps/files_external/lib/storage/amazons3.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -144,6 +144,9 @@
 block discarded – undo
144 144
 		return true;
145 145
 	}
146 146
 
147
+	/**
148
+	 * @param string $path
149
+	 */
147 150
 	public function url_stat($path) {
148 151
 		if (isset(self::$data[$path])) {
149 152
 			$size = strlen(self::$data[$path]);
Please login to merge, or discard this patch.
apps/files_external/lib/storage/dropbox.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -144,6 +144,9 @@
 block discarded – undo
144 144
 		return true;
145 145
 	}
146 146
 
147
+	/**
148
+	 * @param string $path
149
+	 */
147 150
 	public function url_stat($path) {
148 151
 		if (isset(self::$data[$path])) {
149 152
 			$size = strlen(self::$data[$path]);
Please login to merge, or discard this patch.
apps/files_external/lib/storage/sftp.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,6 @@
 block discarded – undo
27 27
 use OCP\IUser;
28 28
 use OCP\ILogger;
29 29
 use OCP\Files\Folder;
30
-
31 30
 use OC\Share20\Exception\ShareNotFound;
32 31
 
33 32
 /**
Please login to merge, or discard this patch.
lib/private/Security/CredentialsManager.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,6 @@
 block discarded – undo
20 20
  */
21 21
 
22 22
 use OC\Share\MailNotifications;
23
-use OCP\IConfig;
24 23
 use OCP\IL10N;
25 24
 use OCP\IUser;
26 25
 use OCP\Mail\IMailer;
Please login to merge, or discard this patch.
lib/private/Session/CryptoSessionData.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -153,7 +153,7 @@
 block discarded – undo
153 153
 
154 154
 	/**
155 155
 	 * @param mixed $offset
156
-	 * @return mixed
156
+	 * @return string|null
157 157
 	 */
158 158
 	public function offsetGet($offset) {
159 159
 		return $this->get($offset);
Please login to merge, or discard this patch.