Completed
Pull Request — master (#24728)
by Joas
35:07
created
lib/private/User/Session.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
 	/**
190 190
 	 * get the current active user
191 191
 	 *
192
-	 * @return IUser|null Current user, otherwise null
192
+	 * @return null|User Current user, otherwise null
193 193
 	 */
194 194
 	public function getUser() {
195 195
 		// FIXME: This is a quick'n dirty work-around for the incognito mode as
@@ -294,7 +294,7 @@  discard block
 block discarded – undo
294 294
 	 *
295 295
 	 * @param string $uid
296 296
 	 * @param string $password
297
-	 * @return boolean|null
297
+	 * @return boolean
298 298
 	 * @throws LoginException
299 299
 	 */
300 300
 	public function login($uid, $password) {
@@ -368,6 +368,9 @@  discard block
 block discarded – undo
368 368
 		return false;
369 369
 	}
370 370
 
371
+	/**
372
+	 * @param string $uid
373
+	 */
371 374
 	private function loginWithToken($uid) {
372 375
 		// TODO: $this->manager->emit('\OC\User', 'preTokenLogin', array($uid));
373 376
 		$user = $this->manager->get($uid);
Please login to merge, or discard this patch.
apps/files_trashbin/lib/BackgroundJob/ExpireTrash.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,6 @@
 block discarded – undo
20 20
  */
21 21
 
22 22
 use OC\Share\MailNotifications;
23
-use OCP\IConfig;
24 23
 use OCP\IL10N;
25 24
 use OCP\IUser;
26 25
 use OCP\Mail\IMailer;
Please login to merge, or discard this patch.
apps/files_trashbin/lib/Storage.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -777,7 +777,7 @@
 block discarded – undo
777 777
 	/**
778 778
 	 * check if path points to a files version
779 779
 	 *
780
-	 * @param $path
780
+	 * @param string $path
781 781
 	 * @return bool
782 782
 	 */
783 783
 	protected function isVersion($path) {
Please login to merge, or discard this patch.
apps/files_trashbin/lib/Trashbin.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -655,7 +655,7 @@  discard block
 block discarded – undo
655 655
 	 * if the size limit for the trash bin is reached, we delete the oldest
656 656
 	 * files in the trash bin until we meet the limit again
657 657
 	 *
658
-	 * @param array $files
658
+	 * @param \OCP\Files\FileInfo[] $files
659 659
 	 * @param string $user
660 660
 	 * @param int $availableSpace available disc space
661 661
 	 * @return int size of deleted files
@@ -683,7 +683,7 @@  discard block
 block discarded – undo
683 683
 	/**
684 684
 	 * delete files older then max storage time
685 685
 	 *
686
-	 * @param array $files list of files sorted by mtime
686
+	 * @param \OCP\Files\FileInfo[] $files list of files sorted by mtime
687 687
 	 * @param string $user
688 688
 	 * @return integer[] size of deleted files and number of deleted files
689 689
 	 */
Please login to merge, or discard this patch.
apps/federation/appinfo/application.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@
 block discarded – undo
30 30
 use OCA\Federation\Hooks;
31 31
 use OCA\Federation\Middleware\AddServerMiddleware;
32 32
 use OCA\Federation\SyncFederationAddressBooks;
33
-use OCA\Federation\SyncJob;
34 33
 use OCA\Federation\TrustedServers;
35 34
 use OCP\API;
36 35
 use OCP\App;
Please login to merge, or discard this patch.
apps/files/lib/Service/TagService.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,6 @@
 block discarded – undo
24 24
 
25 25
 namespace OCA\Files\Service;
26 26
 
27
-use OC\Files\FileInfo;
28 27
 use OCP\Files\Node;
29 28
 
30 29
 /**
Please login to merge, or discard this patch.
lib/private/legacy/template/functions.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
  * make preview_icon available as a simple function
184 184
  * Returns the path to the preview of the image.
185 185
  * @param string $path path of file
186
- * @return link to the preview
186
+ * @return string to the preview
187 187
  *
188 188
  * For further information have a look at OC_Helper::previewIcon
189 189
  */
@@ -193,6 +193,7 @@  discard block
 block discarded – undo
193 193
 
194 194
 /**
195 195
  * @param string $path
196
+ * @param string $token
196 197
  */
197 198
 function publicPreview_icon ( $path, $token ) {
198 199
 	return OC_Helper::publicPreviewIcon( $path, $token );
Please login to merge, or discard this patch.
lib/private/Template/Base.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -96,7 +96,7 @@
 block discarded – undo
96 96
 	/**
97 97
 	 * Appends a variable
98 98
 	 * @param string $key key
99
-	 * @param mixed $value value
99
+	 * @param string $value value
100 100
 	 * @return boolean|null
101 101
 	 *
102 102
 	 * This function assigns a variable in an array context. If the key already
Please login to merge, or discard this patch.
apps/federatedfilesharing/lib/FederatedShareProvider.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -463,7 +463,7 @@
 block discarded – undo
463 463
 	/**
464 464
 	 * get database row of a give share
465 465
 	 *
466
-	 * @param $id
466
+	 * @param integer $id
467 467
 	 * @return array
468 468
 	 * @throws ShareNotFound
469 469
 	 */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,6 @@
 block discarded – undo
25 25
 
26 26
 use OC\Share20\Share;
27 27
 use OCP\Files\IRootFolder;
28
-use OCP\IAppConfig;
29 28
 use OCP\IConfig;
30 29
 use OCP\IL10N;
31 30
 use OCP\ILogger;
Please login to merge, or discard this patch.