FutureFileZsync::isFutureFile() - Code Metrics - Inspection of "Merge pull request #29404 from ahmedammar/master" - owncloud/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ec6e3a...a32d5d )

by Thomas

created 2018-03-12 11:35 UTC

FutureFileZsync::isFutureFile() A

↳ Parent: FutureFileZsync

Complexity

Conditions	4
Paths	2

Size

Total Lines	12
Code Lines	7

Duplication

Lines	12
Ratio	100 %

Importance

Changes

Metric	Value
cc	4
eloc	7
nc	2
nop	0
dl	12
loc	12
rs	9.2
c	0
b	0
f	0

<?php
/*
 * Copyright (C) by Ahmed Ammar <[email protected]>
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated
 * documentation files (the "Software"), to deal in the Software without restriction, including without limitation the
 * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to
 * permit persons to whom the Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE
 * WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
 * COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
 * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 *
 */
namespace OCA\DAV\Upload;

use OCA\DAV\Connector\Sabre\Directory;
use Sabre\DAV\Exception\Forbidden;
use Sabre\DAV\IFile;

/**
 * Class FutureFileZsync
 *
 * The FutureFileZsync is a SabreDav IFile which connects the chunked upload directory
 * with the AssemblyStreamZsync, who does the final assembly job
 *
 * @package OCA\DAV\Upload
 */
class FutureFileZsync extends FutureFile {

	/** @var IFile */
	private $backingFile = null;
	/** @var string */
	private $fileLength = 0;

	static public function getFutureFileName() {
		return '.file.zsync';
	}

	static public function isFutureFile() {
		$davUploadsTarget = '/dav/uploads';

		// Check if pathinfo starts with dav uploads target and basename is future file basename
		if (isset($_SERVER['PATH_INFO'])
			&& pathinfo($_SERVER['PATH_INFO'], PATHINFO_BASENAME) === FutureFileZsync::getFutureFileName()
			&& (strpos($_SERVER['PATH_INFO'], $davUploadsTarget) === 0)) {
			return true;
		}

		return false;
	}

	/**
	 * @inheritdoc
	 */
	function get() {
		$nodes = $this->root->getChildren();
		return $this->root->childExists('.zsync') && $this->backingFile && $this->fileLength ?
			AssemblyStreamZsync::wrap($nodes, $this->backingFile, $this->fileLength) :
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			AssemblyStream::wrap($nodes);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
	}

	/**
	 * @param IFile $file
	 */
	function setBackingFile(IFile $file) {
		$this->backingFile = $file;
	}

	/**
	 * @param string $fileLength
	 */
	function setFileLength($fileLength) {
		$this->fileLength = $fileLength;
	}
}


1		<?php
2		/*
3		* Copyright (C) by Ahmed Ammar <[email protected]>
4		*
5		* Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated
6		* documentation files (the "Software"), to deal in the Software without restriction, including without limitation the
7		* rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to
8		* permit persons to whom the Software is furnished to do so, subject to the following conditions:
9		*
10		* The above copyright notice and this permission notice shall be included in all copies or substantial portions of the
11		* Software.
12		*
13		* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE
14		* WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
15		* COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
16		* OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
17		*
18		*/
19		namespace OCA\DAV\Upload;
20
21		use OCA\DAV\Connector\Sabre\Directory;
22		use Sabre\DAV\Exception\Forbidden;
23		use Sabre\DAV\IFile;
24
25		/**
26		* Class FutureFileZsync
27		*
28		* The FutureFileZsync is a SabreDav IFile which connects the chunked upload directory
29		* with the AssemblyStreamZsync, who does the final assembly job
30		*
31		* @package OCA\DAV\Upload
32		*/
33		class FutureFileZsync extends FutureFile {
34
35		/** @var IFile */
36		private $backingFile = null;
37		/** @var string */
38		private $fileLength = 0;
39
40		static public function getFutureFileName() {
41		return '.file.zsync';
42		}
43
44	View Code Duplication	static public function isFutureFile() {
45		$davUploadsTarget = '/dav/uploads';
46
47		// Check if pathinfo starts with dav uploads target and basename is future file basename
48		if (isset($_SERVER['PATH_INFO'])
49		&& pathinfo($_SERVER['PATH_INFO'], PATHINFO_BASENAME) === FutureFileZsync::getFutureFileName()
50		&& (strpos($_SERVER['PATH_INFO'], $davUploadsTarget) === 0)) {
51		return true;
52		}
53
54		return false;
55		}
56
57		/**
58		* @inheritdoc
59		*/
60		function get() {
61		$nodes = $this->root->getChildren();
62		return $this->root->childExists('.zsync') && $this->backingFile && $this->fileLength ?
63		AssemblyStreamZsync::wrap($nodes, $this->backingFile, $this->fileLength) :
		0 ignored issues – show Documentation introduced 2017-10-27 20:24 UTC by Report Bug Copy Issue Report `$nodes` is of type `array<integer,object<Sabre\DAV\INode>>`, but the function expects a `array<integer,object<Sabre\DAV\IFile>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
64		AssemblyStream::wrap($nodes);
		0 ignored issues – show Documentation introduced 2017-10-27 20:24 UTC by Report Bug Copy Issue Report `$nodes` is of type `array<integer,object<Sabre\DAV\INode>>`, but the function expects a `array<integer,object<Sabre\DAV\IFile>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
65		}
66
67		/**
68		* @param IFile $file
69		*/
70		function setBackingFile(IFile $file) {
71		$this->backingFile = $file;
72		}
73
74		/**
75		* @param string $fileLength
76		*/
77		function setFileLength($fileLength) {
78		$this->fileLength = $fileLength;
79		}
80		}
81

owncloud / core

Push — master ( ec6e3a...a32d5d )

FutureFileZsync::isFutureFile() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like