OCA\DAV\HookManager

Complexity

Total Complexity

37

Size/Duplication

Total Lines	194
Duplicated Lines	2.06 %

Coupling/Cohesion

Components	1
Dependencies	12

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	1
B	setup()	0	35	1
A	postCreateUser()	0	4	1
A	preDeleteUser()	0	6	1
A	postDeleteUser()	0	15	4
A	changeUser()	0	4	1
C	firstLogin()	0	24	8
D	deleteZsyncMetadata()	0	28	10
D	copyZsyncMetadata()	4	32	10

<?php
/**
 * @author Thomas Citharel <tcit@tcit.fr>
 * @author Thomas Müller <thomas.mueller@tmit.eu>
 *
 * @copyright Copyright (c) 2018, ownCloud GmbH
 * @license AGPL-3.0
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
 *
 */
namespace OCA\DAV;

use OCA\DAV\CalDAV\BirthdayService;
use OCA\DAV\CalDAV\CalDavBackend;
use OCA\DAV\CardDAV\CardDavBackend;
use OCA\DAV\CardDAV\SyncService;
use OCP\IL10N;
use OCP\IUser;
use OCP\User;
use OCP\IUserManager;
use OCP\Util;
use OC\Files\View;

class HookManager {

	/** @var IUserManager */
	private $userManager;

	/** @var SyncService */
	private $syncService;

	/** @var IUser[] */
	private $usersToDelete;

	/** @var CalDavBackend */
	private $calDav;

	/** @var CardDavBackend */
	private $cardDav;

	/** @var IL10N */
	private $l10n;

	/** @var array */
	private $calendarsToDelete;

	/** @var array */
	private $addressBooksToDelete;

	public function __construct(IUserManager $userManager,
								SyncService $syncService,
								CalDavBackend $calDav,
								CardDavBackend $cardDav,
								IL10N $l10n) {
		$this->userManager = $userManager;
		$this->syncService = $syncService;
		$this->calDav = $calDav;
		$this->cardDav = $cardDav;
		$this->l10n = $l10n;
	}

	public function setup() {
		Util::connectHook('OC_User',
			'post_createUser',
			$this,
			'postCreateUser');
		Util::connectHook('OC_User',
			'pre_deleteUser',
			$this,
			'preDeleteUser');
		Util::connectHook('OC_User',
			'post_deleteUser',
			$this,
			'postDeleteUser');
		Util::connectHook('OC_User',
			'changeUser',
			$this,
			'changeUser');

		Util::connectHook('OC_Filesystem',
			'post_copy',
			$this,
			'copyZsyncMetadata');
		Util::connectHook('OC_Filesystem',
			'write',
			$this,
			'deleteZsyncMetadata');
		Util::connectHook('OC_Filesystem',
			'delete',
			$this,
			'deleteZsyncMetadata');
		Util::connectHook('\OCP\Versions',
			'rollback',
			$this,
			'deleteZsyncMetadata');
	}

	public function postCreateUser($params) {
		$user = $this->userManager->get($params['uid']);
		$this->syncService->updateUser($user);

It seems like $user defined by $this->userManager->get($params['uid']) on line 110 can be null; however, OCA\DAV\CardDAV\SyncService::updateUser() does not accept null, maybe add an additional type check?

	}

	public function preDeleteUser($params) {
		$uid = $params['uid'];
		$this->usersToDelete[$uid] = $this->userManager->get($uid);
		$this->calendarsToDelete = $this->calDav->getUsersOwnCalendars('principals/users/' . $uid);
		$this->addressBooksToDelete = $this->cardDav->getUsersOwnAddressBooks('principals/users/' . $uid);
	}

	public function postDeleteUser($params) {
		$uid = $params['uid'];
		if (isset($this->usersToDelete[$uid])){
			$this->syncService->deleteUser($this->usersToDelete[$uid]);
		}

		foreach ($this->calendarsToDelete as $calendar) {
			$this->calDav->deleteCalendar($calendar['id']);
		}
		$this->calDav->deleteAllSharesForUser('principals/users/' . $uid);

		foreach ($this->addressBooksToDelete as $addressBook) {
			$this->cardDav->deleteAddressBook($addressBook['id']);
		}
	}

	public function changeUser($params) {
		$user = $params['user'];
		$this->syncService->updateUser($user);
	}

	public function firstLogin(IUser $user = null) {
		if (!is_null($user)) {
			$principal = 'principals/users/' . $user->getUID();
			$calendars = $this->calDav->getCalendarsForUser($principal);
			if (empty($calendars) || (count($calendars) === 1 && $calendars[0]['uri'] === BirthdayService::BIRTHDAY_CALENDAR_URI)) {
				try {
					$this->calDav->createCalendar($principal, 'personal', [
						'{DAV:}displayname' => $this->l10n->t('Personal'),
						'{http://apple.com/ns/ical/}calendar-color' => '#1d2d44']);
				} catch (\Exception $ex) {
					\OC::$server->getLogger()->logException($ex);
				}
			}
			$books = $this->cardDav->getAddressBooksForUser($principal);
			if (empty($books)) {
				try {
					$this->cardDav->createAddressBook($principal, 'contacts', [
						'{DAV:}displayname' => $this->l10n->t('Contacts')]);
				} catch (\Exception $ex) {
					\OC::$server->getLogger()->logException($ex);
				}
			}
		}
	}

	public function deleteZsyncMetadata($params) {
		$view = new View('/'.User::getUser());
		$path = $params[\OC\Files\Filesystem::signal_param_path];
		$path = 'files/' . ltrim($path, '/');

		/* if a file then just delete zsync metadata for file */
		if ($view->is_file($path)) {
			$info = $view->getFileInfo($path);
			if ($view->file_exists('files_zsync/'.$info->getId()))
				$view->unlink('files_zsync/'.$info->getId());
		} else if ($view->is_dir($path)) {
		/* if a folder then iteratively delete all zsync metadata for all files in folder, including subdirs */
			$array[] = $path;

$array was never initialized. Although not strictly required by PHP, it is generally a good practice to add $array = array(); before regardless.

			while (count($array)) {
				$current = array_pop($array);
				$handle = $view->opendir($current);
				while (($entry = readdir($handle)) !== false) {
					if($entry[0]!='.' and $view->is_dir($current.'/'.$entry)) {
						$array[] = $current.'/'.$entry;
					} else if ($view->is_file($current.'/'.$entry)) {
						$info = $view->getFileInfo($current.'/'.$entry);
						if ($view->file_exists('files_zsync/'.$info->getId()))
							$view->unlink('files_zsync/'.$info->getId());
					}
				}
			}
		}
	}

	public function copyZsyncMetadata($params) {
		$view = new View('/'.User::getUser());
		$from = $params[\OC\Files\Filesystem::signal_param_oldpath];
		$from = 'files/' . ltrim($from, '/');
		$to = $params[\OC\Files\Filesystem::signal_param_newpath];
		$to = 'files/' . ltrim($to, '/');

		/* if a file then just copy zsync metadata for file */
		if ($view->is_file($from)) {
			$info_from = $view->getFileInfo($from);
			$info_to = $view->getFileInfo($to);
			if ($view->file_exists('files_zsync/'.$info_from->getId()))

This code seems to be duplicated across your project.

				$view->copy('files_zsync/'.$info_from->getId(), 'files_zsync/'.$info_to->getId());
		} else if ($view->is_dir($from)) {
		/* if a folder then iteratively copy all zsync metadata for all files in folder, including subdirs */
			$array[] = [$from, $to];

$array was never initialized. Although not strictly required by PHP, it is generally a good practice to add $array = array(); before regardless.

			while (count($array)) {
				list($from_current, $to_current) = array_pop($array);
				$handle = $view->opendir($from_current);
				while (($entry = readdir($handle)) !== false) {
					if($entry[0]!='.' and $view->is_dir($from_current.'/'.$entry)) {
						$array[] = [$from_current.'/'.$entry, $to_current.'/'.$entry];
					} else if ($view->is_file($from_current.'/'.$entry)) {
						$info_from = $view->getFileInfo($from_current.'/'.$entry);
						$info_to = $view->getFileInfo($to_current.'/'.$entry);
						if ($view->file_exists('files_zsync/'.$info_from->getId()))

This code seems to be duplicated across your project.

							$view->copy('files_zsync/'.$info_from->getId(), 'files_zsync/'.$info_to->getId());
					}
				}
			}
		}
	}
}