Completed
Pull Request — master (#28256)
by Philipp
14:10
created
apps/dav/lib/Connector/Sabre/File.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -236,6 +236,9 @@  discard block
 block discarded – undo
236 236
 		return '"' . $this->info->getEtag() . '"';
237 237
 	}
238 238
 
239
+	/**
240
+	 * @param string $path
241
+	 */
239 242
 	private function getPartFileBasePath($path) {
240 243
 		$partFileInStorage = \OC::$server->getConfig()->getSystemValue('part_file_in_storage', true);
241 244
 		if ($partFileInStorage) {
@@ -598,7 +601,7 @@  discard block
 block discarded – undo
598 601
 	/**
599 602
 	 * Set $algo to get a specific checksum, leave null to get all checksums
600 603
 	 * (space seperated)
601
-	 * @param null $algo
604
+	 * @param string $algo
602 605
 	 * @return string
603 606
 	 */
604 607
 	public function getChecksum($algo = null) {
Please login to merge, or discard this patch.
apps/dav/appinfo/Migrations/Version20170202213905.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
 
29 29
 	/**
30 30
 	 * @param IDBConnection $connection
31
-	 * @return array
31
+	 * @return string[]
32 32
 	 */
33 33
 	public function sql(IDBConnection $connection) {
34 34
 		$qb = $connection->getQueryBuilder();
Please login to merge, or discard this patch.
lib/private/Files/Storage/Home.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@
 block discarded – undo
99 99
 	 * get the owner of a path
100 100
 	 *
101 101
 	 * @param string $path The path to get the owner
102
-	 * @return string uid or false
102
+	 * @return integer uid or false
103 103
 	 */
104 104
 	public function getOwner($path) {
105 105
 		return $this->user->getUID();
Please login to merge, or discard this patch.
lib/public/AppFramework/Db/Mapper.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -308,6 +308,7 @@
 block discarded – undo
308 308
 	 * @param array $params the parameters of the sql query
309 309
 	 * @param int $limit the maximum number of rows
310 310
 	 * @param int $offset from which row we want to start
311
+	 * @param string $msg
311 312
 	 * @return string formatted error message string
312 313
 	 * @since 9.1.0
313 314
 	 */
Please login to merge, or discard this patch.
lib/base.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -329,7 +329,7 @@
 block discarded – undo
329 329
 	/**
330 330
 	 * Checks if the version requires an update and shows
331 331
 	 * @param bool $showTemplate Whether an update screen should get shown
332
-	 * @return bool
332
+	 * @return null|boolean
333 333
 	 */
334 334
 	public static function checkUpgrade($showTemplate = true) {
335 335
 		if (\OCP\Util::needUpgrade()) {
Please login to merge, or discard this patch.
lib/private/User/Database.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -308,7 +308,7 @@
 block discarded – undo
308 308
 	/**
309 309
 	 * counts the users in the database
310 310
 	 *
311
-	 * @return int|bool
311
+	 * @return integer
312 312
 	 */
313 313
 	public function countUsers() {
314 314
 		$query = \OC_DB::prepare('SELECT COUNT(*) FROM `*PREFIX*users`');
Please login to merge, or discard this patch.
settings/Panels/Personal/Profile.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -26,11 +26,9 @@
 block discarded – undo
26 26
 
27 27
 use OCP\Settings\ISettings;
28 28
 use OCP\Template;
29
-use OCP\IUser;
30 29
 use OCP\IGroupManager;
31 30
 use OCP\IUserSession;
32 31
 use OCP\IConfig;
33
-use OC\Settings\Panels\Helper;
34 32
 use OCP\L10N\IFactory;
35 33
 
36 34
 class Profile implements ISettings {
Please login to merge, or discard this patch.
lib/private/Settings/SettingsManager.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -39,7 +39,6 @@  discard block
 block discarded – undo
39 39
 use OCP\IGroupManager;
40 40
 use OCP\Defaults;
41 41
 use OCP\IURLGenerator;
42
-
43 42
 use OC\Settings\Panels\Personal\Profile;
44 43
 use OC\Settings\Panels\Personal\Legacy as LegacyPersonal;
45 44
 use OC\Settings\Panels\Admin\Legacy as LegacyAdmin;
@@ -54,7 +53,6 @@  discard block
 block discarded – undo
54 53
 use OC\Settings\Panels\Admin\Mail;
55 54
 use OC\Settings\Panels\Admin\Logging;
56 55
 use OC\Settings\Panels\Admin\SecurityWarning;
57
-use OC\Settings\Panels\Admin\Updater;
58 56
 use OC\Settings\Panels\Admin\Tips;
59 57
 use OC\Settings\Panels\Admin\Status;
60 58
 
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/FilesReportPlugin.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@
 block discarded – undo
30 30
 use Sabre\DAV\ServerPlugin;
31 31
 use Sabre\DAV\Tree;
32 32
 use Sabre\DAV\Xml\Element\Response;
33
-use Sabre\DAV\Xml\Response\MultiStatus;
34 33
 use Sabre\DAV\PropFind;
35 34
 use OCP\SystemTag\ISystemTagObjectMapper;
36 35
 use OCP\IUserSession;
Please login to merge, or discard this patch.
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
 	 * This will be used in the {DAV:}supported-report-set property.
153 153
 	 *
154 154
 	 * @param string $uri
155
-	 * @return array
155
+	 * @return string[]
156 156
 	 */
157 157
 	public function getSupportedReportSet($uri) {
158 158
 		return [self::REPORT_NAME];
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
 	 * @param string $reportName
165 165
 	 * @param mixed $report
166 166
 	 * @param string $uri
167
-	 * @return bool
167
+	 * @return null|false
168 168
 	 * @throws BadRequest
169 169
 	 * @throws PreconditionFailed
170 170
 	 * @internal param $ [] $report
@@ -350,6 +350,7 @@  discard block
 block discarded – undo
350 350
 	 * with a leading slash but no trailing slash
351 351
 	 * @param string[] $requestedProps requested properties
352 352
 	 * @param Node[] nodes nodes for which to fetch and prepare responses
353
+	 * @param Node[] $nodes
353 354
 	 * @return Response[]
354 355
 	 */
355 356
 	public function prepareResponses($filesUri, $requestedProps, $nodes) {
Please login to merge, or discard this patch.