Completed
Pull Request — stable8.2 (#26169)
by Thomas
18:27
created
lib/private/app/platformrepository.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -206,6 +206,9 @@
 block discarded – undo
206 206
 		throw new \UnexpectedValueException('Invalid version string "' . $version . '"' . $extraMessage);
207 207
 	}
208 208
 
209
+	/**
210
+	 * @param string $stability
211
+	 */
209 212
 	private function expandStability($stability) {
210 213
 		$stability = strtolower($stability);
211 214
 		switch ($stability) {
Please login to merge, or discard this patch.
lib/private/appframework/utility/simplecontainer.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -113,7 +113,7 @@
 block discarded – undo
113 113
 
114 114
 	/**
115 115
 	 * @param string $name
116
-	 * @param mixed $value
116
+	 * @param string $value
117 117
 	 */
118 118
 	public function registerParameter($name, $value) {
119 119
 		$this[$name] = $value;
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -29,9 +29,7 @@
 block discarded – undo
29 29
 use ReflectionClass;
30 30
 use ReflectionException;
31 31
 use Closure;
32
-
33 32
 use Pimple\Container;
34
-
35 33
 use OCP\AppFramework\QueryException;
36 34
 use OCP\IContainer;
37 35
 
Please login to merge, or discard this patch.
lib/private/db/connection.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
 	 * If an SQLLogger is configured, the execution is logged.
168 168
 	 *
169 169
 	 * @param string                                      $query  The SQL query to execute.
170
-	 * @param array                                       $params The parameters to bind to the query, if any.
170
+	 * @param string[]                                       $params The parameters to bind to the query, if any.
171 171
 	 * @param array                                       $types  The types the previous parameters are in.
172 172
 	 * @param \Doctrine\DBAL\Cache\QueryCacheProfile|null $qcp    The query cache profile, optional.
173 173
 	 *
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
 	 * columns or sequences.
213 213
 	 *
214 214
 	 * @param string $seqName Name of the sequence object from which the ID should be returned.
215
-	 * @return string A string representation of the last inserted ID.
215
+	 * @return integer A string representation of the last inserted ID.
216 216
 	 */
217 217
 	public function lastInsertId($seqName = null)
218 218
 	{
Please login to merge, or discard this patch.
lib/private/db/migrator.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
 	protected $config;
53 53
 
54 54
 	/**
55
-	 * @param \Doctrine\DBAL\Connection $connection
55
+	 * @param Connection $connection
56 56
 	 * @param ISecureRandom $random
57 57
 	 * @param IConfig $config
58 58
 	 */
Please login to merge, or discard this patch.
lib/private/defaults.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -261,6 +261,9 @@
 block discarded – undo
261 261
 		return $footer;
262 262
 	}
263 263
 
264
+	/**
265
+	 * @param string $key
266
+	 */
264 267
 	public function buildDocLinkToKey($key) {
265 268
 		if ($this->themeExist('buildDocLinkToKey')) {
266 269
 			return $this->theme->buildDocLinkToKey($key);
Please login to merge, or discard this patch.
lib/private/diagnostics/querylogger.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
 	}
54 54
 
55 55
 	/**
56
-	 * @return \OCP\Diagnostics\IQuery[]
56
+	 * @return Query[]
57 57
 	 */
58 58
 	public function getQueries() {
59 59
 		return $this->queries;
Please login to merge, or discard this patch.
lib/private/eventsource.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@
 block discarded – undo
88 88
 	 * send a message to the client
89 89
 	 *
90 90
 	 * @param string $type
91
-	 * @param mixed $data
91
+	 * @param string $data
92 92
 	 *
93 93
 	 * @throws \BadMethodCallException
94 94
 	 * if only one parameter is given, a typeless message will be send with that parameter as data
Please login to merge, or discard this patch.
lib/private/files.php 1 patch
Doc Comments   +6 added lines, -4 removed lines patch added patch discarded remove patch
@@ -159,6 +159,8 @@  discard block
 block discarded – undo
159 159
 	/**
160 160
 	 * @param View $view
161 161
 	 * @param string $name
162
+	 * @param string $dir
163
+	 * @param boolean $onlyHeader
162 164
 	 */
163 165
 	private static function getSingleFile($view, $dir, $name, $onlyHeader) {
164 166
 		$filename = $dir . '/' . $name;
@@ -184,7 +186,7 @@  discard block
 block discarded – undo
184 186
 
185 187
 	/**
186 188
 	 * @param View $view
187
-	 * @param $dir
189
+	 * @param string $dir
188 190
 	 * @param string[]|string $files
189 191
 	 */
190 192
 	public static function lockFiles($view, $dir, $files) {
@@ -289,11 +291,11 @@  discard block
 block discarded – undo
289 291
 	}
290 292
 
291 293
 	/**
292
-	 * @param $dir
294
+	 * @param string $dir
293 295
 	 * @param $files
294
-	 * @param $getType
296
+	 * @param integer $getType
295 297
 	 * @param View $view
296
-	 * @param $filename
298
+	 * @param string $filename
297 299
 	 */
298 300
 	private static function unlockAllTheFiles($dir, $files, $getType, $view, $filename) {
299 301
 		if ($getType === self::FILE) {
Please login to merge, or discard this patch.
lib/private/files/fileinfo.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -185,7 +185,7 @@
 block discarded – undo
185 185
 	}
186 186
 
187 187
 	/**
188
-	 * @return \OCP\Files\FileInfo::TYPE_FILE|\OCP\Files\FileInfo::TYPE_FOLDER
188
+	 * @return string
189 189
 	 */
190 190
 	public function getType() {
191 191
 		if (!isset($this->data['type'])) {
Please login to merge, or discard this patch.