owncloud / core

apps/dav/lib/CalDAV/CalDavBackend.php

Doc Comments +7 added lines, -1 removed lines

@@ -270,6 +270,9 @@ 
 		return array_values($calendars);
 	}
 
+	/**
+	 * @param string $principalUri
+	 */
 	public function getUsersOwnCalendars($principalUri) {
 		$principalUri = $this->convertPrincipal($principalUri, true);
 		$fields = array_values($this->propertyMap);
@@ -1279,7 +1282,7 @@ 
 	 * @param string $principalUri
 	 * @param string $uri
 	 * @param array $properties
-	 * @return mixed
+	 * @return integer
 	 * @throws Forbidden
 	 */
 	function createSubscription($principalUri, $uri, array $properties) {
@@ -1685,6 +1688,9 @@ 
 		return $this->sharingBackend->applyShareAcl($resourceId, $acl);
 	}
 
+	/**
+	 * @param boolean $toV2
+	 */
 	private function convertPrincipal($principalUri, $toV2 = null) {
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
 			list(, $name) = URLUtil::splitPath($principalUri);

lib/private/User/Session.php

Doc Comments +8 added lines, -2 removed lines

@@ -323,7 +323,7 @@ 
 	 * @throws \InvalidArgumentException
 	 * @throws LoginException
 	 * @throws PasswordLoginForbiddenException
-	 * @return boolean
+	 * @return boolean|null
 	 */
 	public function logClientIn($user, $password, IRequest $request) {
 		$isTokenPassword = $this->isTokenPassword($password);
@@ -366,6 +366,9 @@ 
 		return $this->config->getSystemValue('token_auth_enforced', false);
 	}
 
+	/**
+	 * @param string $username
+	 */
 	protected function isTwoFactorEnforced($username) {
 		Util::emitHook(
 			'\OCA\Files_Sharing\API\Server2Server',
@@ -988,6 +991,9 @@ 
 		}
 	}
 
+	/**
+	 * @param IRequest $request
+	 */
 	public function verifyAuthHeaders($request) {
 		$shallLogout = false;
 		try {
@@ -1019,7 +1025,7 @@ 
 	}
 
 	/**
-	 * @param $includeBuiltIn
+	 * @param boolean $includeBuiltIn
 	 * @return \Generator | IAuthModule[]
 	 * @throws Exception
 	 */

lib/private/User/TokenAuthModule.php

Unused Use Statements -1 removed lines

@@ -30,7 +30,6 @@
 use OCP\Authentication\IAuthModule;
 use OCP\IRequest;
 use OCP\ISession;
-use OCP\IUser;
 use OCP\IUserManager;
 use OCP\Session\Exceptions\SessionNotAvailableException;
 

lib/private/Notification/Manager.php

Doc Comments +2 added lines

@@ -113,6 +113,8 @@
 	 * INTERNAL USE ONLY!! This method isn't part of the IManager interface
 	 * @internal This should only be used by the RegisterNotifierEventImpl (the real implementation).
 	 * Do NOT use this method outside as it might not work as expected.
+	 * @param string $id
+	 * @param string $name
 	 */
 	public function registerBuiltNotifier(INotifier $notifier, $id, $name) {
 		if (!isset($this->builtNotifiersHolder[$id]) && !isset($this->notifiersInfo[$id])) {

settings/Controller/CorsController.php

Doc Comments -1 removed lines

@@ -134,7 +134,6 @@
 	 * @NoAdminRequired
 	 * @NoSubadminRequired
 	 *
-	 * @param string $domain Domain to remove
 	 * @return RedirectResponse Redirection to the settings page.
 	 */
 	public function removeDomain($id) {

lib/private/App/AppManager.php

Doc Comments +5 added lines, -5 removed lines

@@ -143,7 +143,7 @@ 
 	/**
 	 * List all installed apps
 	 *
-	 * @return string[]
+	 * @return integer[]
 	 * @throws \Exception
 	 */
 	public function getInstalledApps() {
@@ -255,7 +255,7 @@ 
 	/**
 	 * Do not allow more than one active app-theme
 	 *
-	 * @param $appId
+	 * @param string $appId
 	 * @throws AppNotFoundException
 	 * @throws \InvalidArgumentException
 	 * @throws \Exception
@@ -529,7 +529,7 @@ 
 	}
 
 	/**
-	 * @param $appId
+	 * @param string $appId
 	 * @return bool
 	 * @throws \Exception
 	 */
@@ -565,7 +565,7 @@ 
 	/**
 	 * @param string $package package path
 	 * @param bool $skipMigrations whether to skip migrations, which would only install the code
-	 * @return string|false app id or false in case of error
+	 * @return integer app id or false in case of error
 	 * @since 10.0
 	 * @throws \Exception
 	 * @throws \Exception
@@ -580,7 +580,7 @@ 
 
 	/**
 	 * @param string $package
-	 * @return mixed
+	 * @return boolean
 	 * @since 10.0
 	 * @throws \Exception
 	 * @throws \Exception