Completed
Pull Request — master (#29747)
by Victor
09:06
created
lib/private/AllConfig.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -449,7 +449,7 @@
 block discarded – undo
449 449
 	 * In some environments the system config file is readonly. Find out if this
450 450
 	 * is the case.
451 451
 	 *
452
-	 * @return boolean
452
+	 * @return false|string
453 453
 	 * @since 10.0.3
454 454
 	 */
455 455
 	public function isSystemConfigReadOnly() {
Please login to merge, or discard this patch.
lib/private/DB/MySqlSchemaColumnDefinitionListener.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,6 @@
 block discarded – undo
22 22
 namespace OC\DB;
23 23
 
24 24
 use Doctrine\DBAL\DBALException;
25
-use Doctrine\DBAL\Driver\ServerInfoAwareConnection;
26 25
 use Doctrine\DBAL\Event\SchemaColumnDefinitionEventArgs;
27 26
 use Doctrine\DBAL\Platforms\MySqlPlatform;
28 27
 use Doctrine\DBAL\Schema\Column;
Please login to merge, or discard this patch.
lib/private/Files/Storage/Common.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -699,7 +699,7 @@
 block discarded – undo
699 699
 	}
700 700
 
701 701
 	/**
702
-	 * @param $internalPath
702
+	 * @param string $internalPath
703 703
 	 * @return array
704 704
 	 */
705 705
 	private function convertInternalPathToGlobalPath($internalPath) {
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/FilesPlugin.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,6 @@
 block discarded – undo
32 32
 
33 33
 use OC\AppFramework\Http\Request;
34 34
 use OCA\DAV\Files\IProvidesAdditionalHeaders;
35
-use OCA\DAV\Meta\MetaFile;
36 35
 use OCP\Files\ForbiddenException;
37 36
 use Sabre\DAV\Exception\Forbidden;
38 37
 use Sabre\DAV\Exception\NotFound;
Please login to merge, or discard this patch.
apps/files_versions/lib/Storage.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -310,6 +310,9 @@
 block discarded – undo
310 310
 	}
311 311
 
312 312
 
313
+	/**
314
+	 * @param string $revision
315
+	 */
313 316
 	public static function restoreVersion($uid, $filename, $fileToRestore, $revision) {
314 317
 		if(\OCP\Config::getSystemValue('files_versions', Storage::DEFAULTENABLED) !== true) {
315 318
 			return false;
Please login to merge, or discard this patch.
lib/private/App/AppManager.php 1 patch
Doc Comments   +7 added lines, -4 removed lines patch added patch discarded remove patch
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
 	/**
122 122
 	 * List all installed apps
123 123
 	 *
124
-	 * @return string[]
124
+	 * @return integer[]
125 125
 	 */
126 126
 	public function getInstalledApps() {
127 127
 		return array_keys($this->getInstalledAppsValues());
@@ -230,7 +230,7 @@  discard block
 block discarded – undo
230 230
 	/**
231 231
 	 * Do not allow more than one active app-theme
232 232
 	 *
233
-	 * @param $appId
233
+	 * @param string $appId
234 234
 	 * @throws \Exception
235 235
 	 */
236 236
 	protected function canEnableTheme($appId) {
@@ -389,6 +389,9 @@  discard block
 block discarded – undo
389 389
 		return in_array($appId, $this->shippedApps);
390 390
 	}
391 391
 
392
+	/**
393
+	 * @param string $appId
394
+	 */
392 395
 	private function isAlwaysEnabled($appId) {
393 396
 		$alwaysEnabled = $this->getAlwaysEnabledApps();
394 397
 		return in_array($appId, $alwaysEnabled);
@@ -417,7 +420,7 @@  discard block
 block discarded – undo
417 420
 	/**
418 421
 	 * @param string $package package path
419 422
 	 * @param bool $skipMigrations whether to skip migrations, which would only install the code
420
-	 * @return string|false app id or false in case of error
423
+	 * @return integer app id or false in case of error
421 424
 	 * @since 10.0
422 425
 	 */
423 426
 	public function installApp($package, $skipMigrations = false) {
@@ -430,7 +433,7 @@  discard block
 block discarded – undo
430 433
 
431 434
 	/**
432 435
 	 * @param string $package
433
-	 * @return mixed
436
+	 * @return boolean
434 437
 	 * @since 10.0
435 438
 	 */
436 439
 	public function updateApp($package) {
Please login to merge, or discard this patch.