Completed
Pull Request — master (#26426)
by Philipp
12:14
created
apps/files_external/lib/Lib/Backend/SMB.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@
 block discarded – undo
56 56
 	}
57 57
 
58 58
 	/**
59
-	 * @param StorageConfig $storage
59
+	 * @param IStorageConfig $storage
60 60
 	 * @param IUser $user
61 61
 	 */
62 62
 	public function manipulateStorageConfig(IStorageConfig &$storage, IUser $user = null) {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,6 @@
 block discarded – undo
27 27
 use OCP\Files\External\Backend\Backend;
28 28
 use OCP\Files\External\IStorageConfig;
29 29
 use OCA\Files_External\Lib\LegacyDependencyCheckPolyfill;
30
-
31 30
 use OCP\IUser;
32 31
 
33 32
 class SMB extends Backend {
Please login to merge, or discard this patch.
apps/dav/lib/DAV/PublicAuth.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@
 block discarded – undo
30 30
 	private $publicURLs;
31 31
 
32 32
 	/**
33
-	 * @param string[] $publicURLs
34 33
 	 */
35 34
 	public function __construct() {
36 35
 		$this->publicURLs = [
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Backend/AmazonS3.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -22,11 +22,9 @@
 block discarded – undo
22 22
 namespace OCA\Files_External\Lib\Backend;
23 23
 
24 24
 use OCP\IL10N;
25
-use OCP\Files\External\Auth\AuthMechanism;
26 25
 use OCP\Files\External\Backend\Backend;
27 26
 use OCP\Files\External\DefinitionParameter;
28 27
 use OCA\Files_External\Lib\LegacyDependencyCheckPolyfill;
29
-
30 28
 use OCA\Files_External\Lib\Auth\AmazonS3\AccessKey;
31 29
 
32 30
 class AmazonS3 extends Backend {
Please login to merge, or discard this patch.
lib/private/Repair/RepairUnmergedShares.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -207,7 +207,7 @@
 block discarded – undo
207 207
 	 * @param array $groupSharesById
208 208
 	 * @param array $subShares
209 209
 	 *
210
-	 * @return true if the share is valid, false if it needs repair
210
+	 * @return boolean if the share is valid, false if it needs repair
211 211
 	 */
212 212
 	private function isThisShareValid($groupSharesById, $subShares) {
213 213
 		$foundTargets = [];
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/QuotaPlugin.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -111,6 +111,9 @@
 block discarded – undo
111 111
 		return true;
112 112
 	}
113 113
 
114
+	/**
115
+	 * @param string[] $info
116
+	 */
114 117
 	public function getFileChunking($info) {
115 118
 		// FIXME: need a factory for better mocking support
116 119
 		return new \OC_FileChunking($info);
Please login to merge, or discard this patch.
apps/dav/lib/SystemTag/SystemTagsObjectMappingCollection.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -191,7 +191,7 @@
 block discarded – undo
191 191
 	 *
192 192
 	 * @param ISystemTag $tag
193 193
 	 *
194
-	 * @return SystemTagNode
194
+	 * @return SystemTagMappingNode
195 195
 	 */
196 196
 	private function makeNode(ISystemTag $tag) {
197 197
 		return new SystemTagMappingNode(
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,6 @@
 block discarded – undo
26 26
 use Sabre\DAV\Exception\BadRequest;
27 27
 use Sabre\DAV\Exception\PreconditionFailed;
28 28
 use Sabre\DAV\ICollection;
29
-
30 29
 use OCP\SystemTag\ISystemTagManager;
31 30
 use OCP\SystemTag\ISystemTagObjectMapper;
32 31
 use OCP\SystemTag\ISystemTag;
Please login to merge, or discard this patch.
lib/private/App/CodeChecker/CodeChecker.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -25,8 +25,6 @@
 block discarded – undo
25 25
 
26 26
 use OC\Hooks\BasicEmitter;
27 27
 use PhpParser\Lexer;
28
-use PhpParser\Node;
29
-use PhpParser\Node\Name;
30 28
 use PhpParser\NodeTraverser;
31 29
 use PhpParser\Parser;
32 30
 use RecursiveCallbackFilterIterator;
Please login to merge, or discard this patch.
lib/private/Console/TimestampFormatter.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@
 block discarded – undo
71 71
 	 * Checks if output formatter has style with specified name.
72 72
 	 *
73 73
 	 * @param string $name
74
-	 * @return bool
74
+	 * @return boolean|null
75 75
 	 */
76 76
 	public function hasStyle($name) {
77 77
 		$this->formatter->hasStyle($name);
Please login to merge, or discard this patch.
lib/private/DB/Adapter.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
 
44 44
 	/**
45 45
 	 * @param string $table name
46
-	 * @return int id of last insert statement
46
+	 * @return string id of last insert statement
47 47
 	 */
48 48
 	public function lastInsertId($table) {
49 49
 		return $this->conn->realLastInsertId($table);
Please login to merge, or discard this patch.