Completed
Pull Request — master (#26426)
by Philipp
12:14
created
apps/dav/lib/Connector/Sabre/File.php 1 patch
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -248,6 +248,9 @@  discard block
 block discarded – undo
248 248
 		return '"' . $this->info->getEtag() . '"';
249 249
 	}
250 250
 
251
+	/**
252
+	 * @param string $path
253
+	 */
251 254
 	private function getPartFileBasePath($path) {
252 255
 		$partFileInStorage = \OC::$server->getConfig()->getSystemValue('part_file_in_storage', true);
253 256
 		if ($partFileInStorage) {
@@ -617,7 +620,7 @@  discard block
 block discarded – undo
617 620
 	/**
618 621
 	 * Set $algo to get a specific checksum, leave null to get all checksums
619 622
 	 * (space seperated)
620
-	 * @param null $algo
623
+	 * @param string $algo
621 624
 	 * @return string
622 625
 	 */
623 626
 	public function getChecksum($algo = null) {
@@ -640,6 +643,9 @@  discard block
 block discarded – undo
640 643
 		return '';
641 644
 	}
642 645
 
646
+	/**
647
+	 * @param string $string
648
+	 */
643 649
 	protected function header($string) {
644 650
 		\header($string);
645 651
 	}
Please login to merge, or discard this patch.
settings/Application.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -31,10 +31,8 @@
 block discarded – undo
31 31
 
32 32
 namespace OC\Settings;
33 33
 
34
-use OC\Files\View;
35 34
 use OC\Server;
36 35
 use OC\AppFramework\Utility\TimeFactory;
37
-use OC\Settings\Controller\CorsController;
38 36
 use OC\Settings\Controller\SettingsPageController;
39 37
 use OC\Settings\Controller\AppSettingsController;
40 38
 use OC\Settings\Controller\AuthSettingsController;
Please login to merge, or discard this patch.
settings/Controller/CorsController.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -131,7 +131,6 @@
 block discarded – undo
131 131
 	/**
132 132
 	 * Removes a WhiteListed Domain
133 133
 	 *
134
-	 * @param string $domain Domain to remove
135 134
 	 * @return RedirectResponse Redirection to the settings page.
136 135
 	 */
137 136
 	public function removeDomain($id) {
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/CorsPlugin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@
 block discarded – undo
88 88
 	 * @param RequestInterface $request
89 89
 	 * @param ResponseInterface $response
90 90
 	 *
91
-	 * @return false
91
+	 * @return false|null
92 92
 	 */
93 93
 	public function setOptionsRequestHeaders(RequestInterface $request, ResponseInterface $response) {
94 94
 		$authorization = $request->getHeader('Authorization');
Please login to merge, or discard this patch.
apps/files_sharing/lib/API/Remote.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,6 @@
 block discarded – undo
24 24
 namespace OCA\Files_Sharing\API;
25 25
 
26 26
 use OC\Files\Filesystem;
27
-use OCA\FederatedFileSharing\DiscoveryManager;
28 27
 use OCA\Files_Sharing\External\Manager;
29 28
 use Symfony\Component\EventDispatcher\GenericEvent;
30 29
 
Please login to merge, or discard this patch.
lib/private/AppFramework/Middleware/Security/CORSMiddleware.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,6 @@
 block discarded – undo
27 27
 
28 28
 use OC\AppFramework\Middleware\Security\Exceptions\SecurityException;
29 29
 use OC\AppFramework\Utility\ControllerMethodReflector;
30
-use OC\Authentication\Exceptions\PasswordLoginForbiddenException;
31 30
 use OCP\AppFramework\Controller;
32 31
 use OCP\AppFramework\Http;
33 32
 use OCP\AppFramework\Http\JSONResponse;
Please login to merge, or discard this patch.
core/Command/Security/ListRoutes.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,6 @@
 block discarded – undo
23 23
 
24 24
 use OC\Core\Command\Base;
25 25
 use OC\Route\Router;
26
-use OCP\ICertificate;
27 26
 use OCP\Route\IRouter;
28 27
 use Symfony\Component\Console\Helper\Table;
29 28
 use Symfony\Component\Console\Input\InputInterface;
Please login to merge, or discard this patch.
apps/files_trashbin/lib/Trashbin.php 1 patch
Doc Comments   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -218,6 +218,9 @@  discard block
 block discarded – undo
218 218
 
219 219
 	/**
220 220
 	 *
221
+	 * @param string $targetFilename
222
+	 * @param string $targetLocation
223
+	 * @param integer $timestamp
221 224
 	 */
222 225
 	public static function insertTrashEntry($user, $targetFilename, $targetLocation, $timestamp) {
223 226
 		$query = \OC_DB::prepare("INSERT INTO `*PREFIX*files_trash` (`id`,`timestamp`,`location`,`user`) VALUES (?,?,?,?)");
@@ -330,6 +333,7 @@  discard block
 block discarded – undo
330 333
 	 * @param string $ownerPath path relative to the owner's home storage
331 334
 	 * @param integer $timestamp when the file was deleted
332 335
 	 * @param bool $forceCopy true to only make a copy of the versions into the trashbin
336
+	 * @param \OC\Files\Storage\Storage $sourceStorage
333 337
 	 */
334 338
 	private static function retainVersions($filename, $owner, $ownerPath, $timestamp, $sourceStorage = null, $forceCopy = false) {
335 339
 		if (\OCP\App::isEnabled('files_versions') && !empty($ownerPath)) {
@@ -780,7 +784,7 @@  discard block
 block discarded – undo
780 784
 	 * if the size limit for the trash bin is reached, we delete the oldest
781 785
 	 * files in the trash bin until we meet the limit again
782 786
 	 *
783
-	 * @param array $files
787
+	 * @param \OCP\Files\FileInfo[] $files
784 788
 	 * @param string $user
785 789
 	 * @param int $availableSpace available disc space
786 790
 	 * @return int size of deleted files
@@ -808,7 +812,7 @@  discard block
 block discarded – undo
808 812
 	/**
809 813
 	 * delete files older then max storage time
810 814
 	 *
811
-	 * @param array $files list of files sorted by mtime
815
+	 * @param \OCP\Files\FileInfo[] $files list of files sorted by mtime
812 816
 	 * @param string $user
813 817
 	 * @return integer[] size of deleted files and number of deleted files
814 818
 	 */
Please login to merge, or discard this patch.