Completed
Pull Request — master (#26426)
by Philipp
12:14
created
lib/private/App/AppManager.php 1 patch
Doc Comments   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
 	/**
123 123
 	 * List all installed apps
124 124
 	 *
125
-	 * @return string[]
125
+	 * @return integer[]
126 126
 	 */
127 127
 	public function getInstalledApps() {
128 128
 		return array_keys($this->getInstalledAppsValues());
@@ -355,6 +355,9 @@  discard block
 block discarded – undo
355 355
 		return in_array($appId, $this->shippedApps);
356 356
 	}
357 357
 
358
+	/**
359
+	 * @param string $appId
360
+	 */
358 361
 	private function isAlwaysEnabled($appId) {
359 362
 		$alwaysEnabled = $this->getAlwaysEnabledApps();
360 363
 		return in_array($appId, $alwaysEnabled);
@@ -383,7 +386,7 @@  discard block
 block discarded – undo
383 386
 	/**
384 387
 	 * @param string $package package path
385 388
 	 * @param bool $skipMigrations whether to skip migrations, which would only install the code
386
-	 * @return string|false app id or false in case of error
389
+	 * @return integer app id or false in case of error
387 390
 	 * @since 10.0
388 391
 	 */
389 392
 	public function installApp($package, $skipMigrations = false) {
@@ -400,7 +403,7 @@  discard block
 block discarded – undo
400 403
 
401 404
 	/**
402 405
 	 * @param string $package
403
-	 * @return mixed
406
+	 * @return boolean
404 407
 	 * @since 10.0
405 408
 	 */
406 409
 	public function updateApp($package) {
Please login to merge, or discard this patch.
lib/private/User/AccountMapper.php 1 patch
Doc Comments   +13 added lines, -2 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
 
43 43
 	/**
44 44
 	 * Delegate to term mapper to avoid needing to inject term mapper
45
-	 * @param $account_id
45
+	 * @param integer $account_id
46 46
 	 * @param array $terms
47 47
 	 */
48 48
 	public function setTermsForAccount($account_id, array $terms) {
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 
52 52
 	/**
53 53
 	 * Delegate to term mapper to avoid needing to inject term mapper
54
-	 * @param $account_id
54
+	 * @param integer $account_id
55 55
 	 * @return AccountTerm[] $terms
56 56
 	 */
57 57
 	public function findByAccountId($account_id) {
@@ -164,6 +164,9 @@  discard block
 block discarded – undo
164 164
 		return $this->findEntities($qb->getSQL(), $qb->getParameters(), $limit, $offset);
165 165
 	}
166 166
 
167
+	/**
168
+	 * @param boolean $hasLoggedIn
169
+	 */
167 170
 	public function getUserCountPerBackend($hasLoggedIn) {
168 171
 		$qb = $this->db->getQueryBuilder();
169 172
 		$qb->select(['backend', $qb->createFunction('count(*) as `count`')])
@@ -186,6 +189,9 @@  discard block
 block discarded – undo
186 189
 		return $return;
187 190
 	}
188 191
 
192
+	/**
193
+	 * @param boolean $hasLoggedIn
194
+	 */
189 195
 	public function getUserCount($hasLoggedIn) {
190 196
 		$qb = $this->db->getQueryBuilder();
191 197
 		$qb->select([$qb->createFunction('count(*) as `count`')])
@@ -202,6 +208,11 @@  discard block
 block discarded – undo
202 208
 		return (int) $data['count'];
203 209
 	}
204 210
 
211
+	/**
212
+	 * @param \Closure $callback
213
+	 * @param string $search
214
+	 * @param boolean $onlySeen
215
+	 */
205 216
 	public function callForAllUsers($callback, $search, $onlySeen) {
206 217
 		$qb = $this->db->getQueryBuilder();
207 218
 		$qb->select(['*'])
Please login to merge, or discard this patch.
lib/private/DB/QueryBuilder/ExpressionBuilder/ExpressionBuilder.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -361,7 +361,7 @@  discard block
 block discarded – undo
361 361
 	 *
362 362
 	 * @param string $column
363 363
 	 * @param mixed $type One of IQueryBuilder::PARAM_*
364
-	 * @return string
364
+	 * @return QueryFunction
365 365
 	 */
366 366
 	public function castColumn($column, $type) {
367 367
 		return new QueryFunction(
@@ -372,7 +372,7 @@  discard block
 block discarded – undo
372 372
 	/**
373 373
 	 * Returns a query function to find the number of characters in a string column
374 374
 	 * @param string $column
375
-	 * @return string
375
+	 * @return QueryFunction
376 376
 	 */
377 377
 	public function length($column) {
378 378
 		$column = $this->helper->quoteColumnName($column);
Please login to merge, or discard this patch.
apps/provisioning_api/lib/Users.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -449,7 +449,7 @@
 block discarded – undo
449 449
 	 * @param IUser $user user to check access
450 450
 	 * @param IGroup|null $group group to check or null
451 451
 	 *
452
-	 * @return true if the user can manage the group
452
+	 * @return boolean if the user can manage the group
453 453
 	 */
454 454
 	private function canUserManageGroup($user, $group) {
455 455
 		if ($this->groupManager->isAdmin($user->getUID())) {
Please login to merge, or discard this patch.
lib/private/User/User.php 1 patch
Doc Comments   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 	 *
73 73
 	 * @param Account $account
74 74
 	 * @param AccountMapper $mapper
75
-	 * @param null $emitter
75
+	 * @param Manager $emitter
76 76
 	 * @param IConfig|null $config
77 77
 	 * @param null $urlGenerator
78 78
 	 * @param EventDispatcher|null $eventDispatcher
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
 	/**
98 98
 	 * get the user id
99 99
 	 *
100
-	 * @return string
100
+	 * @return integer
101 101
 	 */
102 102
 	public function getUID() {
103 103
 		return $this->account->getUserId();
@@ -433,6 +433,10 @@  discard block
 block discarded – undo
433 433
 		return $url;
434 434
 	}
435 435
 
436
+	/**
437
+	 * @param string $feature
438
+	 * @param string $value
439
+	 */
436 440
 	public function triggerChange($feature, $value = null) {
437 441
 		if ($this->emitter && in_array($feature, $this->account->getUpdatedFields())) {
438 442
 			$this->emitter->emit('\OC\User', 'changeUser', [$this, $feature, $value]);
Please login to merge, or discard this patch.
lib/private/DB/MigrationService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -361,7 +361,7 @@
 block discarded – undo
361 361
 
362 362
 	/**
363 363
 	 * @param string $version
364
-	 * @return mixed
364
+	 * @return \Doctrine\DBAL\Schema\Schema
365 365
 	 * @throws \Exception
366 366
 	 */
367 367
 	protected function createInstance($version) {
Please login to merge, or discard this patch.
lib/private/legacy/template.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -319,6 +319,7 @@
 block discarded – undo
319 319
 		* @param string $error_msg The error message to show
320 320
 		* @param string $hint An optional hint message - needs to be properly escaped
321 321
 		* @param int HTTP Status Code
322
+		* @param integer $httpStatusCode
322 323
 		*/
323 324
 	public static function printErrorPage( $error_msg, $hint = '', $httpStatusCode = null ) {
324 325
 		if ($error_msg === $hint) {
Please login to merge, or discard this patch.
apps/dav/lib/Upload/ChunkingPlugin.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@
 block discarded – undo
90 90
 	 *
91 91
 	 * @param string $path source path
92 92
 	 * @param string $destination destination path
93
-	 * @return bool|void false to stop handling, void to skip this handler
93
+	 * @return null|false false to stop handling, void to skip this handler
94 94
 	 */
95 95
 	public function performMove($path, $destination) {
96 96
 		if (!$this->server->tree->nodeExists($destination)) {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,6 @@
 block discarded – undo
23 23
 namespace OCA\DAV\Upload;
24 24
 
25 25
 
26
-use OCA\DAV\Connector\Sabre\File;
27 26
 use Sabre\DAV\Exception\BadRequest;
28 27
 use Sabre\DAV\Server;
29 28
 use Sabre\DAV\ServerPlugin;
Please login to merge, or discard this patch.
lib/private/L10N/L10N.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -171,7 +171,7 @@
 block discarded – undo
171 171
 	 * Returns an associative array with all translations
172 172
 	 *
173 173
 	 * Called by String
174
-	 * @return array
174
+	 * @return string[]
175 175
 	 */
176 176
 	public function getTranslations() {
177 177
 		return $this->translations;
Please login to merge, or discard this patch.