Completed
Pull Request — master (#26426)
by Philipp
12:14
created
lib/private/DB/Migrator.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -235,6 +235,10 @@
 block discarded – undo
235 235
 		return '/^' . preg_quote($this->config->getSystemValue('dbtableprefix', 'oc_')) . '/';
236 236
 	}
237 237
 
238
+	/**
239
+	 * @param integer $step
240
+	 * @param integer $max
241
+	 */
238 242
 	protected function emit($sql, $step, $max) {
239 243
 		if ($this->noEmit) {
240 244
 			return;
Please login to merge, or discard this patch.
lib/private/Share20/DefaultShareProvider.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1051,7 +1051,7 @@
 block discarded – undo
1051 1051
 	/**
1052 1052
 	 * Check whether the share object fits the expectations of this provider
1053 1053
 	 *
1054
-	 * @param IShare $share share
1054
+	 * @param \OCP\Share\IShare $share share
1055 1055
 	 *
1056 1056
 	 * @throws InvalidArgumentException if the share validation failed
1057 1057
 	 */
Please login to merge, or discard this patch.
lib/private/Files/Stream/Checksum.php 1 patch
Doc Comments   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -64,8 +64,8 @@  discard block
 block discarded – undo
64 64
 
65 65
 
66 66
 	/**
67
-	 * @param $source
68
-	 * @param $path
67
+	 * @param resource $source
68
+	 * @param string $path
69 69
 	 * @return resource
70 70
 	 */
71 71
 	public static function wrap($source, $path) {
@@ -126,6 +126,9 @@  discard block
 block discarded – undo
126 126
 		return parent::stream_write($data);
127 127
 	}
128 128
 
129
+	/**
130
+	 * @param string $data
131
+	 */
129 132
 	private function updateHashingContexts($data) {
130 133
 		foreach ($this->hashingContexts as $ctx) {
131 134
 			hash_update($ctx, $data);
@@ -194,7 +197,7 @@  discard block
 block discarded – undo
194 197
 	}
195 198
 
196 199
 	/**
197
-	 * @return mixed
200
+	 * @return string
198 201
 	 * @return string
199 202
 	 */
200 203
 	private function getPathFromStreamContext() {
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/ObjectTree.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,6 @@
 block discarded – undo
31 31
 use OCA\DAV\Connector\Sabre\Exception\InvalidPath;
32 32
 use OCA\DAV\Connector\Sabre\Exception\FileLocked;
33 33
 use OC\Files\FileInfo;
34
-use OC\Files\Mount\MoveableMount;
35 34
 use OCP\Files\ForbiddenException;
36 35
 use OCP\Files\StorageInvalidException;
37 36
 use OCP\Files\StorageNotAvailableException;
Please login to merge, or discard this patch.
lib/public/Files.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@
 block discarded – undo
66 66
 	/**
67 67
 	 * Search for files by mimetype
68 68
 	 * @param string $mimetype
69
-	 * @return array
69
+	 * @return \OC\Files\FileInfo[]
70 70
 	 * @since 6.0.0
71 71
 	 */
72 72
 	static public function searchByMime( $mimetype ) {
Please login to merge, or discard this patch.
lib/private/Theme/ThemeService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@
 block discarded – undo
125 125
 	}
126 126
 
127 127
 	/**
128
-	 * @param $themeName
128
+	 * @param string $themeName
129 129
 	 * @param bool $appTheme
130 130
 	 * @return false|string
131 131
 	 */
Please login to merge, or discard this patch.
apps/dav/lib/Connector/LegacyDAVACL.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -49,6 +49,10 @@
 block discarded – undo
49 49
 		);
50 50
 	}
51 51
 
52
+	/**
53
+	 * @param string $principal
54
+	 * @param boolean $toV2
55
+	 */
52 56
 	private function convertPrincipal($principal, $toV2) {
53 57
 		list(, $name) = URLUtil::splitPath($principal);
54 58
 		if ($toV2) {
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/CalDavBackend.php 1 patch
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -267,6 +267,9 @@  discard block
 block discarded – undo
267 267
 		return array_values($calendars);
268 268
 	}
269 269
 
270
+	/**
271
+	 * @param string $principalUri
272
+	 */
270 273
 	public function getUsersOwnCalendars($principalUri) {
271 274
 		$principalUri = $this->convertPrincipal($principalUri, true);
272 275
 		$fields = array_values($this->propertyMap);
@@ -1262,7 +1265,7 @@  discard block
 block discarded – undo
1262 1265
 	 * @param string $principalUri
1263 1266
 	 * @param string $uri
1264 1267
 	 * @param array $properties
1265
-	 * @return mixed
1268
+	 * @return integer
1266 1269
 	 */
1267 1270
 	function createSubscription($principalUri, $uri, array $properties) {
1268 1271
 
@@ -1665,6 +1668,9 @@  discard block
 block discarded – undo
1665 1668
 		return $this->sharingBackend->applyShareAcl($resourceId, $acl);
1666 1669
 	}
1667 1670
 
1671
+	/**
1672
+	 * @param boolean $toV2
1673
+	 */
1668 1674
 	private function convertPrincipal($principalUri, $toV2 = null) {
1669 1675
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
1670 1676
 			list(, $name) = URLUtil::splitPath($principalUri);
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/CardDavBackend.php 1 patch
Doc Comments   +8 added lines, -3 removed lines patch added patch discarded remove patch
@@ -214,7 +214,8 @@  discard block
 block discarded – undo
214 214
 	}
215 215
 
216 216
 	/**
217
-	 * @param $addressBookUri
217
+	 * @param string $addressBookUri
218
+	 * @param string $principal
218 219
 	 * @return array|null
219 220
 	 */
220 221
 	public function getAddressBooksByUri($principal, $addressBookUri) {
@@ -896,6 +897,7 @@  discard block
 block discarded – undo
896 897
 	 *   * readOnly - boolean
897 898
 	 *   * summary - Optional, a description for the share
898 899
 	 *
900
+	 * @param integer $addressBookId
899 901
 	 * @return array
900 902
 	 */
901 903
 	public function getShares($addressBookId) {
@@ -949,7 +951,7 @@  discard block
 block discarded – undo
949 951
 	 * read vCard data into a vCard object
950 952
 	 *
951 953
 	 * @param string $cardData
952
-	 * @return VCard
954
+	 * @return \Sabre\VObject\Parser\Sabre\VObject\Document|null
953 955
 	 */
954 956
 	protected function readCard($cardData) {
955 957
 		return  Reader::read($cardData);
@@ -995,7 +997,7 @@  discard block
 block discarded – undo
995 997
 
996 998
 	/**
997 999
 	 * For shared address books the sharee is set in the ACL of the address book
998
-	 * @param $addressBookId
1000
+	 * @param integer $addressBookId
999 1001
 	 * @param $acl
1000 1002
 	 * @return array
1001 1003
 	 */
@@ -1003,6 +1005,9 @@  discard block
 block discarded – undo
1003 1005
 		return $this->sharingBackend->applyShareAcl($addressBookId, $acl);
1004 1006
 	}
1005 1007
 
1008
+	/**
1009
+	 * @param boolean $toV2
1010
+	 */
1006 1011
 	private function convertPrincipal($principalUri, $toV2 = null) {
1007 1012
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
1008 1013
 			list(, $name) = URLUtil::splitPath($principalUri);
Please login to merge, or discard this patch.