Completed
Pull Request — master (#26426)
by Philipp
12:14
created
lib/private/legacy/template/functions.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
  * make preview_icon available as a simple function
183 183
  * Returns the path to the preview of the image.
184 184
  * @param string $path path of file
185
- * @return link to the preview
185
+ * @return string to the preview
186 186
  */
187 187
 function preview_icon( $path ) {
188 188
 	return \OC::$server->getURLGenerator()->linkToRoute('core_ajax_preview', ['x' => 32, 'y' => 32, 'file' => $path]);
@@ -190,6 +190,7 @@  discard block
 block discarded – undo
190 190
 
191 191
 /**
192 192
  * @param string $path
193
+ * @param string $token
193 194
  */
194 195
 function publicPreview_icon ( $path, $token ) {
195 196
 	return \OC::$server->getURLGenerator()->linkToRoute('core_ajax_public_preview', ['x' => 32, 'y' => 32, 'file' => $path, 't' => $token]);
Please login to merge, or discard this patch.
lib/private/Memcache/APC.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@
 block discarded – undo
64 64
 	 * Set a value in the cache if it's not already stored
65 65
 	 *
66 66
 	 * @param string $key
67
-	 * @param mixed $value
67
+	 * @param integer $value
68 68
 	 * @param int $ttl Time To Live in seconds. Defaults to 60*60*24
69 69
 	 * @return bool
70 70
 	 */
Please login to merge, or discard this patch.
lib/private/Memcache/APCu.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@
 block discarded – undo
64 64
 	 * Set a value in the cache if it's not already stored
65 65
 	 *
66 66
 	 * @param string $key
67
-	 * @param mixed $value
67
+	 * @param integer $value
68 68
 	 * @param int $ttl Time To Live in seconds. Defaults to 60*60*24
69 69
 	 * @return bool
70 70
 	 */
Please login to merge, or discard this patch.
lib/private/Memcache/ArrayCache.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@
 block discarded – undo
64 64
 	 * Set a value in the cache if it's not already stored
65 65
 	 *
66 66
 	 * @param string $key
67
-	 * @param mixed $value
67
+	 * @param integer $value
68 68
 	 * @param int $ttl Time To Live in seconds. Defaults to 60*60*24
69 69
 	 * @return bool
70 70
 	 */
Please login to merge, or discard this patch.
lib/private/Memcache/Memcached.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -158,7 +158,7 @@
 block discarded – undo
158 158
 	 * Set a value in the cache if it's not already stored
159 159
 	 *
160 160
 	 * @param string $key
161
-	 * @param mixed $value
161
+	 * @param integer $value
162 162
 	 * @param int $ttl Time To Live in seconds. Defaults to 60*60*24
163 163
 	 * @return bool
164 164
 	 * @throws \Exception
Please login to merge, or discard this patch.
lib/private/Security/CredentialsManager.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,6 @@
 block discarded – undo
24 24
 use OCP\Security\ICrypto;
25 25
 use OCP\IDBConnection;
26 26
 use OCP\Security\ICredentialsManager;
27
-use OCP\IConfig;
28 27
 
29 28
 /**
30 29
  * Store and retrieve credentials for external services
Please login to merge, or discard this patch.
lib/private/Server.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1166,7 +1166,7 @@
 block discarded – undo
1166 1166
 	 * Get the certificate manager for the user
1167 1167
 	 *
1168 1168
 	 * @param string $userId (optional) if not specified the current loggedin user is used, use null to get the system certificate manager
1169
-	 * @return \OCP\ICertificateManager | null if $uid is null and no user is logged in
1169
+	 * @return null|CertificateManager | null if $uid is null and no user is logged in
1170 1170
 	 */
1171 1171
 	public function getCertificateManager($userId = '') {
1172 1172
 		if ($userId === '') {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -46,8 +46,6 @@
 block discarded – undo
46 46
 use OC\AppFramework\Utility\TimeFactory;
47 47
 use OC\Command\AsyncBus;
48 48
 use OC\Diagnostics\EventLogger;
49
-use OC\Diagnostics\NullEventLogger;
50
-use OC\Diagnostics\NullQueryLogger;
51 49
 use OC\Diagnostics\QueryLogger;
52 50
 use OC\Files\Config\UserMountCache;
53 51
 use OC\Files\Config\UserMountCacheListener;
Please login to merge, or discard this patch.
lib/private/Tags.php 1 patch
Doc Comments   +10 added lines, -2 removed lines patch added patch discarded remove patch
@@ -742,11 +742,19 @@  discard block
 block discarded – undo
742 742
 	}
743 743
 
744 744
 	// case-insensitive array_search
745
+
746
+	/**
747
+	 * @param string $needle
748
+	 */
745 749
 	protected function array_searchi($needle, $haystack, $mem='getName') {
746 750
 		if(!is_array($haystack)) {
747 751
 			return false;
748 752
 		}
749 753
 		return array_search(strtolower($needle), array_map(
754
+
755
+			/**
756
+			 * @param string $tag
757
+			 */
750 758
 			function($tag) use($mem) {
751 759
 				return strtolower(call_user_func([$tag, $mem]));
752 760
 			}, $haystack)
@@ -771,7 +779,7 @@  discard block
 block discarded – undo
771 779
 	* Get a tag by its name.
772 780
 	*
773 781
 	* @param string $name The tag name.
774
-	* @return integer|bool The tag object's offset within the $this->tags
782
+	* @return \OCP\AppFramework\Db\Entity The tag object's offset within the $this->tags
775 783
 	*                      array or false if it doesn't exist.
776 784
 	*/
777 785
 	private function getTagByName($name) {
@@ -782,7 +790,7 @@  discard block
 block discarded – undo
782 790
 	* Get a tag by its ID.
783 791
 	*
784 792
 	* @param string $id The tag ID to look for.
785
-	* @return integer|bool The tag object's offset within the $this->tags
793
+	* @return \OCP\AppFramework\Db\Entity The tag object's offset within the $this->tags
786 794
 	*                      array or false if it doesn't exist.
787 795
 	*/
788 796
 	private function getTagById($id) {
Please login to merge, or discard this patch.
lib/public/Files/StorageAuthException.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@
 block discarded – undo
30 30
 	 * StorageAuthException constructor.
31 31
 	 *
32 32
 	 * @param string $message
33
-	 * @param int $code
34 33
 	 * @param \Exception $previous
35 34
 	 * @since 9.0.0
36 35
 	 */
Please login to merge, or discard this patch.