Completed
Pull Request — master (#24439)
by Roeland
12:23
created
lib/private/Repair/InnoDB.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
 	}
54 54
 
55 55
 	/**
56
-	 * @param \Doctrine\DBAL\Connection $connection
56
+	 * @param \OCP\IDBConnection $connection
57 57
 	 * @return string[]
58 58
 	 */
59 59
 	private function getAllMyIsamTables($connection) {
Please login to merge, or discard this patch.
lib/public/migration/ioutput.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,26 +24,30 @@
 block discarded – undo
24 24
 
25 25
 	/**
26 26
 	 * @param string $message
27
+	 * @return void
27 28
 	 */
28 29
 	public function info($message);
29 30
 
30 31
 	/**
31 32
 	 * @param string $message
33
+	 * @return void
32 34
 	 */
33 35
 	public function warning($message);
34 36
 
35 37
 	/**
36 38
 	 * @param int $max
39
+	 * @return void
37 40
 	 */
38 41
 	public function startProgress($max = 0);
39 42
 
40 43
 	/**
41 44
 	 * @param int $step
45
+	 * @return void
42 46
 	 */
43 47
 	public function advance($step = 1);
44 48
 
45 49
 	/**
46
-	 * @param int $max
50
+	 * @return void
47 51
 	 */
48 52
 	public function finishProgress();
49 53
 
Please login to merge, or discard this patch.
lib/private/AppFramework/Http.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -110,7 +110,7 @@
 block discarded – undo
110 110
 
111 111
 	/**
112 112
 	 * Gets the correct header
113
-	 * @param Http::CONSTANT $status the constant from the Http class
113
+	 * @param integer $status the constant from the Http class
114 114
 	 * @param \DateTime $lastModified formatted last modified date
115 115
 	 * @param string $ETag the etag
116 116
 	 * @return string
Please login to merge, or discard this patch.
lib/private/AppFramework/Utility/ControllerMethodReflector.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
 
47 47
 
48 48
 	/**
49
-	 * @param object $object an object or classname
49
+	 * @param \OCP\AppFramework\Controller $object an object or classname
50 50
 	 * @param string $method the method which we want to inspect
51 51
 	 */
52 52
 	public function reflect($object, $method){
Please login to merge, or discard this patch.
lib/private/Encryption/Util.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@
 block discarded – undo
30 30
 use OC\Files\Filesystem;
31 31
 use OC\Files\View;
32 32
 use OCP\Encryption\IEncryptionModule;
33
-use OCP\Files\Storage;
34 33
 use OCP\IConfig;
35 34
 
36 35
 class Util {
Please login to merge, or discard this patch.
lib/private/Files/Cache/Cache.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -144,6 +144,9 @@
 block discarded – undo
144 144
 		return true;
145 145
 	}
146 146
 
147
+	/**
148
+	 * @param string $path
149
+	 */
147 150
 	public function url_stat($path) {
148 151
 		if (isset(self::$data[$path])) {
149 152
 			$size = strlen(self::$data[$path]);
Please login to merge, or discard this patch.
lib/private/Files/Cache/Scanner.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -465,6 +465,9 @@
 block discarded – undo
465 465
 		}
466 466
 	}
467 467
 
468
+	/**
469
+	 * @param string|boolean $path
470
+	 */
468 471
 	private function runBackgroundScanJob(callable $callback, $path) {
469 472
 		try {
470 473
 			$callback();
Please login to merge, or discard this patch.
lib/private/Files/Cache/Wrapper/CacheJail.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
 
68 68
 	/**
69 69
 	 * @param array $entry
70
-	 * @return array
70
+	 * @return string
71 71
 	 */
72 72
 	protected function formatCacheEntry($entry) {
73 73
 		if (isset($entry['path'])) {
@@ -185,6 +185,9 @@  discard block
 block discarded – undo
185 185
 		return $this->cache->getStatus($this->getSourcePath($file));
186 186
 	}
187 187
 
188
+	/**
189
+	 * @param \OCP\Files\Cache\ICacheEntry[] $results
190
+	 */
188 191
 	private function formatSearchResults($results) {
189 192
 		$results = array_filter($results, array($this, 'filterCacheEntry'));
190 193
 		$results = array_values($results);
@@ -263,7 +266,7 @@  discard block
 block discarded – undo
263 266
 	 * use the one with the highest id gives the best result with the background scanner, since that is most
264 267
 	 * likely the folder where we stopped scanning previously
265 268
 	 *
266
-	 * @return string|bool the path of the folder or false when no folder matched
269
+	 * @return boolean the path of the folder or false when no folder matched
267 270
 	 */
268 271
 	public function getIncomplete() {
269 272
 		// not supported
Please login to merge, or discard this patch.
lib/private/Files/Config/UserMountCache.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -206,7 +206,7 @@
 block discarded – undo
206 206
 	}
207 207
 
208 208
 	/**
209
-	 * @param $fileId
209
+	 * @param integer $fileId
210 210
 	 * @return array
211 211
 	 * @throws \OCP\Files\NotFoundException
212 212
 	 */
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -21,14 +21,11 @@
 block discarded – undo
21 21
 
22 22
 namespace OC\Files\Config;
23 23
 
24
-use Doctrine\DBAL\Exception\UniqueConstraintViolationException;
25
-use OC\Files\Filesystem;
26 24
 use OCP\DB\QueryBuilder\IQueryBuilder;
27 25
 use OCP\Files\Config\ICachedMountInfo;
28 26
 use OCP\Files\Config\IUserMountCache;
29 27
 use OCP\Files\Mount\IMountPoint;
30 28
 use OCP\Files\NotFoundException;
31
-use OCP\ICache;
32 29
 use OCP\IDBConnection;
33 30
 use OCP\ILogger;
34 31
 use OCP\IUser;
Please login to merge, or discard this patch.