owncloud / core

apps/user_ldap/command/setconfig.php

Doc Comments -2 removed lines

@@ -73,8 +73,6 @@
 	/**
 	 * save the configuration value as provided
 	 * @param string $configID
-	 * @param string $configKey
-	 * @param string $configValue
 	 */
 	protected function setValue($configID, $key, $value) {
 		$configHolder = new Configuration($configID);

apps/user_ldap/lib/access.php

Doc Comments +9 added lines, -7 removed lines

@@ -390,7 +390,7 @@ 
 
 	/**
 	 * returns the internal ownCloud name for the given LDAP DN of the user, false on DN outside of search DN or failure
-	 * @param string $dn the dn of the user object
+	 * @param string $fdn the dn of the user object
 	 * @param string $ldapName optional, the display name of the object
 	 * @return string|false with with the name to use in ownCloud
 	 */
@@ -407,7 +407,7 @@ 
 
 	/**
 	 * returns an internal ownCloud name for the given LDAP DN, false on DN outside of search DN
-	 * @param string $dn the dn of the user object
+	 * @param string $fdn the dn of the user object
 	 * @param string $ldapName optional, the display name of the object
 	 * @param bool $isUser optional, whether it is a user object (otherwise group assumed)
 	 * @return string|false with with the name to use in ownCloud
@@ -662,7 +662,7 @@ 
 	 * the login filter.
 	 *
 	 * @param string $loginName
-	 * @param array $attributes optional, list of attributes to read
+	 * @param string[] $attributes optional, list of attributes to read
 	 * @return array
 	 */
 	public function fetchUsersByLoginName($loginName, $attributes = array('dn')) {
@@ -768,7 +768,7 @@ 
 
 	/**
 	 * @param string $filter
-	 * @param string|string[] $attr
+	 * @param string[] $attr
 	 * @param int $limit
 	 * @param int $offset
 	 * @return false|int
@@ -818,6 +818,7 @@ 
 	 * retrieved. Results will according to the order in the array.
 	 * @param int $limit optional, maximum results to be counted
 	 * @param int $offset optional, a starting point
+	 * @param string $filter
 	 * @return array|false array with the search result as first value and pagedSearchOK as
 	 * second | false if not successful
 	 */
@@ -1059,7 +1060,7 @@ 
 
 	/**
 	 * @param string $name
-	 * @return bool|mixed|string
+	 * @return string
 	 */
 	public function sanitizeUsername($name) {
 		if($this->connection->ldapIgnoreNamingRules) {
@@ -1083,6 +1084,7 @@ 
 	* escapes (user provided) parts for LDAP filter
 	* @param string $input, the provided value
 	* @param bool $allowAsterisk whether in * at the beginning should be preserved
+	* @param string $input
 	* @return string the escaped string
 	*/
 	public function escapeFilterPart($input, $allowAsterisk = false) {
@@ -1530,7 +1532,7 @@ 
 
 	/**
 	 * Check whether the most recent paged search was successful. It flushed the state var. Use it always after a possible paged search.
-	 * @return boolean|null true on success, null or false otherwise
+	 * @return boolean true on success, null or false otherwise
 	 */
 	public function getPagedSearchResultState() {
 		$result = $this->pagedSearchedSuccessful;
@@ -1545,7 +1547,7 @@ 
 	 * @param string[] $attr optional, when a certain attribute shall be filtered outside
 	 * @param int $limit
 	 * @param int $offset
-	 * @return bool|true
+	 * @return boolean
 	 */
 	private function initPagedSearch($filter, $bases, $attr, $limit, $offset) {
 		$pagedSearchOK = false;

apps/user_ldap/lib/configuration.php

Doc Comments -1 removed lines

@@ -281,7 +281,6 @@
 	 * 
 	 * @param string $varName name of config-key
 	 * @param array|string $value to set
-	 * @param boolean $trim Trim value? (default: false)
 	 */
 	protected function setMultiLine($varName, $value) {
 		if(empty($value)) {

apps/user_ldap/lib/jobs.php

Doc Comments +1 added lines, -1 removed lines

@@ -68,7 +68,7 @@
 	}
 
 	/**
-	 * @return int
+	 * @return string
 	 */
 	static private function getRefreshInterval() {
 		//defaults to every hour

apps/user_ldap/lib/wizard.php

Doc Comments +2 added lines, -2 removed lines

@@ -864,7 +864,7 @@ 
 	 * @param integer $filterType int, for which use case the filter shall be created
 	 * can be any of self::LFILTER_USER_LIST, self::LFILTER_LOGIN or
 	 * self::LFILTER_GROUP_LIST
-	 * @return string|false string with the filter on success, false otherwise
+	 * @return string string with the filter on success, false otherwise
 	 * @throws \Exception
 	 */
 	private function composeLdapFilter($filterType) {
@@ -1107,7 +1107,7 @@ 
 	}
 
 	/**
-	 * @param array $reqs
+	 * @param string[] $reqs
 	 * @return bool
 	 */
 	private function checkRequirements($reqs) {

apps/user_ldap/tests/integration/lib/integrationtestfetchusersbyloginname.php

Unused Use Statements -1 removed lines

@@ -21,7 +21,6 @@
 
 namespace OCA\user_ldap\tests\integration\lib;
 
-use OCA\user_ldap\lib\user\Manager as LDAPUserManager;
 use OCA\user_ldap\tests\integration\AbstractIntegrationTest;
 use OCA\User_LDAP\Mapping\UserMapping;
 use OCA\user_ldap\USER_LDAP;

apps/user_ldap/user_ldap.php

Doc Comments +2 added lines, -2 removed lines

@@ -149,8 +149,8 @@
 	 * Get a list of all users
 	 *
 	 * @param string $search
-	 * @param null|int $limit
-	 * @param null|int $offset
+	 * @param integer $limit
+	 * @param integer $offset
 	 * @return string[] an array of all uids
 	 */
 	public function getUsers($search = '', $limit = 10, $offset = 0) {

build/license.php

Doc Comments +6 added lines

@@ -118,6 +118,9 @@ 
 		echo "License updated: $path" . PHP_EOL;
 	}
 
+	/**
+	 * @param string $source
+	 */
 	private function isMITLicensed($source) {
 		$lines = explode(PHP_EOL, $source);
 		while(!empty($lines)) {
@@ -131,6 +134,9 @@ 
 		return false;
 	}
 
+	/**
+	 * @param string $source
+	 */
 	private function eatOldLicense($source) {
 		$lines = explode(PHP_EOL, $source);
 		while(!empty($lines)) {

core/lostpassword/controller/lostcontroller.php

Doc Comments +1 added lines, -1 removed lines

@@ -131,7 +131,7 @@
 	}
 
 	/**
-	 * @param $message
+	 * @param string $message
 	 * @param array $additional
 	 * @return array
 	 */