Completed
Pull Request — master (#25942)
by Steven
17:53
created
apps/dav/lib/CardDAV/ImageExportPlugin.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -130,13 +130,16 @@
 block discarded – undo
130 130
 		return false;
131 131
 	}
132 132
 
133
+	/**
134
+	 * @param string $cardData
135
+	 */
133 136
 	private function readCard($cardData) {
134 137
 		return Reader::read($cardData);
135 138
 	}
136 139
 
137 140
 	/**
138 141
 	 * @param Binary $photo
139
-	 * @return Parameter
142
+	 * @return string|null
140 143
 	 */
141 144
 	private function getType($photo) {
142 145
 		$params = $photo->parameters();
Please login to merge, or discard this patch.
lib/private/App/CodeChecker/NodeVisitor.php 1 patch
Doc Comments   +15 added lines patch added patch discarded remove patch
@@ -241,6 +241,9 @@  discard block
 block discarded – undo
241 241
 		}
242 242
 	}
243 243
 
244
+	/**
245
+	 * @param string $name
246
+	 */
244 247
 	private function checkBlackList($name, $errorCode, Node $node) {
245 248
 		$lowerName = strtolower($name);
246 249
 
@@ -254,6 +257,9 @@  discard block
 block discarded – undo
254 257
 		}
255 258
 	}
256 259
 
260
+	/**
261
+	 * @param string $constantName
262
+	 */
257 263
 	private function checkBlackListConstant($class, $constantName, Node $node) {
258 264
 		$name = $class . '::' . $constantName;
259 265
 		$lowerName = strtolower($name);
@@ -268,6 +274,9 @@  discard block
 block discarded – undo
268 274
 		}
269 275
 	}
270 276
 
277
+	/**
278
+	 * @param string $class
279
+	 */
271 280
 	private function checkBlackListFunction($class, $functionName, Node $node) {
272 281
 		$name = $class . '::' . $functionName;
273 282
 		$lowerName = strtolower($name);
@@ -282,6 +291,9 @@  discard block
 block discarded – undo
282 291
 		}
283 292
 	}
284 293
 
294
+	/**
295
+	 * @param string $class
296
+	 */
285 297
 	private function checkBlackListMethod($class, $functionName, Node $node) {
286 298
 		$name = $class . '::' . $functionName;
287 299
 		$lowerName = strtolower($name);
@@ -296,6 +308,9 @@  discard block
 block discarded – undo
296 308
 		}
297 309
 	}
298 310
 
311
+	/**
312
+	 * @param string $name
313
+	 */
299 314
 	private function buildReason($name, $errorCode) {
300 315
 		if (isset($this->errorMessages[$errorCode])) {
301 316
 			$desc = $this->list->getDescription($errorCode, $name);
Please login to merge, or discard this patch.
lib/private/DB/QueryBuilder/ExpressionBuilder/ExpressionBuilder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -360,7 +360,7 @@
 block discarded – undo
360 360
 	 *
361 361
 	 * @param string $column
362 362
 	 * @param mixed $type One of IQueryBuilder::PARAM_*
363
-	 * @return string
363
+	 * @return QueryFunction
364 364
 	 */
365 365
 	public function castColumn($column, $type) {
366 366
 		return new QueryFunction(
Please login to merge, or discard this patch.
apps/user_ldap/lib/Access.php 1 patch
Doc Comments   +9 added lines, -7 removed lines patch added patch discarded remove patch
@@ -313,7 +313,7 @@  discard block
 block discarded – undo
313 313
 	/**
314 314
 	 * returns the LDAP DN for the given internal ownCloud name of the group
315 315
 	 * @param string $name the ownCloud name in question
316
-	 * @return string|false LDAP DN on success, otherwise false
316
+	 * @return string|boolean LDAP DN on success, otherwise false
317 317
 	 */
318 318
 	public function groupname2dn($name) {
319 319
 		return $this->groupMapper->getDNByName($name);
@@ -395,7 +395,7 @@  discard block
 block discarded – undo
395 395
 
396 396
 	/**
397 397
 	 * returns the internal ownCloud name for the given LDAP DN of the user, false on DN outside of search DN or failure
398
-	 * @param string $dn the dn of the user object
398
+	 * @param string $fdn the dn of the user object
399 399
 	 * @param string $ldapName optional, the display name of the object
400 400
 	 * @return string|false with with the name to use in ownCloud
401 401
 	 */
@@ -412,7 +412,7 @@  discard block
 block discarded – undo
412 412
 
413 413
 	/**
414 414
 	 * returns an internal ownCloud name for the given LDAP DN, false on DN outside of search DN
415
-	 * @param string $dn the dn of the user object
415
+	 * @param string $fdn the dn of the user object
416 416
 	 * @param string $ldapName optional, the display name of the object
417 417
 	 * @param bool $isUser optional, whether it is a user object (otherwise group assumed)
418 418
 	 * @return string|false with with the name to use in ownCloud
@@ -672,7 +672,7 @@  discard block
 block discarded – undo
672 672
 	 * the login filter.
673 673
 	 *
674 674
 	 * @param string $loginName
675
-	 * @param array $attributes optional, list of attributes to read
675
+	 * @param string[] $attributes optional, list of attributes to read
676 676
 	 * @return array
677 677
 	 */
678 678
 	public function fetchUsersByLoginName($loginName, $attributes = array('dn')) {
@@ -745,7 +745,7 @@  discard block
 block discarded – undo
745 745
 
746 746
 	/**
747 747
 	 * @param string $filter
748
-	 * @param string|string[] $attr
748
+	 * @param string[] $attr
749 749
 	 * @param int $limit
750 750
 	 * @param int $offset
751 751
 	 * @return array
@@ -793,7 +793,7 @@  discard block
 block discarded – undo
793 793
 
794 794
 	/**
795 795
 	 * @param string $filter
796
-	 * @param string|string[] $attr
796
+	 * @param string[] $attr
797 797
 	 * @param int $limit
798 798
 	 * @param int $offset
799 799
 	 * @return false|int
@@ -843,6 +843,7 @@  discard block
 block discarded – undo
843 843
 	 * retrieved. Results will according to the order in the array.
844 844
 	 * @param int $limit optional, maximum results to be counted
845 845
 	 * @param int $offset optional, a starting point
846
+	 * @param string $filter
846 847
 	 * @return array|false array with the search result as first value and pagedSearchOK as
847 848
 	 * second | false if not successful
848 849
 	 */
@@ -1097,7 +1098,7 @@  discard block
 block discarded – undo
1097 1098
 
1098 1099
 	/**
1099 1100
 	 * @param string $name
1100
-	 * @return bool|mixed|string
1101
+	 * @return string
1101 1102
 	 */
1102 1103
 	public function sanitizeUsername($name) {
1103 1104
 		if($this->connection->ldapIgnoreNamingRules) {
@@ -1121,6 +1122,7 @@  discard block
 block discarded – undo
1121 1122
 	* escapes (user provided) parts for LDAP filter
1122 1123
 	* @param string $input, the provided value
1123 1124
 	* @param bool $allowAsterisk whether in * at the beginning should be preserved
1125
+	* @param string $input
1124 1126
 	* @return string the escaped string
1125 1127
 	*/
1126 1128
 	public function escapeFilterPart($input, $allowAsterisk = false) {
Please login to merge, or discard this patch.